Repository navigation
refactor(server): remove test-only rolling refresh request wrapper (#801) - #832
Merged
Merged
Conversation
4 of 13 tasks
Rebase #832 onto latest dev and retain direct production-logic tests.
SunSi12138
force-pushed
the
cleanup/issue-801-rolling-refresh-test-facade
branch
from
October 11, 2026 10:15
14cfe04 to
caa9874
Compare
SunSi12138
marked this pull request as ready for review
October 11, 2026 10:20
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refs #801.
Scope
SharpLinkServer.TryCreateRollingSessionRefreshRequestForTesting, an internal thin forwarding method referenced only by two assertions inSharpLinkServerDesiredSessionReviewTests.TryCreateRollingSessionRefreshRequest(pinned, out request)method fromprivatetointernal; the test calls that same method directly. ExistingRequestSessionRefreshIfStaleAsynccontinues calling the identical implementation with the same desired-session lock, generation and server-ID guards.Verification
Exact
devbase6f19cd0cfd1bde4a4911bf59c413205d4ce93cd4(includes #810/#815/#816). This is solely deletion of a test shim and an internal visibility change to the real method. Draft pending exact-head Release/PR Fast, Package Smoke, CodeQL, and desired-session review and integration regressions.