Repository navigation
refactor(3.0): delete 44 remaining verified unused methods after #806 (#801) - #810
Merged
Merged
Conversation
This was referenced Oct 11, 2026
Owner
Author
Exact-head cross-platform NativeAOT evidenceActions #38115419654 checked out this PR's exact committed source
No test substitution or modified checkout: workflow lives on the separate audit branch, and checks the PR's source at the pinned SHA. This is real desktop NativeAOT evidence; does not claim mobile hardware coverage. |
SunSi12138
force-pushed
the
cleanup/issue-801-verified-dead-methods
branch
from
October 11, 2026 05:55
0b735a7 to
b07e85a
Compare
SunSi12138
force-pushed
the
cleanup/issue-801-verified-dead-methods
branch
from
October 11, 2026 07:27
b07e85a to
13e313a
Compare
This was referenced Oct 11, 2026
SunSi12138
added a commit
that referenced
this pull request
Oct 11, 2026
SunSi12138
marked this pull request as ready for review
October 11, 2026 08:54
SunSi12138
added a commit
that referenced
this pull request
Oct 11, 2026
SunSi12138
added a commit
that referenced
this pull request
Oct 11, 2026
This was referenced Oct 11, 2026
SunSi12138
added a commit
that referenced
this pull request
Oct 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Current version: rebased onto latest
devafter #813Current head:
13e313ab1831Base:
9fb2744300ee, including merged #807, #808, #809, #811, #812, and #813.This is a clean, single commit based directly on current
dev. It preserves the frozen #801 audit selection after #806 independently deleted one candidate: 44 unused non-public methods removed, with 1 bodyless source-generated logger partial intentionally retained. Scope: 31 production files,+26/-877vs the new base. No additional candidates, public/generated ABI, or wire-contract changes are introduced by #810.Conflict resolution and cleanup
SharpLinkClient.RpcChannel.cs: retain refactor(3.0)!: decouple IRpcChannel from unused client-stream sink (#801) #811's deletion of the unsupported channelSendClientStreamAsync<T>facade and refactor(3.0): delete 44 remaining verified unused methods after #806 (#801) #810's deletion of the unusedSendRpcCall. Do not restore either method.RpcSessionExtensions.cs: retain refactor(runtime): remove test-only unbounded RPC error send path (#801) #813's deletion of the test-onlySendRpcErrorAsyncand its privateSendErrorFramehelper and refactor(3.0): delete 44 remaining verified unused methods after #806 (#801) #810's other unused send-method removals. Preserve the productionSendRpcErrorWithBackpressureAsync,SendErrorFrameWithBackpressureAsync, and handshakeSendErrorFrameAndFlushAsyncpaths.///XML documentation lines left at deletion sites inRpcSessionExtensions.cs,StreamManager.cs, andStripedLongMap.cs.devcontains no non-whitespace added lines; upstream deletions and unrelated merged changes remain in the base. GitHub now reportsmergeable: true, 1 commit ahead / 0 behind.CI for this exact head
Do not attribute historical CI to this commit. Prior rebase validation #38116153659 validated the earlier
b07e85a5head based on #806, not this replacement head.Review: still Draft; PR Extended (full IntegrationTests, desktop compatibility and extended NativeAOT) is triggered when the PR becomes ready for review. No merge requested.
Related #801, #806, #811, #813.