Repository navigation
fix(lane): inspection reads module-libs.txt from the build step's packdir output - #2933
Conversation
… packdir output — not a hard-coded layout First coherent global-build lap (33472830308): workspace jobs GREEN, every pack's shelf rides carried correct provenance, and the inspection still failed all 8 shelf-consuming modules — it read module-libs.txt from the old module-build/ layout, got an empty allow-list, and counted every ride as unaccounted. PACKDIR now comes from steps.build.outputs, the same source the pack step uses, so the two can never disagree about where the input lives. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
There was a problem hiding this comment.
Pull request overview
Updates the module-pack reusable workflow’s inspection step to read module-libs.txt from the build step’s declared pack input directory, keeping inspection aligned with the new global workspace build layout and preventing false failures when the old hard-coded path no longer exists.
Changes:
- Export
PACKDIRinto the “Inspect the bundle” step fromsteps.build.outputs.packdir. - Switch the container inspection’s
shelf_manifestpath from the legacy$RUNNER_TEMP/module-build/...layout to$PACKDIR/module-libs.txt.
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Test Results (shard 0)793 tests 789 ✅ 3m 23s ⏱️ Results for commit 5968cf3. |
Test Results (shard 1)1 136 tests 1 136 ✅ 4m 1s ⏱️ Results for commit 5968cf3. |
Test Results (shard 5) 8 files 8 suites 4m 12s ⏱️ Results for commit 5968cf3. |
Test Results (shard 4)1 165 tests 1 165 ✅ 4m 37s ⏱️ Results for commit 5968cf3. |
Test Results (shard 2)3 059 tests 2 867 ✅ 6m 10s ⏱️ Results for commit 5968cf3. |
Test Results (shard 3)1 152 tests 1 152 ✅ 8m 0s ⏱️ Results for commit 5968cf3. |
Test Results 44 files 44 suites 30m 26s ⏱️ Results for commit 5968cf3. |
Workspace jobs green, pack provenance correct, inspection reading the OLD module-build/ layout → empty allow-list → 8 false reds. One path, sourced from
steps.build.outputs.packdir. YAML-only — Plugins re-pins the lane SHA, digests unchanged.🤖 Generated with Claude Code