Skip to content

fix(lane): inspection reads module-libs.txt from the build step's packdir output #2933

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
rbuergi merged 1 commit into from
Sep 1, 2026
Merged

fix(lane): inspection reads module-libs.txt from the build step's packdir output #2933

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion .github/workflows/node-repo-module-pack.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1153,6 +1153,7 @@ jobs:
VERSION: ${{ steps.identity.outputs.version }}
FLOOR: ${{ steps.identity.outputs.floor }}
COMPILER: ${{ steps.build.outputs.compiler }}
PACKDIR: ${{ steps.build.outputs.packdir }}
run: |
set -euo pipefail
bundle="$RUNNER_TEMP/bundles/MeshWeaver.Plugin.$PACKAGE.$VERSION.module.nupkg"
Expand Down Expand Up @@ -1199,7 +1200,11 @@ jobs:
# A non-MeshWeaver assembly is allowed ONLY with shelf provenance: the builder's
# module-libs.txt names every ride it derived from the shelf's deps.json. Anything
# else has no accountable closure and must fail — the 2026-08-19/20 outage shape.
shelf_manifest="$RUNNER_TEMP/module-build/$MODULE/module-libs.txt"
# 🚨 FROM THE BUILD STEP'S OWN packdir output — never a hard-coded layout. The global
# workspace moved the pack input to workspace-build/<Module>; this path still reading
# module-build/ made the allow-list EMPTY and failed all 8 shelf-consuming modules on
# the first coherent global-build lap (33472830308) with perfectly correct manifests.
shelf_manifest="$PACKDIR/module-libs.txt"
allowed="$( [ -f "$shelf_manifest" ] && tr '\n' ';' < "$shelf_manifest" || true )"
jq -e --arg allowed "$allowed" \
'($allowed | split(";") | map(select(length > 0))) as $shelf
Expand Down
Loading