Skip to content

server : reject a realtime session.update with another sample rate - #10

Closed
T0mSIlver wants to merge 1 commit into
upstream-masterfrom
realtime-rate-master
Closed

T0mSIlver wants to merge 1 commit into
upstream-masterfrom
realtime-rate-master

Conversation

@T0mSIlver

@T0mSIlver T0mSIlver commented Nov 4, 2026 •

Copy link
Copy Markdown
Owner

Draft for review on the fork; rewrite it in your own words before opening upstream (llama.cpp does not accept AI-written PR text). Based on upstream master. Post the issue first (draft in T0mSIlver/tom#311) and replace #xxxx with its number.

Overview

Fixes #xxxx.

A session.update whose audio.input.format.rate is not the model's sample rate now gets an error event (audio.input.format.rate must be 16000), and the session keeps its previous settings. Updates that don't set a rate behave as before. The check compares the JSON value itself, so the string "24000" and 16000.5 are rejected too.

It also replaces a README note, out of date since ggml-org#30994, that said held-back words go to the next item.

Requirements

@T0mSIlver

Copy link
Copy Markdown
Owner Author

Opened upstream as ggml-org#31697.

@T0mSIlver T0mSIlver closed this Nov 4, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant