Repository navigation
Conversation
Assisted-by: Claude Code
Assisted-by: Claude Code
Assisted-by: Claude Code
Owner
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Review: Codex (gpt-6.1-sol, low effort) on 5e7c1ac, no findings.
Overview
The server always plays
input_audio_buffer.appendaudio at the model's sample rate (16 kHz for Voxtral), because the audio is raw 16-bit samples with no header. Today a client can still setsession.audio.input.format.rateto another value, such as the 24 kHz that OpenAI Realtime clients use by default. The server accepts it, then transcribes audio played at the wrong speed, and nothing reports the problem.This PR makes the server answer such a
session.updatewith anerror(audio.input.format.rate must be 16000) and keep the previous session settings. Updates that don't set a rate behave as before. The check compares the JSON value itself, so the string"24000"and 16000.5 are rejected too; reading it withjson_value()would have turned the string into the default and cut off the fraction.It also removes a README note, now out of date since ggml-org#30994, saying held-back words go to the next item.
Additional information
test_realtime_control_eventsnow sends four updates: 24000,"24000"as a string, 16000.5 and 16000.For scale: on an RTX 3090, 24 kHz audio read as 16 kHz gave a 41% word error rate, against about 22% for the same audio at 16 kHz.
Requirements