Skip to content

Context menu iOS 13 API#1795

Merged
jparise merged 1 commit into
TextureGroup:masterfrom
uuttff8:context-menus-ios-13
Apr 1, 2020
Merged

Context menu iOS 13 API#1795
jparise merged 1 commit into
TextureGroup:masterfrom
uuttff8:context-menus-ios-13

Conversation

@uuttff8

@uuttff8 uuttff8 commented Apr 1, 2020

Copy link
Copy Markdown
Contributor

Fixes #1771

@CLAassistant

CLAassistant commented Apr 1, 2020

Copy link
Copy Markdown

CLA assistant check
All committers have signed the CLA.

@jparise jparise added the iOS 13 label Apr 1, 2020
@jparise
jparise merged commit ce0aebf into TextureGroup:master Apr 1, 2020
@jparise

jparise commented Apr 1, 2020

Copy link
Copy Markdown
Member

Thank you, @uuttff8!

@IvanChan

IvanChan commented Apr 2, 2020

Copy link
Copy Markdown
Contributor

@jparise @uuttff8 this commit is something missing with nonnull/nullable declare which cause swift code import build error

func tableView(_ tableView: UITableView, contextMenuConfigurationForRowAt indexPath: IndexPath, point: CGPoint) -> UIContextMenuConfiguration?

func tableView(_ tableView: UITableView, contextMenuConfigurationForRowAt indexPath: IndexPath, point: CGPoint) -> UIContextMenuConfiguration

That would be 2 different func

@uuttff8

uuttff8 commented Apr 2, 2020

Copy link
Copy Markdown
Contributor Author

@IvanChan should it be - (nullable UIContextMenuConfiguration *)tableView:(UITableView *)tableView contextMenuConfigurationForRowAtIndexPath:(NSIndexPath *)indexPath point:(CGPoint)point API_AVAILABLE(ios(13.0)); ?

@IvanChan

IvanChan commented Apr 2, 2020

Copy link
Copy Markdown
Contributor

Swift version will look like below, copy from apple UITableView header

with ? will be nullable

  @available(iOS 13.0, *)
    optional func tableView(_ tableView: UITableView, shouldBeginMultipleSelectionInteractionAt indexPath: IndexPath) -> Bool

    @available(iOS 13.0, *)
    optional func tableView(_ tableView: UITableView, didBeginMultipleSelectionInteractionAt indexPath: IndexPath)

 @available(iOS 13.0, *)
    optional func tableViewDidEndMultipleSelectionInteraction(_ tableView: UITableView)

 @available(iOS 13.0, *)
    optional func tableView(_ tableView: UITableView, contextMenuConfigurationForRowAt indexPath: IndexPath, point: CGPoint) -> UIContextMenuConfiguration?

 @available(iOS 13.0, *)
    optional func tableView(_ tableView: UITableView, previewForHighlightingContextMenuWithConfiguration configuration: UIContextMenuConfiguration) -> UITargetedPreview?

 @available(iOS 13.0, *)
    optional func tableView(_ tableView: UITableView, previewForDismissingContextMenuWithConfiguration configuration: UIContextMenuConfiguration) -> UITargetedPreview?

@available(iOS 13.0, *)
    optional func tableView(_ tableView: UITableView, willPerformPreviewActionForMenuWith configuration: UIContextMenuConfiguration, animator: UIContextMenuInteractionCommitAnimating)

jparise added a commit to jparise/Texture that referenced this pull request Apr 2, 2020
These were recently introduced in TextureGroup#1795 but were missing `nullable`
annotations on their return types.

Also, reorder the declarations to match `UITableView.h`.
@jparise

jparise commented Apr 2, 2020

Copy link
Copy Markdown
Member

Should be fixed by #1796.

jparise added a commit that referenced this pull request Apr 2, 2020
These were recently introduced in #1795 but were missing `nullable`
annotations on their return types.

Also, reorder the declarations to match `UITableView.h`.
piotrdebosz pushed a commit to getstoryteller/Texture that referenced this pull request Mar 1, 2021
piotrdebosz pushed a commit to getstoryteller/Texture that referenced this pull request Mar 1, 2021
…#1796)

These were recently introduced in TextureGroup#1795 but were missing `nullable`
annotations on their return types.

Also, reorder the declarations to match `UITableView.h`.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

AsyncDelegate for ASTableNode/ASCollectionNode missing forwarding iOS 13 new api

4 participants