Skip to content

Add support for collection view context menus#1817

Closed
drinkius wants to merge 1 commit into
TextureGroup:masterfrom
drinkius:master
Closed

Add support for collection view context menus#1817
drinkius wants to merge 1 commit into
TextureGroup:masterfrom
drinkius:master

Conversation

@drinkius

Copy link
Copy Markdown
Contributor

No description provided.

@CLAassistant

CLAassistant commented May 17, 2020

Copy link
Copy Markdown

CLA assistant check
All committers have signed the CLA.

@drinkius

Copy link
Copy Markdown
Contributor Author

It's a counterpart to #1795 which initially didn't support UICollectionView's updated API

@jparise

jparise commented May 17, 2020

Copy link
Copy Markdown
Member

@drinkius The CI check appears to be failing with a git error:

git checkout --progress --force ac6515566fd7316f3eee1c76e5a174609a452079
##[error]fatal: reference is not a tree: ac6515566fd7316f3eee1c76e5a174609a452079

Could you try rebasing your changes on top of the latest master commit and pushing again?

@bolsinga

Copy link
Copy Markdown
Contributor

@drinkius Please try rebasing or merging again.

@bolsinga

bolsinga commented Jun 3, 2020

Copy link
Copy Markdown
Contributor

Is this covered by #1860 now?

@drinkius

drinkius commented Jun 3, 2020

Copy link
Copy Markdown
Contributor Author

@bolsinga seems so, sorry, was swamped at work lately and didn't have time to add fixes

@drinkius drinkius closed this Jun 3, 2020
@bolsinga

bolsinga commented Jun 3, 2020

Copy link
Copy Markdown
Contributor

@bolsinga seems so, sorry, was swamped at work lately and didn't have time to add fixes

No problem! I understand completely. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants