Raise deployment target to iOS 9#743
Merged
Merged
Conversation
Adlai-Holler
requested review from
appleguy,
garrettmoon,
maicki and
nguyenhuy
January 15, 2018 00:02
This was referenced Jan 15, 2018
Adlai-Holler
force-pushed
the
AHDropIOS8
branch
from
January 15, 2018 19:52
5cc0152 to
147ca23
Compare
Adlai-Holler
force-pushed
the
AHDropIOS8
branch
from
January 15, 2018 19:57
147ca23 to
36d777b
Compare
Adlai-Holler
force-pushed
the
AHDropIOS8
branch
from
January 15, 2018 20:16
36d777b to
5fdff2e
Compare
appleguy
reviewed
Jan 15, 2018
| return; | ||
| } | ||
|
|
||
| #if TARGET_OS_IOS |
Member
There was a problem hiding this comment.
I'm pretty sure you can't remove these — they were added for the tvOS build.
appleguy
reviewed
Jan 15, 2018
| spec.ios.deployment_target = '8.0' | ||
|
|
||
| # Uncomment when fixed: issues with tvOS build for release 2.0 | ||
| # spec.tvos.deployment_target = '9.0' |
Member
There was a problem hiding this comment.
Let's not remove this yet - there are a few PRs pending with tvOS support, and there's still developer interest on that platform (besides other folks who have asked for it, I also have plans for a work project).
appleguy
approved these changes
Jan 15, 2018
appleguy
left a comment
appleguy
left a comment
Member
There was a problem hiding this comment.
Looks very good! Definitely the right time to remove iOS 8 support.
Could you put back the IOS gating checks that enabled the tvOS build?
Member
Author
|
Yep, done. Waiting for CI |
Member
Author
|
Oops i phone merged and forgot to change the base branch. Fortunately #746 is ready to merge. |
Adlai-Holler
pushed a commit
that referenced
this pull request
Jan 15, 2018
#743 Manually merged since I forgot to retarget that diff onto master before merge
bernieperez
pushed a commit
to AtomTickets/Texture
that referenced
this pull request
Apr 25, 2018
TextureGroup#743 Manually merged since I forgot to retarget that diff onto master before merge
ZaytsevaMarina
pushed a commit
to erupakov/Telegram-iOS
that referenced
this pull request
May 27, 2026
TextureGroup/Texture#743 Manually merged since I forgot to retarget that diff onto master before merge
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This drops support for iOS 8 and raises the deployment target of all projects to iOS 9.
CocoaPods has changed a lot since some of these examples were pod installed, so I went ahead and checked in the changes applied by CocoaPods 1.3.1. We'll see how the CI fares with that. Also, Xcode 9 has some new workspace metadata that is shared between users (tiny files) so I let that get checked in too so that we have cleaner working copies.
I think this justifies a minor release, but not a major one, since probably 0 people are still targeting iOS 8.
This diff has #746 as its base so that I don't get overwhelmed with Danger warnings. Once that is landed, I'll change the base for this to master.