Replicate relevant GenTool fixes and improvements #850

Activity

1. xezon

   added

   CriticalSeverity: Minor < Major < Critical < BlockerSeverity: Minor < Major < Critical < Blocker

   GenToolRelates to GenToolRelates to GenTool

   on May 13, 2025
2. xezon

   added the

   Task

   issue type on May 13, 2025
3. Mauller commented on May 13, 2025

   

   Mauller

   on May 13, 2025

   More actions

   If we are looking to start adding some of these now, i can sort #73 and #104 pretty quickly.

   I think #72 probably wants some more discussion around if we consider limiting what aspect ratios can be used.
   I tried the PR that fixes this but set a max limit for 16:9 and that worked quite well.
4. Mauller commented on May 13, 2025

   

   Mauller

   on May 13, 2025

   More actions

   i tried looking into #75 but couldn't reproduce the crashing, could you upload the attached file again?
5. Mauller commented on May 13, 2025

   

   Mauller

   on May 13, 2025

   Last edited by Mauller

   More actions

   EDIT: This code is for the communicator that shows player info, i mistook what it did but roossienb has a PR for enabling chat as an observer.

   it looks like #74 may already have functionality within CommandBarObserver.cpp but it has been commented out.

   //	if( controlID == buttonCommunicator && TheGameLogic->getGameMode() == GAME_INTERNET )
   /*
   {
   	popupCommunicatorLayout = TheWindowManager->winCreateLayout( AsciiString( "Menus/PopupCommunicator.wnd" ) );
   	popupCommunicatorLayout->runInit();
   	popupCommunicatorLayout->hide( FALSE );
   	popupCommunicatorLayout->bringForward();
   }
   */
6. Mauller commented on May 13, 2025

   

   Mauller

   on May 13, 2025

   More actions

   It looks like they were going to make health bars scalable with zoom level, but didn't go much further.

   But it's all contained in drawable Drawable::drawHealthBar. There are other things in there too for it.
7. barefootlogician commented on May 19, 2025

   

   barefootlogician

   on May 19, 2025

   More actions

   I already have full viewport enabled in a branch but its not compatible with the default command bar. There are various ways I could make it toggle-able
8. barefootlogician commented on May 19, 2025

   

   barefootlogician

   on May 19, 2025

   More actions

   A lot of these changes should be worked on after graphical frame rate is decoupled from logic frames
9. Mauller commented on May 19, 2025

   

   Mauller

   on May 19, 2025

   Last edited by Mauller

   More actions

   I already have full viewport enabled in a branch but its not compatible with the default command bar. There are various ways I could make it toggle-able

   we can prevent the command bar code from resizing the viewport and make the command bar scale properly with resolution while maintaining it's original proportions. This way it won't stretch horribly beyond 4:3 and we can add the ability to adjust the scale of it with resolution so it's not horribly stretched out of shape.

   A lot of these changes should be worked on after graphical frame rate is decoupled from logic frames

   That's going to be quite a significant change overall and likely further down the line if anything
10. barefootlogician commented on May 19, 2025

    

    barefootlogician

    on May 19, 2025

    More actions

    I already have full viewport enabled in a branch but its not compatible with the default command bar. There are various ways I could make it toggle-able

    we can prevent the command bar code from resizing the viewport and make the command bar scale properly with resolution while maintaining it's original proportions. This way it won't stretch horribly beyond 4:3 and we can add the ability to adjust the scale of it with resolution so it's not horribly stretched out of shape.

    A lot of these changes should be worked on after graphical frame rate is decoupled from logic frames

    That's going to be quite a significant change overall and likely further down the line if anything

    The issue isn't scaling or any of that. The default command bar makes the viewport about 70% it's original height and pushes it up, hence why we get the black bar if we use command bar pro without gentool. We can disable this and it will technically still work fine with the original command bar but then it makes seeing things at the bottom of the map impossible without rotating the camera or minimizing the command bar.

    It being further down the line is fine but then these other changes will also have to be further down the line unless we want to reimplement them afterwards.
11. Mauller commented on May 19, 2025

    

    Mauller

    on May 19, 2025

    Last edited by Mauller

    More actions

    The issue isn't scaling or any of that. The default command bar makes the viewport about 70% it's original height and pushes it up

    I did say about preventing it resizing the viewport the command bar code is what causes the viewport to change size.

    Better scaling at higher resolutions will mean it's not covering as much of the view etc. It doesn't need to take up 30% of the screen at higher resolutions like it currently does.
12. barefootlogician commented on May 19, 2025

    

    barefootlogician

    on May 19, 2025

    More actions

    The issue isn't scaling or any of that. The default command bar makes the viewport about 70% it's original height and pushes it up

    I did say about preventing it resizing the viewport the command bar code is what causes the viewport to change size.

    Better scaling at higher resolutions will mean it's not covering as much of the view etc. It doesn't need to take up 30% of the screen at higher resolutions like it currently does.

    But then it would be too wide for the height. I don't think gentool changes the command bar height does it? That would be a different enhancement unrelated to this post
13. xezon

    pinned this issue on Jul 20, 2025
14. L3-M commented on Sep 8, 2025

    

    L3-M

    on Sep 8, 2025

    More actions

    Fix Auto Camera Height in Replay (when player is selected)

    What is exactly this change?