Repository navigation
Conversation
dmgreeny
added
Minor
Contributor
Author
|
Ready to merge |
xezon
reviewed
Mar 27, 2025
| BP: "OPÇÕES DE VÍDEO AVANÇADAS" | ||
| PL: "Zaawansowane opcje wyświetlania" | ||
| US: "ADVANCED GRAPHICS SETTINGS" | ||
| DE: "ERWEITERTE GRAFIKEINSTELLUNGEN" |
Contributor
There was a problem hiding this comment.
You made some of these string upper case. Is this consistent with the other titles of the respective languages? Aka does DE have upper case titles for other screens? If not, then this would introduce an inconsistency.
Concerns DE and PL.
Contributor
Author
There was a problem hiding this comment.
Can you please check DE with this branch. It doesnt load for me. All others work fine
Contributor
There was a problem hiding this comment.
All yaml files are lower case.
| --- | ||
| date: 2025-03-27 | ||
|
|
||
| title: Changes Graphics option string |
Contributor
There was a problem hiding this comment.
"Improves texts in graphics options screen"
|
|
||
|
|
||
| changes: | ||
| - fix: Improved text in Graphics option string |
Contributor
There was a problem hiding this comment.
- tweak: Improves the title of the graphics options screen for all languages.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.