Repository navigation
Conversation
dmgreeny
added
Minor
xezon
reviewed
Mar 21, 2025
xezon
left a comment
xezon
left a comment
Contributor
There was a problem hiding this comment.
Looks good. Needs comment and yaml.
| PL: "Za budynkami" | ||
| US: "Show Units Behind Buildings" | ||
| DE: "Einheiten hinter Gebäuden anzeigen" | ||
| FR: "Afficher les unités derrière les bâtiments" |
Contributor
There was a problem hiding this comment.
Does this text have enough room in the options menu?
| RU: "Отображать Войска за зданиями" | ||
| AR: "تﺎﻳﺎﻨﺒﻟا ﻒﻠﺧ" | ||
| UK: "Показувати Підрозділи за будівлями" | ||
| AR: "Show Units Behind Buildings" |
Contributor
There was a problem hiding this comment.
I suggest not change Arabic to English.
Windstalker
reviewed
Mar 25, 2025
Contributor
Author
|
Fixed and ready to merge |
xezon
reviewed
Mar 27, 2025
Contributor
|
|
||
|
|
||
| changes: | ||
| - fix: Improves text in Behind building option string |
Contributor
There was a problem hiding this comment.
- tweak: Improves the text of the behind buildings option for all languages.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.