Tests: Use assertNull() instead of assertSame() with null - #12818
Closed
Soean wants to merge 1 commit into
Closed
Conversation
Using the dedicated `null` assertion clarifies intent and produces more descriptive failure messages.
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the Core Committers: Use this line as a base for the props when committing in SVN: To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
Test using WordPress PlaygroundThe changes in this pull request can previewed and tested using a WordPress Playground instance. WordPress Playground is an experimental project that creates a full WordPress instance entirely within the browser. Some things to be aware of
For more details about these limitations and more, check out the Limitations page in the WordPress Playground documentation. |
pento
pushed a commit
that referenced
this pull request
Aug 9, 2026
Using the dedicated `assertNull()` assertion instead of `assertSame( null, $actual )` clarifies intent and produces more descriptive failure messages. Developed in #12818. Follow-up to r62969. Props Soean. See #64894. git-svn-id: https://develop.svn.wordpress.org/trunk@63161 602fd350-edb4-49c9-b593-d223f7449a82
Member
|
Thanks for the PR! Merged in r63161. |
markjaquith
pushed a commit
to markjaquith/WordPress
that referenced
this pull request
Aug 9, 2026
Using the dedicated `assertNull()` assertion instead of `assertSame( null, $actual )` clarifies intent and produces more descriptive failure messages. Developed in WordPress/wordpress-develop#12818. Follow-up to r62969. Props Soean. See #64894. Built from https://develop.svn.wordpress.org/trunk@63161 git-svn-id: http://core.svn.wordpress.org/trunk@62360 1a063a9b-81f0-0310-95a4-ce76da25c4cd
DanielHudson2
pushed a commit
to DanielHudson2/wordpress-develop
that referenced
this pull request
Aug 10, 2026
Using the dedicated `assertNull()` assertion instead of `assertSame( null, $actual )` clarifies intent and produces more descriptive failure messages. Developed in WordPress#12818. Follow-up to r62969. Props Soean. See #64894. git-svn-id: https://develop.svn.wordpress.org/trunk@63161 602fd350-edb4-49c9-b593-d223f7449a82
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Using the dedicated
assertNull()assertion instead ofassertSame( null, $actual )clarifies intent and produces more descriptive failure messages.Trac ticket: https://core.trac.wordpress.org/ticket/64894
This Pull Request is for code review only. Please keep all other discussion in the Trac ticket. Do not merge this Pull Request. See GitHub Pull Requests for Code Review in the Core Handbook for more details.