Skip to content

Tests: Use assertNull() instead of assertSame() with null #12818

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Soean wants to merge 1 commit into from
Closed

Tests: Use assertNull() instead of assertSame() with null #12818

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion tests/phpunit/tests/functions/maybeSerialize.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -222,7 +222,7 @@ public function test_deserialize_request_utility_filtered_iterator_objects( $val
}
$callback_value = $property->getValue( $new_value );

$this->assertSame( null, $callback_value );
$this->assertNull( $callback_value );
} else {
$this->assertSame( $value->count(), unserialize( $serialized )->count() );
}
Expand Down
2 changes: 1 addition & 1 deletion tests/phpunit/tests/post/types.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -626,7 +626,7 @@ public function test_removing_autosave_support_removes_rest_api_controller() {

remove_post_type_support( 'foo', 'autosave' );
$post_type_object = get_post_type_object( 'foo' );
$this->assertSame( null, $post_type_object->get_autosave_rest_controller(), 'Autosave controller should be removed.' );
$this->assertNull( $post_type_object->get_autosave_rest_controller(), 'Autosave controller should be removed.' );
_unregister_post_type( 'foo' );
}

Expand Down
4 changes: 2 additions & 2 deletions tests/phpunit/tests/post/wpAfterInsertPost.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -157,7 +157,7 @@ public function test_new_post_via_wp_insert_post() {
)
);

$this->assertSame( null, self::$passed_post_before_status );
$this->assertNull( self::$passed_post_before_status );
$this->assertSame( 'a new post', self::$passed_post_title );
}

Expand Down Expand Up @@ -197,7 +197,7 @@ public function test_new_post_via_rest_controller() {
);
rest_get_server()->dispatch( $request );

$this->assertSame( null, self::$passed_post_before_title );
$this->assertNull( self::$passed_post_before_title );
$this->assertSame( 'new title', self::$passed_post_title );
}

Expand Down
2 changes: 1 addition & 1 deletion tests/phpunit/tests/rest-api/rest-settings-controller.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -794,6 +794,6 @@ public function test_provides_setting_metadata_in_schema() {
$this->assertSame( 'string', $title['type'] );
$this->assertSame( 'Title', $title['title'] );
$this->assertSame( 'Site title.', $title['description'] );
$this->assertSame( null, $title['default'] );
$this->assertNull( $title['default'] );
}
}
12 changes: 6 additions & 6 deletions tests/phpunit/tests/theme/wpGetBlockCssSelector.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -131,7 +131,7 @@ public function test_no_feature_level_selector_via_selectors_api() {
);

$selector = wp_get_block_css_selector( $block_type, 'typography' );
$this->assertSame( null, $selector );
$this->assertNull( $selector );
}

/**
Expand Down Expand Up @@ -205,7 +205,7 @@ public function test_no_feature_selector_via_experimental_property() {
);

$selector = wp_get_block_css_selector( $block_type, 'typography' );
$this->assertSame( null, $selector );
$this->assertNull( $selector );
}

/**
Expand Down Expand Up @@ -262,7 +262,7 @@ public function test_no_subfeature_level_selector_via_selectors_api() {
);

$selector = wp_get_block_css_selector( $block_type, array( 'typography', 'fontSize' ) );
$this->assertSame( null, $selector );
$this->assertNull( $selector );
}

/**
Expand Down Expand Up @@ -297,7 +297,7 @@ public function test_no_subfeature_selector_via_experimental_property() {
$block_type,
array( 'typography', 'fontSize' )
);
$this->assertSame( null, $selector );
$this->assertNull( $selector );
}

/**
Expand All @@ -311,10 +311,10 @@ public function test_empty_target_returns_null() {
);

$selector = wp_get_block_css_selector( $block_type, array() );
$this->assertSame( null, $selector );
$this->assertNull( $selector );

$selector = wp_get_block_css_selector( $block_type, '' );
$this->assertSame( null, $selector );
$this->assertNull( $selector );
}

/**
Expand Down
Loading