Repository navigation
ate-setup: component redeploys keep the system overlay's settings - #2646
Closed
Davanum Srinivas (dims) wants to merge 1 commit into
Closed
Davanum Srinivas (dims) wants to merge 1 commit into
Davanum Srinivas (dims) wants to merge 1 commit into
Conversation
deploy apiserver and deploy controller applied the base manifest, so on kind the api-server lost the overlay's rustfs settings and its new pod crash-looped on missing GCS credentials. Render the overlay and keep the component's objects.
Davanum Srinivas (dims)
changed the title
Davanum Srinivas (dims)
marked this pull request as ready for review
October 14, 2026 14:13
Collaborator
Author
|
Superseded by #2682, which gave the kind api-server patch its own overlay. The controller half has no kind patch to preserve today. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Redeploying the API server on kind dropped its local object-store settings, causing the new pod to crash while looking for GCS credentials. API server and controller redeploys now preserve the system overlay's settings and apply only the selected component's resources.
go test -race ./cmd/ate-setup/internal/steps/, with a test that the kind render carries the objectstore-plugin settings;go vet.