Repository navigation
ate-setup deploy apiserver works on kind clusters - #2682
Merged
Dmitry Berkovich (dberkov) merged 2 commits intoOct 15, 2026
Merged
Dmitry Berkovich (dberkov) merged 2 commits into
Dmitry Berkovich (dberkov) merged 2 commits into
Conversation
Haven Xia (HavenXia)
force-pushed
the
kind-apiserver-overlay
branch
from
October 14, 2026 23:09
3096506 to
03464ac
Compare
| } | ||
|
|
||
| // apiServerManifestPath is the ate-api-server manifest for the environment. | ||
| func (e *Env) apiServerManifestPath() string { |
Collaborator
There was a problem hiding this comment.
🤖 nit 🟢 – DeployAtelet still inlines its kind path (e.Cfg.Path(installDir + "/kind/atelet"), deploy.go:473) while this and postgresManifestPath are helpers. An ateletManifestPath would let TestAPIServerManifestMatchesSystemBundle cover the atelet DaemonSet too, guarding the same bug class for the other single-component redeploy. Fine as a follow-up.
On kind, the system bundle patches ate-api-server so its object-store plugin uses the in-cluster rustfs. deploy apiserver rendered the base ate-api-server.yaml instead. A kind redeploy therefore reset the plugin to GCS, and the new pod never became ready. Move the patch into a kind/ate-api-server overlay, the same way kind/atelet is set up. The kind bundle builds on that overlay and DeployAteAPIServer applies it on kind. The rendered kind bundles are unchanged.
Give atelet the same manifest path helper as ate-api-server, and compare its DaemonSet against the system bundle in the same test. If a kind redeploy of atelet ever went back to the base file, it would hit the bug ate-api-server had, and the test would catch it.
Haven Xia (HavenXia)
force-pushed
the
kind-apiserver-overlay
branch
from
October 15, 2026 04:08
03464ac to
9a3adf2
Compare
Dmitry Berkovich (dberkov)
approved these changes
Oct 15, 2026
2 tasks done
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
On kind,
ate-setup deploy apiserverdoesn't work because the kind settings forate-api-serverlived only as an inline patch in the kind system bundle, so this command dropped them.The patch now lives in its own overlay,
manifests/ate-install/kind/ate-api-server, the waykind/ateletalready works.Found while running the upgrade E2E on kind, where
ate-setup deploy apiservertimed out.Part of #1686