fix: add support for ACP writeTextFile clientCapability - #22674
Open
aprogramq wants to merge 1 commit into
Open
Conversation
aprogramq
force-pushed
the
fix-write-text-file-capability
branch
from
April 25, 2026 13:57
9400ac8 to
e394255
Compare
aprogramq
force-pushed
the
fix-write-text-file-capability
branch
3 times, most recently
from
May 3, 2026 00:14
821b0e5 to
375d441
Compare
aprogramq
marked this pull request as draft
May 6, 2026 07:36
aprogramq
force-pushed
the
fix-write-text-file-capability
branch
2 times, most recently
from
May 6, 2026 09:38
1df5006 to
c7e883f
Compare
aprogramq
marked this pull request as ready for review
May 6, 2026 09:39
3 tasks
|
Superseded by #28734, which rebases this same fix onto current |
Author
It seems like PR is taking a long time to process right now, so I don't check it regularly. But thanks anyway for keeping PR up to date. I hope I live to see the day when it's merged). |
aprogramq
force-pushed
the
fix-write-text-file-capability
branch
from
June 13, 2026 23:02
0d5e5c5 to
b02dc8f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue for this PR
Fixes #4240
Type of change
What does this PR do?
This fixes ACP file syncing for clients that advertise the
fs.writeTextFilecapability.The change stores
clientCapabilitiesduring ACP initialization, includessessionIDinfile.editedevents, and on file edits sends the updated file contents back to the ACP client throughwriteTextFile.The SDK/OpenAPI types were updated as part of the event shape change.
How did you verify your code works?
Zed editor
Checklist
I'm reopening this pull request 6902, as it was closed due to the time limit expiring. The issue is still relevant.