fix(acp): include shell command in permission request - #28734
Conversation
|
The following comment was made by an LLM, it may be inaccurate: Based on my search, I found a related PR: Related PR:
Why it's related: According to your PR description, PR #22674 is the original submission of this exact fix. You mention: "This is a re-submission of the same fix from PR #22674, which addressed the same issue but went stale. The diff is functionally identical; it has been rebased onto the current Since PR #22674 went stale and you're resubmitting the rebased fix as PR #28734, ensure PR #22674 is closed/marked as superseded before merging this one. |
|
Thanks for updating your PR! It now meets our contributing guidelines. 👍 |
b85a1bd to
3a0c73f
Compare
|
This PR doesn't fully meet our contributing guidelines and PR template. What needs to be fixed:
Please edit this PR description to address the above within 2 hours, or it will be automatically closed. If you believe this was flagged incorrectly, please let a maintainer know. |
|
This pull request has been automatically closed because it was not updated to meet our contributing guidelines within the 2-hour window. Feel free to open a new pull request that follows our guidelines. |
Issue
Closes #4240 (partial — the
writeTextFilegap is addressed separately in dev)Type of change
What does this PR do?
When opencode asks for permission to run a shell command in ACP mode (e.g. inside Zed), the permission prompt showed only
bashor nothing at all — giving no indication of what command would actually be executed.Two fields were missing:
tool/shell.ts:ask()always passedmetadata: {}— the command string was never included in the permission requestacp/agent.ts:requestPermissionused the tool name (bash) as thetitleregardless; it now prefersmetadata.commandwhen presentWith this fix, the Zed permission prompt shows the actual command (e.g.
git status) as the title, and includes it inrawInputfor the expanded detail view.How did you verify your code works?
Tested locally in Zed with
opencode-pr28734custom agent. Permission prompts for bash commands now display the command string instead of justbash.Checklist