Repository navigation
test: isolate container-gateway and symlink-lint fixtures from the host - #1608
Merged
Merged
Conversation
Both suites failed on a developer machine with a 0002 umask and a global gitignore listing /.claude/. container-gateway created fixture .git directories group-writable, which the gateway correctly refuses; an autouse fixture now pins the umask to 022. symlink-lint staged its fixture with the global excludes file, which dropped the .claude relay the archive test needs; _git_repo now ignores global and system git config. Generated-by: Claude Code (Opus 5.5)
zeroshade
added
family:tools
This was referenced Oct 13, 2026
potiuk
approved these changes
Oct 13, 2026
3 of 11 tasks
5 tasks done
potiuk
pushed a commit
to Kaap10/magpie
that referenced
this pull request
Oct 16, 2026
…st (apache#1608) Both suites failed on a developer machine with a 0002 umask and a global gitignore listing /.claude/. container-gateway created fixture .git directories group-writable, which the gateway correctly refuses; an autouse fixture now pins the umask to 022. symlink-lint staged its fixture with the global excludes file, which dropped the .claude relay the archive test needs; _git_repo now ignores global and system git config. Generated-by: Claude Code (Opus 5.5)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
container-gatewayandsymlink-linttests fail on a developer machine with a0002umask and a global gitignore listing/.claude/— the workspace pytest hook then blocks every commit, whatever it touches.container-gateway: fixture.gitdirectories inherited the group-writable umask, which the gateway (correctly) refuses. An autouse fixture intests/test_layers.pypins the umask to022per test.symlink-lint:_git_repostaged the fixture with the developer's global excludes file, dropping the.clauderelay the archive tests need. It now runs git withGIT_CONFIG_GLOBAL=/dev/nullandGIT_CONFIG_NOSYSTEM=1.Test-only; no tool behaviour changes. The real lint is unaffected by a global gitignore, since ignore rules don't apply to tracked files.
Type of change
tools/*/withpyproject.toml) — tests onlyprek, workflows, validators)Test plan
git check-ignore -v .claude/skills/magpie-x→~/.gitignore_global:2:/.claude/; gateway stderr.git directory … is group- or world-writable; refusingunderumask 0002tools/container-gateway:uv run pytest/ruff check/ruff format --check/mypypass under the same umasktools/symlink-lint:uv run pytest/ruff check/ruff format --check/mypypass with the same global gitignoreLinked issues
None.
Generative AI disclosure
Drafted with Claude Code (Opus 5.5) and reviewed by the author; the commit carries a
Generated-by:trailer.