Repository navigation
chore: address open CodeQL notes - #1611
Merged
Merged
Conversation
…e-archive, vetted-ops Resolves code-scanning alerts 66, 69, 100, 101 and 113 without behaviour changes: - tests import the module under test one way only (`from pkg import mod as alias`) instead of mixing `import pkg.mod` with `from pkg.mod import`; - test_symlink_mode_is_platform_independent builds both archives before asserting, so the assert has no call with side effects; - the repo-tree jq program in vetted-ops is parenthesised so its implicit string concatenation reads as intended, not a missing comma. Generated-by: Claude Code (Opus 5.5)
zeroshade
added
family:tools
potiuk
approved these changes
Oct 13, 2026
5 tasks done
potiuk
pushed a commit
to Kaap10/magpie
that referenced
this pull request
Oct 16, 2026
…e-archive, vetted-ops (apache#1611) Resolves code-scanning alerts 66, 69, 100, 101 and 113 without behaviour changes: - tests import the module under test one way only (`from pkg import mod as alias`) instead of mixing `import pkg.mod` with `from pkg.mod import`; - test_symlink_mode_is_platform_independent builds both archives before asserting, so the assert has no call with side effects; - the repo-tree jq program in vetted-ops is parenthesised so its implicit string concatenation reads as intended, not a missing comma. Generated-by: Claude Code (Opus 5.5)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
py/import-and-import-from):tools/jira/tests/test_rest.pyandtools/contributor-metrics/tests/test_fetch.pyimport the module under test one way (from pkg import mod as alias) instead of mixingimport pkg.modwithfrom pkg.mod import ….py/side-effect-in-assert):test_symlink_mode_is_platform_independentbuilds both archives before asserting.license: Apache-2.0frontmatter to 13 skills #66 (py/implicit-string-concatenation-in-list): therepo-treejq program intools/vetted-ops/src/vetted_ops/ops.pyis parenthesised so the intentional concatenation no longer reads as a missing comma. The resulting string is unchanged....body of atyping.Protocolstub, and fix(skill-validator): match GitHub anchor algorithm for repeated whitespace #65 is CodeQL's workflow parser rejecting the valid YAML anchor inskill-token-count.yml.Type of change
tools/*/withpyproject.toml)Test plan
contributor-metrics,jira,reproducible-archive:uv run pytest/ruff format --check/mypypass.ruff checkpasses for the first and last;jirareports two pre-existing findings intests/test_bridge_write.py, untouched here and identical onmainvetted-ops(no dev group; run as the workspace hook does): pytest / ruff / ruff format / mypy passworkspace-pytest, skipped for host-specific failures incontainer-gateway/symlink-lintthat test: isolate container-gateway and symlink-lint fixtures from the host #1608 fixesmainGenerative AI disclosure
Drafted with Claude Code (Opus 5.5) and reviewed by the author; the commit carries a
Generated-by:trailer.