Conversation
nchammas
changed the title
nchammas
marked this pull request as ready for review
September 8, 2026 11:58
Contributor
Author
|
The CI failure seems unrelated. |
Contributor
Author
|
Tagging some others who previously reviewed #53488. |
cloud-fan
approved these changes
Sep 11, 2026
cloud-fan
left a comment
cloud-fan
left a comment
Contributor
There was a problem hiding this comment.
Review summary
The new config module matches the existing SBT project name and Maven reactor path, and its dependency edge to utils agrees with the build graph. The workflow matrix and precondition updates are internally consistent, so the existing ConfigRegistrySuite is now covered without changing user-facing Spark behavior. I found no actionable issues in the pinned patch.
Findings
0 total: 0 P0, 0 P1, 0 P2, 0 P3.
No findings.
szehon-ho
approved these changes
Sep 11, 2026
Contributor
|
I'll merge after CI is green |
Contributor
Author
|
@cloud-fan - The CI failure is unrelated: #58587 (comment) But I'll update from |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Add a new
configtest module that runs theconfig/testsbt goal (which runsConfigRegistrySuite).Why are the changes needed?
When this new suite was added in #53488 I believe it was left out of the test modules by mistake.
Does this PR introduce any user-facing change?
No.
How was this patch tested?
Confirmed that
ConfigRegistrySuitenow runs on CI.Was this patch authored or co-authored using generative AI tooling?
I wrote this patch with assistance from GitHub Copilot.