Skip to content

[SPARK-59327][BUILD] Add config test module #58587

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
nchammas wants to merge 2 commits into
base: master
Choose a base branch
from
+17 −6
Open

[SPARK-59327][BUILD] Add config test module #58587

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
430467b
add config test module
nchammas Sep 8, 2026
f0c7d59
Merge branch 'master' into config-test-module
nchammas Sep 13, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions .github/workflows/build_and_test.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -169,8 +169,8 @@ jobs:
docs=false
java25=false
fi
build=`./dev/is-changed.py -m "core,unsafe,kvstore,avro,utils,utils-java,network-common,network-shuffle,repl,launcher,examples,sketch,variant,api,catalyst,hive-thriftserver,mllib-local,mllib,graphx,streaming,sql-kafka-0-10,streaming-kafka-0-10,streaming-kinesis-asl,credential-aws,kubernetes,hadoop-cloud,spark-ganglia-lgpl,profiler,protobuf,yarn,connect,sql,hive,pipelines"`
build_core_utils=`./dev/is-changed.py -m "core,unsafe,kvstore,utils,utils-java,network-common,network-shuffle,sketch,variant,launcher"`
build=`./dev/is-changed.py -m "core,unsafe,kvstore,avro,utils,utils-java,config,network-common,network-shuffle,repl,launcher,examples,sketch,variant,api,catalyst,hive-thriftserver,mllib-local,mllib,graphx,streaming,sql-kafka-0-10,streaming-kafka-0-10,streaming-kinesis-asl,credential-aws,kubernetes,hadoop-cloud,spark-ganglia-lgpl,profiler,protobuf,yarn,connect,sql,hive,pipelines"`
build_core_utils=`./dev/is-changed.py -m "core,unsafe,kvstore,utils,utils-java,config,network-common,network-shuffle,sketch,variant,launcher"`
precondition="
{
\"build\": \"$build\",
Expand Down Expand Up @@ -289,7 +289,7 @@ jobs:
# Note that the modules below are from sparktestsupport/modules.py.
modules:
- >-
core, unsafe, kvstore, utils, utils-java,
core, unsafe, kvstore, utils, utils-java, config,
network-common, network-shuffle, sketch, variant, launcher
- >-
api, catalyst, hive-thriftserver
Expand Down Expand Up @@ -341,7 +341,7 @@ jobs:
# Skip the core/utils group when a PR doesn't touch those modules (e.g. SQL-only or
# PySpark-only changes). The precondition is opt-out: omitted means run (so periodic
# full-build workflows that set only "build": "true" keep running this entry).
- modules: ${{ fromJson(needs.precondition.outputs.required).build-core-utils == 'false' && 'core, unsafe, kvstore, utils, utils-java, network-common, network-shuffle, sketch, variant, launcher' }}
- modules: ${{ fromJson(needs.precondition.outputs.required).build-core-utils == 'false' && 'core, unsafe, kvstore, utils, utils-java, config, network-common, network-shuffle, sketch, variant, launcher' }}
env:
MODULES_TO_TEST: ${{ matrix.modules }}
EXCLUDED_TAGS: ${{ matrix.excluded-tags }}
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/maven_test.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -154,7 +154,7 @@ jobs:
- hive2.3
modules:
- >-
core,launcher,common#unsafe,common#kvstore,common#network-common,common#network-shuffle,common#sketch,common#utils,common#utils-java,common#variant
core,launcher,common#unsafe,common#kvstore,common#network-common,common#network-shuffle,common#sketch,common#utils,common#utils-java,common#config,common#variant
- >-
graphx,streaming,hadoop-cloud
- >-
Expand Down
13 changes: 12 additions & 1 deletion dev/sparktestsupport/modules.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -205,6 +205,17 @@ def __hash__(self):
],
)

config = Module(
name="config",
dependencies=[tags],
source_file_regexes=[
"common/config/",
],
sbt_test_goals=[
"config/test",
],
)

utils_java = Module(
name="utils-java",
dependencies=[tags],
Expand All @@ -218,7 +229,7 @@ def __hash__(self):

utils = Module(
name="utils",
dependencies=[tags, utils_java],
dependencies=[tags, utils_java, config],
source_file_regexes=[
"common/utils/",
],
Expand Down