[ONNX][Relay] Support "tf_crop_and_resize" in relay Resize op. - #9475
Merged
Conversation
mbrookhart
requested review from
Huyuwei,
Laurawly,
MarisaKirisame,
ZihengJiang,
anijain2305,
areusch,
comaniac,
icemelon,
jcf94,
jroesch,
junrushao,
jwfromm,
kazum,
kevinthesun,
masahi,
merrymercy,
siju-samuel,
slyubomirsky,
srkreddy1238,
tqchen,
vinx13,
wweic,
yzhliu and
zhiics
as code owners
November 9, 2021 05:21
mbrookhart
force-pushed
the
tf_crop_and_resize
branch
2 times, most recently
from
November 10, 2021 23:43
009fe49 to
50a608a
Compare
jwfromm
approved these changes
Nov 12, 2021
jwfromm
left a comment
jwfromm
left a comment
Contributor
There was a problem hiding this comment.
A few nitpicks, overall is well structured and LGTM.
| * \param array Input NDArray | ||
| * \return Converted Array. | ||
| */ | ||
| static inline Array<FloatImm> ToFloatVector(const runtime::NDArray& array) { |
Contributor
There was a problem hiding this comment.
Just curious, why was this needed? I dont see how it interacts with resize.
Contributor
Author
There was a problem hiding this comment.
I used it in DynamicToStatic to convert the ROI argument.
masahi
reviewed
Nov 13, 2021
mbrookhart
force-pushed
the
tf_crop_and_resize
branch
from
November 15, 2021 18:48
6031762 to
19b31dc
Compare
mehrdadh
pushed a commit
to mehrdadh/tvm
that referenced
this pull request
Dec 1, 2021
…e#9475) * add fallback to opset 11 * Support tf_crop_and_resize in resize op * change api use in the rest of the codebase really fix the tests * respond to review comments, improve doc strings * fix docstring indentation * remove N anc C from resize roi
mehrdadh
pushed a commit
to mehrdadh/tvm
that referenced
this pull request
Dec 1, 2021
…e#9475) * add fallback to opset 11 * Support tf_crop_and_resize in resize op * change api use in the rest of the codebase really fix the tests * respond to review comments, improve doc strings * fix docstring indentation * remove N anc C from resize roi
ylc
pushed a commit
to ylc/tvm
that referenced
this pull request
Jan 7, 2022
…e#9475) * add fallback to opset 11 * Support tf_crop_and_resize in resize op * change api use in the rest of the codebase really fix the tests * respond to review comments, improve doc strings * fix docstring indentation * remove N anc C from resize roi
yangulei
pushed a commit
to yangulei/tvm
that referenced
this pull request
Jan 11, 2022
…e#9475) * add fallback to opset 11 * Support tf_crop_and_resize in resize op * change api use in the rest of the codebase really fix the tests * respond to review comments, improve doc strings * fix docstring indentation * remove N anc C from resize roi
ylc
pushed a commit
to ylc/tvm
that referenced
this pull request
Jan 13, 2022
…e#9475) * add fallback to opset 11 * Support tf_crop_and_resize in resize op * change api use in the rest of the codebase really fix the tests * respond to review comments, improve doc strings * fix docstring indentation * remove N anc C from resize roi
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.