[Onnx] [EZ] Fix reshape bug with passing both scale and size - #9512
Closed
AndrewZhaoLuo wants to merge 2 commits into
Closed
[Onnx] [EZ] Fix reshape bug with passing both scale and size#9512AndrewZhaoLuo wants to merge 2 commits into
AndrewZhaoLuo wants to merge 2 commits into
Conversation
AndrewZhaoLuo
requested review from
Huyuwei,
jwfromm,
kazum,
mbrookhart,
siju-samuel and
srkreddy1238
as code owners
November 15, 2021 21:30
comaniac
reviewed
Nov 15, 2021
comaniac
left a comment
comaniac
left a comment
Contributor
There was a problem hiding this comment.
Thanks for the fix. Could you check whether other frontends have this issue as well?
Co-authored-by: Cody Yu <comaniac0422@gmail.com>
mbrookhart
reviewed
Nov 15, 2021
| def _impl_v13(cls, inputs, attr, params): | ||
| scale = inputs[2] | ||
| size = inputs[3] | ||
| scale_type = infer_type(scale) |
Contributor
There was a problem hiding this comment.
This will crash if scale is None?
Contributor
Author
|
This will be subsumed by #9475 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resize can either take a scale or size parameter describing how the resize operation can be performed. Both cannot be given and we throw an error if they are. However, we assume if size is present then scale is none. This is not exhaustive as sometimes it seems that an empty sequence is also sufficient for this.
See the previous opset implementations for Resize to see this case.