This repository was archived by the owner on Dec 19, 2018. It is now read-only.
Don't capture asynclocals onto Timer - #2565
Merged
Merged
Conversation
Contributor
|
I'm sure this can't hurt, but is it important? This code doesn't ship in the runtime. |
Contributor
Author
|
If it runs in VS its probably capturing stranger things :) |
Contributor
|
|
Contributor
|
Thanks @benaadams - I'm going to merge this and then apply the new package on top. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pattern is a workaround for not having api https://github.com/dotnet/corefx/issues/26523
Also a bit less captured scope onto the Task.StartNew
/cc @davidfowl