Add a convenience API for using timer in the right way - #395
Merged
Conversation
Author
|
I know I have to do a build system thing in aspnet/Universe, will wait to sort that out until this is signed off. |
davidfowl
approved these changes
Sep 9, 2018
benaadams
approved these changes
Sep 9, 2018
Member
|
Is this something that could be checked for with code analysis? (note: not in this PR) |
Author
|
everything can be checked with code analysis if you're determined enough |
Author
|
@benaadams - where did the fixes for this go in? Razor, HttpClientFactory, FileProviders, ??? others ??? |
Member
|
aspnet/Razor#2565, aspnet/SignalR#2904, aspnet/HttpClientFactory#172 FileProviders was fixed by #392 which is similar, but different |
natemcmaster
pushed a commit
that referenced
this pull request
Nov 7, 2018
ghost
locked as resolved and limited conversation to collaborators
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
/cc @davidfowl @benaadams