Repository navigation
ci(dependabot): group non-major maven bumps + declare hand-managed ignores - #78
Merged
Merged
Conversation
Dependency Review✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.Scanned FilesNone |
✅ Duplicate Code ReportTwo engines run in parallel for cross-validation. Each has its own thresholds tuned to its baseline - the real safety net is the per-engine "max increase vs base" check. ✅ PMD CPD
No new clones introduced by this PR. ✅ jscpd (language-agnostic)
No new clones introduced by this PR. Powered by astubbs/duplicate-code-cross-check |
✅ SpotBugs ReportNo bugs found (new bugs only — baseline from base branch excluded). |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #78 +/- ##
============================================
+ Coverage 78.03% 78.11% +0.07%
- Complexity 55 1074 +1019
============================================
Files 81 81
Lines 4039 4039
Branches 372 372
============================================
+ Hits 3152 3155 +3
+ Misses 712 710 -2
+ Partials 175 174 -1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
…nores Our dependabot.yml had no grouping, so every dependency opened its own PR - which is how jackson-databind arrived as a standalone PR (#76) rather than being part of the curated versions-maven-plugin dependency sweep (#73). - Add a `maven-non-major` group so routine minor/patch bumps collapse into one reviewable PR per run instead of a swarm of one-per-dependency PRs. The curated sweep remains the real driver; this is just a low-noise heads-up. - Declare `ignore:` rules for deps we manage by hand or that are deferred majors (jackson-databind, micrometer family, kafka/junit/testcontainers/ vertx/mutiny/wiremock). Declaring these in version control is better than `@dependabot ignore` PR comments, whose ignore conditions live invisibly in Dependabot's server-side state with no in-repo explanation. - Record the jackson-databind hold in docs/inflight.md - a module-local, test-scoped pin coupled to WireMock's Jackson (global pinning breaks VertxTest with HTTP 500); bump it in the next sweep with an example-metrics integration-test check. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
astubbs
force-pushed
the
ci/dependabot-group-and-ignore
branch
from
July 29, 2026 21:57
f2ae69f to
af285af
Compare
byte-buddy is deliberately held at mockito's version to override the ancient byte-buddy wiremock-jre8 2.35.2 drags in (which breaks mockito with MockitoInitializationException). A Dependabot bump buys nothing and risks re-breaking that; the pin is meant to be removed entirely when wiremock moves to 3.x, not bumped independently. Ignore it until then (covers PR #81). Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_019r7Lis8xMdwczrFLrYNRbj
astubbs
added a commit
that referenced
this pull request
Aug 20, 2026
… dependabot.yml The note argued that deps-deferred-majors.md is full of decisions the bot cannot read, so Dependabot keeps proposing them and a human keeps re-deciding, and that Renovate's packageRules would hold the decision and its reason together. Every part of that is already true of the config we have. .github/dependabot.yml carries scoped ignores with their reasons in comments, lining up with the register's rows - Kafka 4 needing the Java 11 baseline, JUnit 6 needing Java 17 and an ArchUnit engine, Testcontainers 2.x, Vert.x 5. It already batches by risk class through a maven-non-major group. And the duplication the note complained about is deliberate and points the right way: the config says declaring ignores there beats invisible `@dependabot ignore` state, then names the register as the home of the full rationale. A short reason at the rule plus a pointer to the long one is the pattern this repo wants. That landed in #78; the draft mis-cited #76, an unrelated closed bump. So the note now leans against switching, and keeps only the gaps that could still justify it - a release-age delay (whether Dependabot's cooldown already covers it is explicitly UNCHECKED rather than assumed either way), grouping by Maven property rather than artifact pattern, or an actual instance of the ignore list failing. It is kept rather than deleted because the reasoning is the useful part: the next person to have this idea should meet the counter-evidence instead of re-deriving it. The note also records HOW it went wrong - written from upstream's branch names and the register, without opening a config file that was sitting in the repository unread. That is the same failure this branch documents in the mirror bodies: a confident record built from adjacent evidence rather than the thing itself, which then reads as settled. Found by the review sweep on this branch's own later commits, hours after it was written. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01SFRbSkHwaRw6YYFHHBWZ7p
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
The Dependabot config had no grouping at all, so every dependency opened its own PR - a known gap, made concrete when
jackson-databindarrived as a standalone PR (#76) instead of riding along with our curatedversions-maven-plugindependency sweep (#73). This PR closes that gap declaratively.What
maven-non-majorgroup collapses routine minor/patch updates into a single reviewable PR per run instead of a swarm of one-per-dependency PRs. The curated sweep stays the real driver; the grouped PR is just a low-noise "what's newly available" heads-up.ignore:rules for deps we manage by hand or that are deferred majors:jackson-databind, the micrometer family, and the deferred majors (kafka / junit / testcontainers / vertx / mutiny / wiremock). This is strictly better than@dependabot ignorePR comments, whose ignore conditions live invisibly in Dependabot's server-side state with no in-repo explanation for future maintainers.docs/inflight.mdnow records whyjackson-databindis pinned at2.17.2: a module-local,test-scoped pin coupled to WireMock's Jackson (pinning it globally breaksVertxTestwith HTTP 500). Bump it in the next sweep with anexample-metricsintegration-test check.Notes
master).semver-major, so security/patch fixes still flow.#76itself is already handled via the exact@dependabot ignore com.fasterxml.jackson.core:jackson-databindcommand (Dependabot acknowledged); this PR makes that decision declarative and durable.🤖 Generated with Claude Code