Repository navigation
ci: re-pin File Similarity action to merged master (fixes spurious failures) - #79
Merged
Merged
Conversation
…fixes) Bumps the duplicate-code-detection-tool pin from the old feature-branch SHA (4e302e7 on feat/base-vs-pr-comparison) to the merged master commit 74adf74. That branch's base-vs-PR comparison had two bugs that made the File Similarity Check fail on PRs touching no source (the base scan's non-zero exit was misread as "base scan failed", discarding the base data and gating on absolute similarity; and the verdict was never cleared to the delta result). Both are fixed on master, along with a ce-review pass (exception-safe stdout, corrected CI log, corrupt-JSON handling, eval-injection hardening, symmetric-pair dedup) and a unit-test suite. Pinning a merged master commit instead of a feature-branch SHA also removes the fragile dependency on an unmerged branch. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_019r7Lis8xMdwczrFLrYNRbj
Dependency ReviewThe following issues were found:
License Issues.github/workflows/maven.yml
OpenSSF Scorecard
Scanned Files
|
✅ Duplicate Code ReportTwo engines run in parallel for cross-validation. Each has its own thresholds tuned to its baseline - the real safety net is the per-engine "max increase vs base" check. ✅ PMD CPD
No new clones introduced by this PR. ✅ jscpd (language-agnostic)
No new clones introduced by this PR. Powered by astubbs/duplicate-code-cross-check |
✅ SpotBugs ReportNo bugs found (new bugs only — baseline from base branch excluded). |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #79 +/- ##
============================================
+ Coverage 78.03% 78.16% +0.12%
- Complexity 55 1074 +1019
============================================
Files 81 81
Lines 4039 4039
Branches 372 372
============================================
+ Hits 3152 3157 +5
+ Misses 712 707 -5
Partials 175 175
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
The File Similarity Check has been failing on PRs that change no source code (e.g. dependabot PR #78). Root cause was a bug in the custom fork of the similarity tool this workflow pins - its base-vs-PR comparison misread the base scan's exit code as a failure, discarded the base data, and gated the PR on absolute pre-existing similarity.
That fork's fixes (plus a full multi-persona code review) are now merged to its
master. This bumps the pin from the old feature-branch SHA to the merged commit.What
.github/workflows/maven.yml:Upstream fixes now picked up:
eval-injection removed, symmetric-pair dedup, float-boundary roundingAlso swaps a fragile feature-branch-SHA pin for a stable merged-master commit.
Effect
The File Similarity Check should now pass on PRs that introduce no new duplication, while still flagging genuinely new/increased duplication. Verify on this PR's own File Similarity run.
🤖 Generated with Claude Code