revert(ship): restore readiness reviewer over launch task runner - #637
Conversation
#635 reworked /ship into a phased launch task runner (SCOPE → GATE → CLASSIFY → PLAN → EXECUTE → WRAP) backed by curation-rules.md and launch-playbook.md. In practice the task list and per-task confirm loop overweight small changes, the default task set is web/API biased so batch/ETL fixes don't fit cleanly, and PLAN previews force the user to open the playbook to judge each task. Revert ship/ to the readiness-reviewer form at 5003c42 — short Ready / Conditionally ready / Not ready report against four areas (pre-launch, rollout, rollback, monitoring), no task creation, single ship-checklist.md reference. Also drop the references/curation-rules.md and references/launch-playbook.md files and update tests/me/me-specific.bats accordingly.
|
Caution Review failedThe pull request is closed. ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (5)
📝 WalkthroughWalkthroughThe Changes
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~20 minutes Possibly related PRs
Poem
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Summary
plugins/me/skills/ship/to the readiness-reviewer form at5003c42(parent of feat(ship): rework /ship as launch task runner #635), reproducing the pre-rework SKILL.md andreferences/ship-checklist.md.references/curation-rules.mdandreferences/launch-playbook.mdintroduced by feat(ship): rework /ship as launch task runner #635.tests/me/me-specific.batsto expectship-checklist.mdinstead of the removed reference files.Why
#635 reworked
/shipinto a phased launch task runner (SCOPE → GATE → CLASSIFY → PLAN → EXECUTE → WRAP) with TaskCreate/Update loops. After using it on a real one-line OpenSearch fix, the friction was clear:standarddefault task set is web/API biased — "feature flag", "user-facing copy", "staging deploy" don't map cleanly onto batch/ETL jobs (env-separation is the flag, alpha cluster is staging). Adding more lanes per domain doesn't scale.git status.The readiness-reviewer form sidesteps all four: no task creation, no per-class default task lists, no per-task confirm loop. Output is a single Ready / Conditionally ready / Not ready report against four areas, which is what most launches actually need.
If we later want classification or task-tracking back, it should be reintroduced as an explicit add-on, not as the default
/shipshape.Test plan
bats tests/me/me-specific.bats—me: ship skill exists with required filesnow checksship-checklist.md/shipagainst a small change and confirm the output is the four-section readiness report (Decision / Blocking / Warnings / Readiness by area / Next actions), not a TaskCreate flowSummary by CodeRabbit