feat(ship): add shipping readiness skill - #618
Merged
Merged
Conversation
Add the new /ship skill as a launch-readiness gate with supporting checklist and test coverage.
baleen37
enabled auto-merge (squash)
April 15, 2026 09:19
📝 WalkthroughWalkthroughThe PR introduces a new Changes
Poem
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~20 minutes 🚥 Pre-merge checks | ✅ 2 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (2 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
auto-merge was automatically disabled
April 15, 2026 09:19
Repository rule violations found
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
🧹 Nitpick comments (1)
docs/superpowers/plans/2026-04-15-me-ship-skill.md (1)
353-356: Small readability tweak for repeated bullet openings.These three bullets all begin with “If …”. Rewording to parallel “For failures …” phrasing reads cleaner.
✍️ Suggested wording tweak
-- If the failure mentions `has_frontmatter_field` or delimiter checks, edit `plugins/me/skills/ship/SKILL.md` frontmatter only. -- If the failure mentions missing file paths, create or rename only the missing `/ship` files. -- If the failure mentions specific text assertions, update only the exact tested wording in `plugins/me/skills/ship/SKILL.md` or `tests/skills/test_ship_skill_content.bats`. +- For failures mentioning `has_frontmatter_field` or delimiter checks, edit only `plugins/me/skills/ship/SKILL.md` frontmatter. +- For failures mentioning missing file paths, create or rename only the missing `/ship` files. +- For failures mentioning specific text assertions, update only the exact tested wording in `plugins/me/skills/ship/SKILL.md` or `tests/skills/test_ship_skill_content.bats`.🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@docs/superpowers/plans/2026-04-15-me-ship-skill.md` around lines 353 - 356, Update the three bullet points in docs/superpowers/plans/2026-04-15-me-ship-skill.md so their opening phrase is parallel — change the leading "If ..." to "For failures ..." in the bullets that reference edits to plugins/me/skills/ship/SKILL.md, creation/renaming of /ship files, and updates to plugins/me/skills/ship/SKILL.md or tests/skills/test_ship_skill_content.bats; keep the rest of each bullet unchanged.
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In `@plugins/me/skills/ship/SKILL.md`:
- Line 49: In SKILL.md update the inconsistent link path: replace the reference
string "ship/references/ship-checklist.md" with the relative format
"references/ship-checklist.md" so it matches other skills (e.g., qa, jira
daily-standup) and resolves correctly relative to the skill directory.
---
Nitpick comments:
In `@docs/superpowers/plans/2026-04-15-me-ship-skill.md`:
- Around line 353-356: Update the three bullet points in
docs/superpowers/plans/2026-04-15-me-ship-skill.md so their opening phrase is
parallel — change the leading "If ..." to "For failures ..." in the bullets that
reference edits to plugins/me/skills/ship/SKILL.md, creation/renaming of /ship
files, and updates to plugins/me/skills/ship/SKILL.md or
tests/skills/test_ship_skill_content.bats; keep the rest of each bullet
unchanged.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro
Run ID: 42acbeae-cb96-4b85-aff3-7ef5a60f12a1
📒 Files selected for processing (6)
docs/superpowers/plans/2026-04-15-me-ship-skill.mddocs/superpowers/specs/2026-04-15-me-ship-skill-design.mdplugins/me/skills/ship/SKILL.mdplugins/me/skills/ship/references/ship-checklist.mdtests/me/me-specific.batstests/skills/test_ship_skill_content.bats
| 3. **Rollback** — Could the team explain how to recover if the launch goes badly? | ||
| 4. **Monitoring** — Are there logs, metrics, alerts, or explicit watchpoints that would reveal success or failure? | ||
|
|
||
| For concrete examples and decision patterns, read `ship/references/ship-checklist.md`. |
There was a problem hiding this comment.
🧩 Analysis chain
🏁 Script executed:
#!/bin/bash
set -euo pipefail
echo "== Reference links in existing SKILL.md files =="
fd -t f SKILL.md plugins | while read -r file; do
echo "-- $file"
rg -n "references/.*\\.md" "$file" || true
done
echo
echo "== Ship skill reference line(s) =="
rg -n "ship/references/ship-checklist\\.md|references/ship-checklist\\.md" plugins/me/skills/ship/SKILL.md
echo
echo "== Places documenting expected reference style =="
rg -n "references/ship-checklist\\.md|ship/references/ship-checklist\\.md|ship checklist|SKILL\\.md" docs tests pluginsRepository: baleen37/bstack
Length of output: 37037
Use relative path format consistent with other skills.
Line 49 uses ship/references/ship-checklist.md, but all other skills (qa, jira daily-standup, jira generate-status-report, etc.) use the relative format references/filename.md. Change to references/ship-checklist.md to match the established convention and ensure the path resolves correctly relative to the skill directory.
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed.
In `@plugins/me/skills/ship/SKILL.md` at line 49, In SKILL.md update the
inconsistent link path: replace the reference string
"ship/references/ship-checklist.md" with the relative format
"references/ship-checklist.md" so it matches other skills (e.g., qa, jira
daily-standup) and resolves correctly relative to the skill directory.
baleen-release-app Bot
pushed a commit
that referenced
this pull request
Apr 15, 2026
# [16.8.0](v16.7.4...v16.8.0) (2026-04-15) ### Features * **ship:** add shipping readiness skill ([#618](#618)) ([75af5fe](75af5fe))
4 tasks
This was referenced Apr 28, 2026
This was referenced May 12, 2026
This was referenced Aug 1, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
/shipskill for shipping readiness review instead of deploy execution/shipchecklist reference and targeted BATS coverageTest Plan
bash tests/run-all-tests.shSummary by CodeRabbit
/shipskill as a launch-readiness gate for evaluating whether changes are ready to ship. Assesses pre-launch, rollout, rollback, and monitoring readiness. Produces structured output with blocking issues, warnings, per-area readiness assessments, and actionable next steps. Defines three decision states: Ready, Conditionally ready, and Not ready.