feat(me): align lifecycle skills with upstream practices - #651
Merged
Conversation
📝 WalkthroughWalkthroughThis PR introduces a structured implementation plan for upstream alignment of three agentic-worker lifecycle skills (test, review, ship) and applies that plan directly to their skill documentation. The changes strengthen testing evidence requirements, add severity/security escalation rules to review, and expand ship readiness gates with explicit rollback and observability specifications. ChangesLifecycle Skills Upstream Alignment
Estimated code review effort🎯 2 (Simple) | ⏱️ ~12 minutes Possibly related PRs
Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
baleen37
enabled auto-merge (squash)
May 12, 2026 06:53
auto-merge was automatically disabled
May 12, 2026 06:54
Repository rule violations found
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@plugins/me/skills/ship/SKILL.md`:
- Around line 100-104: Update Rule 1 in SKILL.md to state that the three "Phase
A personas" must run in parallel under the Agent harness, and add an explicit
exception clause that if an Agent tooling/harness is unavailable the operator
MAY run persona steps sequentially as a fallback — but only when the operator
documents the deviation, the increased risk, and obtains explicit user consent;
also update any fallback guidance text to reference this exception so there is
no ambiguity between "never sequentially" and the fallback path.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro
Run ID: ffcc99df-76b8-4d0a-8032-5d4efc11db1b
📒 Files selected for processing (4)
docs/superpowers/plans/2026-05-12-lifecycle-skills-upstream-alignment.mdplugins/me/skills/review/SKILL.mdplugins/me/skills/ship/SKILL.mdplugins/me/skills/test/SKILL.md
Comment on lines
100
to
+104
| 1. The three Phase A personas run in parallel — never sequentially. | ||
| 2. Personas do not call each other. The main agent merges in Phase B. | ||
| 3. The rollback plan is mandatory before any GO decision. | ||
| 4. If any persona returns a Critical finding, the default verdict is NO-GO unless the user explicitly accepts the risk. | ||
| 5. **Skip the fan-out only if all of the following are true:** the change touches 2 files or fewer, the diff is under | ||
| 3. The rollback plan is mandatory before any GO decision, including rollback trigger and procedure. | ||
| 4. Default to NO-GO for any Critical security finding, failing required test/build/check/CI status, missing rollback | ||
| plan, or unverifiable production risk. Only override if the user explicitly accepts the risk. |
There was a problem hiding this comment.
Resolve the parallelism rule contradiction.
Line 100 says “never sequentially,” but the fallback guidance allows sequential execution when Agent tooling is unavailable. This creates conflicting operator instructions. Clarify Rule 1 with an explicit exception for non-Agent harnesses so the procedure is unambiguous.
Suggested wording update
-1. The three Phase A personas run in parallel — never sequentially.
+1. In Claude Code (Agent tool available), run all three Phase A personas in parallel in a single assistant turn.
+ If the harness lacks an Agent tool, run persona passes sequentially and treat outputs as parallel inputs for Phase B synthesis.🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
In `@plugins/me/skills/ship/SKILL.md` around lines 100 - 104, Update Rule 1 in
SKILL.md to state that the three "Phase A personas" must run in parallel under
the Agent harness, and add an explicit exception clause that if an Agent
tooling/harness is unavailable the operator MAY run persona steps sequentially
as a fallback — but only when the operator documents the deviation, the
increased risk, and obtains explicit user consent; also update any fallback
guidance text to reference this exception so there is no ambiguity between
"never sequentially" and the fallback path.
baleen-release-app Bot
pushed a commit
that referenced
this pull request
May 12, 2026
# [17.8.0](v17.7.0...v17.8.0) (2026-05-12) ### Features * **me:** align lifecycle skills with upstream practices ([#651](#651)) ([3397d05](3397d05))
This was referenced Aug 1, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
/test,/review, and/shiplifecycle skills with upstream testing, review, and launch-readiness practicesChanges
/test: emphasizes failing repros, observable behavior, focused-first verification, and runtime checks/review: adds severity rules, security escalation, simplification guidance, and findings-only subagent review guidance/ship: strengthens CI/check, rollback, observability, staged rollout, and GO/NO-GO defaultsTests
Summary by CodeRabbit