Repository navigation
Freeze reviewed Game Design sources and protect sealed realm-policy reads - #3055
Draft
benhook1013 wants to merge 18 commits into
Conversation
…it1b-canonical-world-lifecycle
|
Important Review skippedAuto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the ⚙️ Run configuration
You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Contributor
Validation Summary❌ One or more validation checks failed
Coverage reports and failure logs are available in the workflow artifacts. |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Boundary
Game Design source prerequisite stacked on #3041 at
514b91070cbda27bea85c77adb7815dfafc77e18, before preserved World consumer #3044. Published checkpoint1f54e83bf0967c1ef392d4265aeb141354378a2chas 82 unique files. It advances Gameplay #2898's genuine-release prerequisite; broader Unit 1B remains parked and no runtime activation is authorized.GetCompleteLaunchBindingpermits Game Session, World Management and Entity Management;GetPublishedReleaseBundlepermits Game Session, World Management and Automation & Scripting. JWT service/admin claims cannot substitute. Descriptor-only permissions and other RPCs are unchanged.Current proof
Local R2 full Game Design
check -PfullCheck, formatting, Checkstyle, SpotBugs, integration compilation, boot-JAR packaging, links and Markdown pass in 1m23s. 609 unit cases executed, with one object-store skip and zero failures/errors. All 196 integration cases skipped without Docker.All eight new physical loopback-mTLS methods execute cleanly through the production handler, TLS peer interceptor and JWT interceptor. They cover every allowed workload, wrong workload/namespace, missing certificate, bearer-only substitution, malformed/changed evidence, exact forwarding, fresh read correlation and Entity's continued denial from descriptor-only reads. Owner service/repository collaborators are explicit transport doubles: this is not database-to-socket, genuine release, Entity payload or initialization proof.
R1 exposed seven new socket fixture failures before handler dispatch: the source claims codec rejects blank service
accountIdand a non-UUID admin subject. Corrected fixtures omit the service Account claim and use a matching UUID admin subject/claim. Production authentication and all guard assertions remain unchanged. Separate final R3 links/Markdown proof passes in 22s and covers the tracker evidence update.Preserved historical database proof
At predecessor
38fa0717b30b81b245eb970c0f9cba0e732fd406, CI 37623862659 proves 117 owner-component PostgreSQL cases, all 27 named source/bundle/policy/reviewed-base cases exactly once, nine VersionState PostgreSQL/mTLS cases, nine authored-selection cases and seven Account-bound terminal-outcome cases, with no failures/errors/skips in those XML scopes. The separate transaction suite executes five PostgreSQL cases, including both actual publication finalizers. Merge9aab822911a2a92903b2bc2a0bad50834288759bhas exact ordered base/head parents and source-identical tree44b67f8968e17a5fe10f9dcb8e507773d5cf6cd3.That source check reported success but its job later reported cancellation for an unattributed reason; whole-service XML was unavailable. Aggregate failures were separately owned. Those historical results do not establish exact-head database execution for the new guard batch. An earlier Maven download failure was pre-test infrastructure evidence, not a source assertion failure; metadata-only CI supplies no execution credit.
Open obligations and integration gates
AR-1.5 and FireController
current-documentretain current creator/Account authorization, audited retained-baseline intake, source mutation ingress, production coordinator/remote owner delivery, complete genuine release finalization, protected database-to-socket policy delivery/consumption and all four Gameplay owner handoffs. Entity's actual typed definition intake and applied-commit producer remain Gameplay-owned; complete launch binding is evidence, not Entity payload or provisioning authority.Published #3041 → #3055 → #3044 source heads remain preserved. Gameplay owns selective receiving Game Session/Entity integration and forward-schema adaptation. No wholesale donor import, numeric policy fallback, obsolete schema recreation or launch-only admission substitution is authorized. Historical/current source component success does not close receiving composition or activation proof. #3044 remains unchanged at
59eb1d22ac3ec906a64d2db378c79f3353e263d3.No Hosted/CLI review, merge, auto-merge, retarget or queue mutation is requested. Membership RPC, credential paths, Account-ring mount and canonical writer activation remain denied. This is a preserved implementation draft, not a complete producer or merge-ready candidate.