Repository navigation
Account Draft authorization and hosted-terms owner workflow - #3097
Draft
benhook1013 wants to merge 7 commits into
Draft
benhook1013 wants to merge 7 commits into
benhook1013 wants to merge 7 commits into
Conversation
|
Important Review skippedAuto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the ⚙️ Run configuration
You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Contributor
Validation Summary❌ One or more validation checks failed
Coverage reports and failure logs are available in the workflow artifacts. |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Scope and preservation
Account Draft authorization prerequisite for Gameplay: complete immutable required-owner bindings, existing-only creator-party lookup, and Account-owned hosted-terms and environment-binding workflows. Construction checkpoint only—not review intake, merge readiness, production legal publication or runtime activation. Broader Unit 1B remains parked.
Head
f2a2ae4c355b4bd04240b0ed4bce8048c3713cdf; 33 unique files against unchanged #3055 base1f54e83bf0967c1ef392d4265aeb141354378a2c. Selective near-front construction has been preserved locally and normally merged onto #30901a8eefe6824c20b8b07a6d6adadda2ad154476e0; that construction does not yet contain this source's complete bootstrap/party/hosted-terms continuation. This source is not a configured-queue entry. No wholesale donor-history merge or source supersession is claimed.Implemented boundary
HOSTED_TERMSsourceenvironment-boundary/<exact canonical environment boundary>, distinct from catalog scope/version and material generation. Pending changes remain fenced until exact required-owner settlement.Validation and executed proof
At this V95 checkpoint, R23 full Account checks, formatting, schema generation, analyzers, integration compilation, packaging, links and Markdown pass in 2m47s: 1,114 unit and three non-database integration cases executed, zero failures; 526 PostgreSQL cases skipped locally without Docker, including all three new environment-binding cases. Five new binding unit cases executed. Final tracker/documentation R24 passes in 15s; actionlint and diff hygiene pass.
Exact-head CI37740088436 completes the Account job successfully and physically executes five hosted-terms, three environment-binding and 26 Draft authorization PostgreSQL cases, once each, with zero skips/failures/errors. Parent independently parsed every testcase and hashed the two hosted-terms artifact XML files and the exact Draft artifact XML. Runner merge
329e80fdhas the exact base/head parents and a source-identical tree. This proves the isolated V95 workflow and original required-owner storage/migration cases, not a production authenticated publisher or an enabled protected Draft path.This exact-head aggregate is red: TCP Proxy and Game Session fail, Validation Gate fails, and Game Design is cancelled. The Account component proof above is not aggregate success; those independently owned receiving failures remain coordination/reconciliation gates.
At exact preceding head
edf0e879dc63e6ab61bebbdf42ca91a97de9892e, CI37737076003 physically executes all five hosted-terms and all 26 Draft authorization PostgreSQL cases, once each, with zero skips/failures/errors, including retained Flyway checksums. Parent inspected the hosted-terms raw XML and exact Draft raw XML. Runner merge8e0d6b85be28f6589f613a9636a196c5d03c32d4has the exact base/head parents and a source-identical tree. This is prior-head proof, not V95 execution credit.That aggregate CI is red, not green: TCP Proxy cross-service PLAY/identity failures, three Game Session retained-association failures and missing LOGIN proof cause the Validation Gate failure; Game Design is cancelled. These are separate from the clean Account proof and remain coordination/reconciliation gates. Earlier
b432e8afailed all five hosted-terms cases;edf0corrected the timestamp cast and byte-array fixture comparison without weakening assertions.Remaining gates
Production environment publisher custody/channel and current-environment authentication remain unproved. Complete protected Draft actor/current token-registry and evidence-bundle consumption, route-applicable membership/role/party/source capture, all source-writer participation, full required-owner terminal composition and held consumer enforcement through physical commit remain open. Fresh creator bootstrap evidence does not establish a general designer or retained-role authorization path.
No protected Draft producer, canonical write, membership RPC, credential path, key-ring mount, gameplay admission or live legal publication is enabled. No Hosted/CLI review or provider taper credit is requested; implementation helpers and CI observers are not independent review passes. Status owner: Player Access and Session.