shellcheck is pinned in pyproject.toml and wired into no pixi task and no CI job, so it has never run against any script in this repo.
Found during the third wf-review pass on #385, which turned up a latent glob bug in scripts/review_verdict.sh: for login in $REFUSING_LOGINS word-splits and then globs, and every login it holds ends in [bot], a bracket expression matching one of b, o or t. A zero-byte file named sourcery-aib in the working directory flipped a quota refusal into "reviewed by 1 review(s)".
shellcheck would not have caught that specific one, since it accepts word-splitting in a for. That is not the point. A linter that is installed and never executed is the same shape as a reviewer that answers without reviewing, which is what #378 and #385 were both about.
Scripts it would cover today:
scripts/review_verdict.shscripts/public-api-snapshots.shscripts/bench_cold_reset.sh- the
run: blocks in .github/workflows/, via shellcheck -x or a dedicated action
Worth checking whether the existing scripts are already clean before wiring it into gate; if they are not, fix them in the same change rather than landing a job that starts red.
shellcheckis pinned inpyproject.tomland wired into no pixi task and no CI job, so it has never run against any script in this repo.Found during the third
wf-reviewpass on #385, which turned up a latent glob bug inscripts/review_verdict.sh:for login in $REFUSING_LOGINSword-splits and then globs, and every login it holds ends in[bot], a bracket expression matching one ofb,oort. A zero-byte file namedsourcery-aibin the working directory flipped a quota refusal into "reviewed by 1 review(s)".shellcheck would not have caught that specific one, since it accepts word-splitting in a
for. That is not the point. A linter that is installed and never executed is the same shape as a reviewer that answers without reviewing, which is what #378 and #385 were both about.Scripts it would cover today:
scripts/review_verdict.shscripts/public-api-snapshots.shscripts/bench_cold_reset.shrun:blocks in.github/workflows/, viashellcheck -xor a dedicated actionWorth checking whether the existing scripts are already clean before wiring it into
gate; if they are not, fix them in the same change rather than landing a job that starts red.