Skip to content

Reconcile the rewrite decision with the integration that shipped without it - #176

Merged
blooop merged 1 commit into
mainfrom
docs/rust-port-scope
Aug 10, 2026
Merged

blooop merged 1 commit into
mainfrom
docs/rust-port-scope

Conversation

@blooop

@blooop blooop commented Aug 10, 2026

Copy link
Copy Markdown
Owner

Three records currently disagree about how wf should consume devlaunch, and nothing points at the disagreement:

record says
devlaunch#53 GOdevlaunch-core crate + dl bin, linked into wf. Subprocess-on-PATH rejected.
CHANGELOG.md [Unreleased] Rewrite deferred, Python remains, no cutoff to plan around.
blooop/wayfinder#80 Subprocess on PATH. "Rewriting devlaunch in Rust" out of scope — reinforced.

docs/rust-port-scope.md puts them side by side, adds the measurements neither argument had, and narrows the live question to #53's own falsifier.

What is new since #53, and it is evidence rather than opinion: #53's central claim was that the crate wins because a breaking change fails wf's build, where subprocess drift is silent until runtime. That has now happened — wf 0.14.0 prewarms with dl <workspace> up, which no released dl had until 0.0.24 (#175). Neither repo's CI caught it. wf now carries a runtime version floor, which is the strongest thing a subprocess seam can do and strictly weaker than what #53 promised.

Measured, not argued:

  • The 370 MB environment is 275 MB CPython + 118 MB devpod + 84 KiB devlaunch. A Rust port lands at ~120 MB and devpod is 118 MB of it — the floor is devpod, not the language.
  • ~60 MB of it (tk, icu) is conda-forge's python build, not anything dl asks for. Cheapest size win on the list, and not a Rust win.
  • The port is 7,373 lines of source against 18,039 lines of tests, of which the 61 mock-free acceptance tests port and the 376 mock-based ones are read as a spec.

No decision is taken here. The recommendation is to reopen #53 with one question — does wf render per-ticket workspace state? — and to record the answer in both repos, since the two places that went out of sync are wayfinder#80's out-of-scope line and this changelog's deferral paragraph.

🤖 Generated with Claude Code

Summary by Sourcery

Document the current scope, tradeoffs, and open questions around a potential Rust port of devlaunch and its integration with wf.

Documentation:

  • Add a scoping note detailing the conflicting records about the devlaunch Rust rewrite, the existing subprocess-based integration in wf, and the implications of that mismatch.
  • Record measured data on environment size, code and test volume, and performance to ground future decisions about a Rust port.
  • Clarify the actual decision to be made about how wf should consume devlaunch, including when a Rust crate integration would be warranted, and recommend reopening issue Decide: Rust rewrite — go or no-go #53 with a narrower, state-rendering focused question.

…out it

devlaunch#53 decided GO on a Rust rewrite as a devlaunch-core crate that
wayfinder would link, explicitly rejecting subprocess-on-PATH. The changelog
then deferred the rewrite indefinitely, and wayfinder#80 — with no crate to
consume — chose subprocess-on-PATH and recorded "rewriting devlaunch in Rust" as
out of scope, reinforced. Two records answering the same question opposite ways,
neither citing the other.

This note puts them side by side and adds the numbers both arguments were
missing: what the 370 MB environment actually consists of (275 MB of CPython,
118 MB of devpod, 84 KiB of devlaunch), where a Rust port's size win stops
(~120 MB, and devpod is 118 MB of it), and what the port costs (7.4k lines of
source against 18k lines of tests, of which 61 mock-free acceptance tests port).

It also records the one prediction that has since been tested: #53 argued the
crate wins because a breaking change fails wayfinder's build where subprocess
drift is silent until runtime. `dl <workspace> up` shipping in wayfinder before
any released dl carried it is exactly that failure, and it went unnoticed by
both repos' CI.

No decision here. The live question is narrowed to #53's own falsifier — whether
wf renders per-ticket workspace state — because that is what decides between a
typed model and a hand-rolled JSON contract.

@sourcery-ai sourcery-ai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry @blooop, you have reached your weekly rate limit of 500000 diff characters.

Please try again later or upgrade to continue using Sourcery

@sourcery-ai

sourcery-ai Bot commented Aug 10, 2026

Copy link
Copy Markdown

Reviewer's Guide

Adds a new architectural/scoping document that reconciles conflicting decisions about how wf integrates with devlaunch, documents empirical evidence from recent releases, and frames the remaining decision around whether wf needs typed access to per-workspace state versus a subprocess contract.

Sequence diagram for wf prewarm with devlaunch version floor

sequenceDiagram
    participant wf as wf_0_14_0
    participant dl as dl_cli

    wf->>dl: dl --version
    dl-->>wf: 0.0.23 or 0.0.24

    alt [dl_version >= 0.0.24]
        wf->>dl: dl <workspace> up
        dl-->>wf: prewarm complete
    else [dl_version < 0.0.24]
        wf-->>wf: degrade to host launch (record dl below floor)
    end
Loading

File-Level Changes

Change Details Files
Introduce a Rust port scoping document that reconciles prior design records and frames the remaining decision.
  • Describe the three conflicting records (devlaunch#53, CHANGELOG deferral, wayfinder#80 subprocess decision) and how they relate to the current shipped integration.
  • Document the empirical drift incident between wf and dl (the up command) and the resulting introduction of a runtime version floor and conda run dependency.
  • Provide concrete measurements for environment size, code and test footprints, and performance characteristics to clarify the real costs/benefits of a Rust rewrite versus keeping Python.
  • Clarify what is actually being decided (subprocess vs crate seam given workspace state rendering) and recommend reopening devlaunch#53 with a narrower, evidence-based question recorded consistently in both repos.
docs/rust-port-scope.md

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

@codecov

codecov Bot commented Aug 10, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 93.95%. Comparing base (bb7f821) to head (e7795fb).
⚠️ Report is 2 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #176   +/-   ##
=======================================
  Coverage   93.95%   93.95%           
=======================================
  Files          21       21           
  Lines        2565     2565           
=======================================
  Hits         2410     2410           
  Misses        155      155           

Impacted file tree graph

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@blooop
blooop merged commit 839f075 into main Aug 10, 2026
12 checks passed
@blooop
blooop deleted the docs/rust-port-scope branch August 10, 2026 19:36
@blooop blooop mentioned this pull request Aug 10, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant