Repository navigation
feat(users): point users --help to clerk migrate #592
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
manovotny
wants to merge
2
commits into
main
Choose a base branch
from
manovotny/users-help-migrate-hint
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+43
−0
Open
Changes from all commits
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,5 @@ | ||
| --- | ||
| "clerk": patch | ||
| --- | ||
|
|
||
| Point `clerk users --help` to `clerk migrate` for bringing users in from another provider. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Script executed:
git rev-parse --verify fe0ef4701288caa03b6f18ca4a03a5717abefd44^{commit} git diff --unified=30 1b6d214ca02117b7ccc4f392f0208ea4db5119da fe0ef4701288caa03b6f18ca4a03a5717abefd44 -- packages/cli-core/src/commands/users/index.ts packages/cli-core/src/commands/users/README.md packages/cli-core/src/commands/migrate packages/cli-core/src/commands/migrate/index.ts rg -n "registerMigrate|CLERK_EXPERIMENTAL|experiment_disabled|migrate" packages/cli-core/src git log --oneline --all --decorate -- packages/cli-core/src/commands/migrate packages/cli-core/src/commands/users/index.ts | head -40Repository: clerk/cli
Length of output: 41549
Script executed:
Repository: clerk/cli
Length of output: 15242
Remove the migration pointers until the gate is removed.
clerk migrateremains experimental. WithoutCLERK_EXPERIMENTAL=migrate, it exits withexperiment_disabled. Both the users help text and README direct default users to this command, so the documented workflow fails.Suggested fix
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same as the earlier thread: this waits on #531, which drops the gate. Removing the hint would undo the PR.