Repository navigation
ci: upgrade jdx/mise-action to v5 (major) and update actions/upload-artifact to v7.0.2 - #53
Merged
Merged
Conversation
There was a problem hiding this comment.
🟢 Approval recommended
The pinned refs and ratchet constraints are consistent, and the documented breaking changes do not affect these workflows.
0 open findings
What changed in this PR
Updates pinned GitHub Actions dependencies while preserving existing workflow behavior.
Changes:
- Upgrades
jdx/mise-actionfrom v4 to v5.1.1. - Updates
actions/upload-artifactfrom v7.0.1 to v7.0.2.
| File | Description |
|---|---|
.github/workflows/go.yml |
Updates mise setup in test and lint jobs. |
.github/workflows/ratchet.yml |
Updates mise setup for action-reference validation. |
.github/workflows/eif-build.yml |
Updates the artifact upload action patch release. |
🧠 Review effort: Balanced
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
11 tasks done
nickpell
added a commit
that referenced
this pull request
Oct 13, 2026
….0, mise 2026.10.2, and Amazon Linux base (#54) Monthly refresh of Go module dependencies, the Go toolchain, the golangci-lint and mise pins used by CI, and the Amazon Linux 2023 base of the enclave image. Every version taken is at least 7 days old; candidates held by that floor are listed below with the reason. ## Go modules - `github.com/fxamacker/cbor/v2` v2.9.3 -> v2.9.4: fixes potential panics when decoding a CBOR map whose key decodes to an uncomparable Go value, which upstream scopes to apps that register tag types or use interface-containing map key types. This repository does neither, and its direct `cbor` calls are `cbor.Marshal` in tests (`enclave/attestation_test.go`, `validation/testharness_test.go`). - `github.com/mdlayher/socket` v0.6.1 -> v0.7.0 (indirect, via `mdlayher/vsock`): adds `Conn.SendmsgBuffers` and `Conn.SetsockoptBytes`/`GetsockoptBytes`, and honors context cancelation immediately when the context also carries a deadline. Requires Go 1.26+. - `golang.org/x/net` v0.58.0 -> v0.59.0, `golang.org/x/sync` v0.22.0 -> v0.24.0, `golang.org/x/sys` v0.47.0 -> v0.48.0 (all indirect): routine. Only `x/net/bpf`, `x/sync/errgroup` and `x/sys/unix` are compiled into this module. - No direct dependency has a new major version. Held: - `github.com/cloudx-io/openauction` stays at `v0.0.0-20260812214016-a621e06f88df`. A newer pseudo-version, `v0.0.0-20261009213439-5971f473c47e` (2026-10-09), is available. The range is 94 commits across 50 files and includes changes to that module's `validation` package source (`cose.go`, `keyvalidation.go`, `auctionvalidation.go`), which this repository's attestation validation delegates to, so it should land as its own reviewed change. - Younger than 7 days at run time: `cbor/v2` v2.9.6 (2026-10-06; v2.9.5 is retracted), `shopspring/decimal` v1.5.0 (2026-10-05 12:11 UTC; upstream calls out behavior changes), `x/net` v0.60.0/v0.61.0 (2026-10-08/09) and `x/sys` v0.49.0 (2026-10-06). `x/net` v0.60.0 fixes HTTP/2 advisories GO-2026-6603, GO-2026-6610, GO-2026-6611, GO-2026-6612 and GO-2026-6617 in `golang.org/x/net/http2`, which no package in this module compiles, so the security exception to the age floor does not apply. ## Go toolchain 1.27.0 -> 1.27.1 Updated in `.mise/config.toml`, all five platform entries in `.mise/mise.lock` (checksums from `https://go.dev/dl/?mode=json`) and the `actions/setup-go` step in `.github/workflows/docker.yml` that compiles the released enclave binary. The `go 1.27` directive in `go.mod` is unchanged because this is a patch release. Go 1.27.1 ([release notes](https://go.dev/doc/devel/release#go1.27.minor)) contains bug fixes to cgo, the compiler, the runtime, `go fix`, and the `database/sql`, `debug/elf`, `encoding/json`, `net/http`, `os` and `simd` packages, with no security fixes. Held: Go 1.27.2 (released 2026-10-08) is a security release covering the go command, `crypto/tls`, `html/template`, `net/http`, `net/textproto` and `os` (GO-2026-6599, GO-2026-6600, GO-2026-6601, GO-2026-6602, GO-2026-6603, GO-2026-6604, GO-2026-6605, GO-2026-6607, GO-2026-6608, GO-2026-6609, GO-2026-6610, GO-2026-6611, GO-2026-6612, GO-2026-6613, GO-2026-6617). It is younger than the `install_before = "7d"` floor in `.mise/config.toml` (mise resolves 1.27.1 as the latest eligible Go), so it is held for a reviewer decision rather than forced. Reachability on this branch: `govulncheck ./...` reports no vulnerabilities at symbol level; its one package-level finding is GO-2026-6604, which is Windows-only. The enclave server binary imports none of `net/http`, `crypto/tls`, `html/template`, `net/textproto` or `mime/multipart`. Go 1.27.2 clears the floor on 2026-10-15. ## golangci-lint 2.13.2 -> 2.14.0 The Go patch bump does not force this; it is the routine monthly refresh. Checksums come from the release's `golangci-lint-2.14.0-checksums.txt`. Per the [changelog](https://golangci-lint.run/docs/product/changelog/#2140), 2.14.0 bumps bundled linters (including gocritic 0.15.0, gofumpt 0.12.0, gosec 2.29.0 with G407 re-enabled, revive 1.17.0) and fixes fact-cache reloading, with no linter renames or removals. `mise run //:lint` reports 0 issues. The binary is built with go1.27.0, which satisfies the `go 1.27` directive. ## ratchet and ORAS ratchet 0.12.0 and ORAS 1.3.4 (`.github/workflows/eif-build.yml`) are still the newest releases, so neither pin changes. ## mise release 2026.9.12 -> 2026.10.2 The `version:` input on every `jdx/mise-action` step: - `.github/workflows/go.yml:22` (test job) - `.github/workflows/go.yml:35` (lint job) - `.github/workflows/ratchet.yml:22` 2026.10.2 (2026-10-04) is the newest non-prerelease that is at least 7 days old; 2026.10.3 was published 2026-10-05 10:35 UTC. I reviewed the breaking changes listed in 2026.9.13, 2026.9.16 and 2026.10.0: removal of the `pkgx:` backend, locked tools keeping their locked backend, TOML `[tasks]` replacing file tasks, lockfile revision 3 for new lockfiles, SLSA checks on locked entries, removal of `mise bootstrap --from-git`, keyless cosign identity pinning for vfox plugins, the musl asset choice, and exit code 130 on Ctrl-C. None applies here: this repository uses no `pkgx:` tools, defines its tasks as files under `.mise/tasks/`, keeps its existing lockfile revision, and has no SLSA lock entries. A locked `mise install` under 2026.10.2 with empty `MISE_DATA_DIR` and `MISE_CACHE_DIR` installs all three tools with valid checksums. mise now prints a deprecation warning for `install_before` (replaced by `minimum_release_age`, removal planned for 2027.10.0); that setting is left unchanged here. ## Amazon Linux 2023 base image `enclave-image/Dockerfile` moves from `sha256:181f98c48832fe926f8ca3b6ffeafcce128e96e77b93d08fbe9a9bc9403ce284` (2023.12.20260817) to `amazonlinux:2023@sha256:5b29412077a463b4a3a8fbc99a8cdf4b929f38a3ecc8dac10328d8f36b0099b8` (2023.12.20260918, [release notes](https://docs.aws.amazon.com/linux/al2023/release-notes/relnotes-2023.12.20260918.html)). It is a multi-architecture OCI index containing `linux/amd64` and `linux/arm64/v8`, with images created 2026-09-28. The `amazonlinux:2023` tag currently resolves to `sha256:8ed3c0a996841537f75607e7d1de2114d8150391f75792e8da9268738547e73f`, created 2026-10-05 18:28 UTC, which was under 7 days old at run time. The newest index older than that was identified from the public [docker-library/repo-info](https://github.com/docker-library/repo-info) history and verified with `docker buildx imagetools inspect`. Package changes in the base: `openssl-libs` and `openssl-fips-provider-latest` 3.5.7 -> 3.5.8, `curl-minimal`/`libcurl-minimal` 8.17.0 -> 8.21.0, `expat` 2.6.3 -> 2.8.3, `python3-pip-wheel`, `system-release` and `amazon-linux-repo-cdn`. Amazon Linux 2023 locks `dnf` to the image's release version, and `dnf update -y` in the Dockerfile reported nothing to do during the local arm64 build. This pin therefore determines the package versions in the enclave image. ## Risk assessment Low overall. The Go change is a patch release with bug fixes only, and the full test suite passes with the race detector. The module bumps are minor or patch, and the cbor fix addresses a code path this repository does not exercise. golangci-lint and mise affect CI tooling only. The base image moves distro packages by patch or minor versions; the enclave server is a statically linked Go binary (`CGO_ENABLED=0`) and does not link OpenSSL, curl or expat. The main open item is the held Go 1.27.2 security release, whose fixes do not reach code compiled here per govulncheck. ## Enclave measurements This change reaches the enclave image (Go rebuild and base image), so PCR0 and PCR2 change, as they do for any enclave source change. After merge, the `update-pcrs` job in `.github/workflows/eif-build.yml` appends the new set to `validation/pcrs.json`, which is append-only, so previously built enclaves keep validating. EIFs are built unsigned, so PCR8 is not a factor. pkg.go.dev lists no known importers of `github.com/cloudx-io/openarbiter/validation`. On merge, the existing Docker Build and Build EIF workflows build and publish the enclave image and EIF for the merge commit. This is artifact publication only. ## Pre-merge checklist - [x] `go build ./...` and `go test -race -count=1 ./...` pass under go1.27.1 - [x] `mise run //:test`, `//:lint` (0 issues), `//:ratchet:lint` pass; `//:ratchet:pin` leaves no diff; `go mod tidy` is idempotent - [x] Enclave binary cross-compiled with the `docker.yml` build command: statically linked ELF aarch64, stamped go1.27.1 (PR CI does not build it) - [x] `docker buildx build --platform linux/arm64` of `enclave-image/Dockerfile` with that binary succeeds; all aarch64 `dnf` packages resolve and the image reports Amazon Linux 2023.12.20260918 - [x] Locked `mise install` from empty data and cache directories under mise 2026.10.2 reports every tool valid - [x] Lockfile checksums taken from go.dev and the golangci-lint release checksums file; the outgoing blocks regenerate byte for byte - [x] `govulncheck ./...` reports no symbol-level findings - [x] CI checks (test, lint, Ratchet Lint) pass — all three pass on `4347584`. Every Go pin site on `main` (`docker.yml` `go-version`, `.mise/mise.lock`) is moved by this PR. Test-merged with #53 onto `main`: clean. - [ ] Reviewer decision on Go 1.27.2 (security release held by the 7-day floor) — still open: Nick's call. For comparison, packer-aws-ami#127 took Go 1.27.2 under the security exception because govulncheck found its advisories reachable there. ## Post-merge verification - [ ] Docker Build succeeds for the merge commit, with `setup-go` reporting Go 1.27.1 - [ ] Build EIF succeeds and `update-pcrs` appends one new PCR set to `validation/pcrs.json`, leaving existing sets intact <div><a href="https://cursor.com/agents/bc-c8cf09c7-a1b6-4335-8770-af23790bb2c5?cursor_ref=pr_footer&cursor_cta=open_in_web"><picture><source media="(prefers-color-scheme: dark)" srcset="https://cursor.com/assets/images/open-in-web-dark.png"><source media="(prefers-color-scheme: light)" srcset="https://cursor.com/assets/images/open-in-web-light.png"><img alt="Open in Web" width="114" height="28" src="https://cursor.com/assets/images/open-in-web-dark.png"></picture></a> <a href="https://cursor.com/automations/bbbb3f6b-965d-11f1-ba66-0e7d0216e441"><picture><source media="(prefers-color-scheme: dark)" srcset="https://cursor.com/assets/images/view-automation-dark.png"><source media="(prefers-color-scheme: light)" srcset="https://cursor.com/assets/images/view-automation-light.png"><img alt="View Automation" width="141" height="28" src="https://cursor.com/assets/images/view-automation-dark.png"></picture></a> </div> --------- Co-authored-by: Cursor Agent <cursoragent@cursor.com> Co-authored-by: Nick Pellegrino <nick@cloudx.io>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Refreshes pinned GitHub Actions refs with ratchet. This PR contains one in-major update produced by
mise run //:ratchet:updateand one intentional major upgrade ofjdx/mise-actionfrom v4 to v5, produced bymise run //:ratchet:upgrade .github/workflows/go.yml .github/workflows/ratchet.yml. The major upgrade rewrites the# ratchet:constraint comment from@v4to@v5. No other workflow content changed.Refs that moved
actions/upload-artifact.github/workflows/eif-build.yml@v7(unchanged)043fb46d1a93c77aae656e7c1c64a875d1fc6a0a→cf430e030ddbb5b0abf93d22962f4752f3646cd9jdx/mise-action.github/workflows/go.yml(2 jobs),.github/workflows/ratchet.yml@v4→@v5(major)c2a87611a18de5b3828c5652fe268e992400cb5c→2d8d4cafcbd33be2ea37d2b6f5ad595363d1f1caAll other pinned actions (
actions/checkout,actions/setup-go,actions/create-github-app-token,aws-actions/configure-aws-credentials,aws-actions/amazon-ecr-login,docker/metadata-action,docker/setup-qemu-action,docker/setup-buildx-action,docker/build-push-action) already match their newest upstream release, and none has a newer major available. No major is held back.Upstream changelog
actions/upload-artifactv7.0.2: bumps@actions/artifactto v6.3.1, which improves retries when the artifact service returns HTTP 429, including honoring a validRetry-Afterheader.action.ymlandsrc/are unchanged between v7.0.1 and v7.0.2; only the bundleddist/and dependency metadata changed. Runtime staysnode24.jdx/mise-actionv5.0.0 (breaking):minimum_release_agenow defaults to24hwhenversionis unset; release selection uses the publicmise.jdx.devrelease index;mise self-updateis authenticated withMISE_GITHUB_TOKEN.jdx/mise-actionv5.0.1: security fix. An already-installed or cache-restoredmisebinary is verified against the signed release checksums before it is run; switching versions now does a full install instead ofmise self-update.jdx/mise-actionv5.1.0: adds aversionsoutput and per-tool outputs, and the opt-inplugins,cache_save_postandauto_updateinputs. Also fixes cache saving after a partial-match restore.jdx/mise-actionv5.1.1 (breaking): thegithub_tokeninput is no longer exported to later steps asMISE_GITHUB_TOKENunless the newpersist_github_tokeninput is set.There is no v4 release after v4.3.0, so the v5.0.1 binary-verification fix and the v5.1.1 token-scoping fix are only available on v5.
Risk assessment
actions/upload-artifactv7.0.2: low. It is used once, in theUpload artifactsstep ofeif-build.yml. The new behavior only applies when an artifact service call fails. The retry base interval goes from 3 s to 8 s, a positive-integerRetry-Afterheader is honored on HTTP 429, and the total retry wait is capped at 120 s. A successful upload behaves as before, apart from an orchestration-ID tag added to the client user agent. The download filename parsing change in the same library does not apply to an upload. Inputs and outputs are unchanged.jdx/mise-actionv5: low for these workflows. I checked both breaking changes against the three call sites:minimum_release_agedefault: not reached. Every call site passesversion: "2026.9.12". In v5.1.1setupMise()only uses the release age whenversionis empty, and with an explicit version it logs thatminimum_release_ageis ignored. Themise.jdx.dev/releases.tsvindex is fetched only on that unpinned path, so the same mise version is installed as today.MISE_GITHUB_TOKENno longer persisted: reached, with no effect here. The action still uses the token for its ownmise install, which installs every tool in.mise/mise.lock(go, golangci-lint, ratchet). The later steps aremise run //:test,//:lint,//:tidy,//:ratchet:lintand//:ratchet:pin. They rungo test,golangci-lint run,go mod tidyandratchet lint/ratchet pinagainst tools that are already installed. Nothing in this repository readsMISE_GITHUB_TOKEN, and ratchet does not use that variable. This also narrows the credential exposure for later steps, in line with the existingpersist-credentials: falseonactions/checkout.post:step (post-if: always()): it does nothing for these workflows.post()saves the cache only whencache_save_postwas enabled, and it defaults tofalse.node24on both v4.3.0 and v5.1.1.SHASUMS256.txtfrom the public mise release before it runs. If the check fails, the action reinstalls instead of running an unverified binary.CI coverage:
jdx/mise-actionv5 is exercised by this PR's own checks, becausetestandlint(Go workflow) andRatchet Lint(Ratchet workflow) all install mise through it. Theactions/upload-artifactpin is validated but not exercised here, becauseeif-build.ymlonly runs onmain.Ratchet Lintconfirms it is pinned and that ratchet has nothing further to move. It first executes on the next EIF build after merge.Pre-merge checklist
mise run //:ratchet:updateproduced only theactions/upload-artifactbump.mise run //:ratchet:upgrade .github/workflows/go.yml .github/workflows/ratchet.ymlproduced only thejdx/mise-actionv4 → v5 change.mise run //:ratchet:lintpasses.mise run //:ratchet:pinand a secondmise run //:ratchet:updateleave no further diff.uses:ref lines (4 lines across 3 files); no unrelated workflow edits.Ratchet Lint,test,lint. — all three pass oneff3acc; SHA↔tag checked:jdx/mise-action@2d8d4ca= v5.1.1,actions/upload-artifact@cf430e0= v7.0.2.Post-deploy/apply verification
mainreferencejdx/mise-action@2d8d4cafcbd33be2ea37d2b6f5ad595363d1f1ca # ratchet:jdx/mise-action@v5andactions/upload-artifact@cf430e030ddbb5b0abf93d22962f4752f3646cd9 # ratchet:actions/upload-artifact@v7. — confirmed onmainat8a9bfee.GoandRatchetruns onmainafter merge pass with mise-action v5. — Go run 38418849725 and Ratchet run 38418849586 on8a9bfeeboth succeeded.EIF Buildrun onmaincompletes itsUpload artifactsstep with upload-artifact v7.0.2. — Build EIF run 38419333269 (for8a9bfee) succeeded:Upload artifactsgreen, PCR set appended as1e6378e(+7 lines).