Repository navigation
Monthly Go update: dependencies, toolchain 1.27.1, golangci-lint 2.14.0, mise 2026.10.2, and Amazon Linux base - #54
Merged
Conversation
- github.com/fxamacker/cbor/v2 v2.9.3 -> v2.9.4 - github.com/mdlayher/socket v0.6.1 -> v0.7.0 (indirect) - golang.org/x/net v0.58.0 -> v0.59.0 (indirect) - golang.org/x/sync v0.22.0 -> v0.24.0 (indirect) - golang.org/x/sys v0.47.0 -> v0.48.0 (indirect) github.com/cloudx-io/openauction is held at its current pseudo-version.
Go 1.27.1 is pinned in .mise/config.toml, every platform entry in .mise/mise.lock (checksums from go.dev/dl), and the actions/setup-go step in docker.yml that compiles the enclave binary. The go.mod directive stays at go 1.27 because this is a patch release. golangci-lint 2.14.0 checksums come from the release's checksums file.
Moves the version input on every jdx/mise-action step to the same release.
Pins amazonlinux:2023 to the multi-architecture OCI index sha256:5b29412077a463b4a3a8fbc99a8cdf4b929f38a3ecc8dac10328d8f36b0099b8 (images created 2026-09-28), which includes linux/arm64/v8. Package changes from 2023.12.20260817: openssl-libs and openssl-fips-provider-latest 3.5.7 -> 3.5.8, curl-minimal and libcurl-minimal 8.17.0 -> 8.21.0, expat 2.6.3 -> 2.8.3, python3-pip-wheel, system-release and amazon-linux-repo-cdn.
There was a problem hiding this comment.
🟢 Approval recommended
The version pins are internally consistent, and no unresolved correctness issues were found.
0 open findings
What changed in this PR
Refreshes Go dependencies, build tooling, CI pins, and the enclave’s Amazon Linux base image.
Changes:
- Updates Go modules and the Go 1.27.1 toolchain.
- Upgrades golangci-lint and mise CI versions.
- Refreshes the pinned Amazon Linux 2023 image.
| File | Description |
|---|---|
go.mod |
Updates Go module versions. |
go.sum |
Refreshes dependency checksums. |
.mise/config.toml |
Updates Go and golangci-lint pins. |
.mise/mise.lock |
Updates tool versions, URLs, and checksums. |
.github/workflows/go.yml |
Updates mise in test and lint jobs. |
.github/workflows/ratchet.yml |
Updates mise for Ratchet checks. |
.github/workflows/docker.yml |
Builds the enclave with Go 1.27.1. |
enclave-image/Dockerfile |
Updates the pinned Amazon Linux image. |
🧠 Review effort: Balanced
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
6 tasks done
nickpell
added a commit
that referenced
this pull request
Oct 26, 2026
## Summary - Docker Build installs Go with `actions/setup-go` from `go-version-file: go.mod` instead of a `go-version: "1.27.3"` literal, so no workflow names a Go version. The `docker-build` PR check in `go.yml` uses the same step, in place of mise, so the published image's install step runs on every PR. - `go.mod` gains `toolchain go1.27.3`, which setup-go reads ahead of the `go` line. The `go` directive stays `1.27`: it is the minimum for every module that imports this one, and the `toolchain` line of a dependency is ignored, so importers are not held to the patch release. - `.mise/config.toml`'s `go` pin is still the version tests and lint run on. A new `check-go-version` task, run in the `lint` job, fails when `go.mod`'s toolchain line or `.mise/mise.lock` disagrees with it. A Go bump is: edit the pin, `MISE_LOCKED=0 mise lock go`, `go mod edit -toolchain=go<version>`. - The Go version does not change: 1.27.3 before and after. - cloudx-io/openauction#115 makes the same change in openauction. ## Notes for reviewers - #4 moved `go.yml` to mise and left `docker.yml` on setup-go with pin-only changes; no reason to keep that split is recorded. Since then each Go bump has edited `docker.yml`'s `go-version` by hand next to the mise pin (#23, #54, #66). - Docker Build runs only from `workflow_run` on `main`, and `workflow_run` uses the definition on `main`, so this PR cannot run the changed `docker.yml`. The `docker-build` job runs the identical setup-go step followed by the same `go build`. ## Pre-merge checklist - [x] `mise run //:check-go-version` passes, and fails naming the file when `go.mod` says `toolchain go1.27.2` or the pin says 1.27.4 with the lock and `go.mod` left at 1.27.3 - [x] `mise run //:lint`, `//:test`, `//:tidy` (keeps the `toolchain` line) and `//:ratchet:lint` pass locally on Go 1.27.3, as does `//:test` apart from `TestGetSystemInfo_LiveProcfs`, which reads Linux `/proc` and fails on macOS; actionlint reports nothing - [x] PR CI green on e0eee86 (test, lint, docker-build, Ratchet Lint); `docker-build`'s setup-go step logs `Setup go version spec 1.27.3` and `go version go1.27.3`, and `lint` runs `check-go-version` - [x] Diff contains no unintended changes: `docker.yml`, `go.yml`, `go.mod` and the new task ## Post-merge verification - [ ] On the merge commit the main pipeline is green: Go, then Docker Build, then Build EIF, then the `[skip-build] Update PCR measurements` commit - [ ] Docker Build's setup-go step logs `Setup go version spec 1.27.3` 🤖 Generated with [Claude Code](https://claude.com/claude-code) --------- Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Monthly refresh of Go module dependencies, the Go toolchain, the golangci-lint and mise pins used by CI, and the Amazon Linux 2023 base of the enclave image. Every version taken is at least 7 days old; candidates held by that floor are listed below with the reason.
Go modules
github.com/fxamacker/cbor/v2v2.9.3 -> v2.9.4: fixes potential panics when decoding a CBOR map whose key decodes to an uncomparable Go value, which upstream scopes to apps that register tag types or use interface-containing map key types. This repository does neither, and its directcborcalls arecbor.Marshalin tests (enclave/attestation_test.go,validation/testharness_test.go).hub.lumenfield.work/mdlayher/socketv0.6.1 -> v0.7.0 (indirect, viamdlayher/vsock): addsConn.SendmsgBuffersandConn.SetsockoptBytes/GetsockoptBytes, and honors context cancelation immediately when the context also carries a deadline. Requires Go 1.26+.golang.org/x/netv0.58.0 -> v0.59.0,golang.org/x/syncv0.22.0 -> v0.24.0,golang.org/x/sysv0.47.0 -> v0.48.0 (all indirect): routine. Onlyx/net/bpf,x/sync/errgroupandx/sys/unixare compiled into this module.Held:
github.com/cloudx-io/openauctionstays atv0.0.0-20260812214016-a621e06f88df. A newer pseudo-version,v0.0.0-20261009213439-5971f473c47e(2026-10-09), is available. The range is 94 commits across 50 files and includes changes to that module'svalidationpackage source (cose.go,keyvalidation.go,auctionvalidation.go), which this repository's attestation validation delegates to, so it should land as its own reviewed change.cbor/v2v2.9.6 (2026-10-06; v2.9.5 is retracted),shopspring/decimalv1.5.0 (2026-10-05 12:11 UTC; upstream calls out behavior changes),x/netv0.60.0/v0.61.0 (2026-10-08/09) andx/sysv0.49.0 (2026-10-06).x/netv0.60.0 fixes HTTP/2 advisories GO-2026-6603, GO-2026-6610, GO-2026-6611, GO-2026-6612 and GO-2026-6617 ingolang.org/x/net/http2, which no package in this module compiles, so the security exception to the age floor does not apply.Go toolchain 1.27.0 -> 1.27.1
Updated in
.mise/config.toml, all five platform entries in.mise/mise.lock(checksums fromhttps://go.dev/dl/?mode=json) and theactions/setup-gostep in.github/workflows/docker.ymlthat compiles the released enclave binary. Thego 1.27directive ingo.modis unchanged because this is a patch release. Go 1.27.1 (release notes) contains bug fixes to cgo, the compiler, the runtime,go fix, and thedatabase/sql,debug/elf,encoding/json,net/http,osandsimdpackages, with no security fixes.Held: Go 1.27.2 (released 2026-10-08) is a security release covering the go command,
crypto/tls,html/template,net/http,net/textprotoandos(GO-2026-6599, GO-2026-6600, GO-2026-6601, GO-2026-6602, GO-2026-6603, GO-2026-6604, GO-2026-6605, GO-2026-6607, GO-2026-6608, GO-2026-6609, GO-2026-6610, GO-2026-6611, GO-2026-6612, GO-2026-6613, GO-2026-6617). It is younger than theinstall_before = "7d"floor in.mise/config.toml(mise resolves 1.27.1 as the latest eligible Go), so it is held for a reviewer decision rather than forced. Reachability on this branch:govulncheck ./...reports no vulnerabilities at symbol level; its one package-level finding is GO-2026-6604, which is Windows-only. The enclave server binary imports none ofnet/http,crypto/tls,html/template,net/textprotoormime/multipart. Go 1.27.2 clears the floor on 2026-10-15.golangci-lint 2.13.2 -> 2.14.0
The Go patch bump does not force this; it is the routine monthly refresh. Checksums come from the release's
golangci-lint-2.14.0-checksums.txt. Per the changelog, 2.14.0 bumps bundled linters (including gocritic 0.15.0, gofumpt 0.12.0, gosec 2.29.0 with G407 re-enabled, revive 1.17.0) and fixes fact-cache reloading, with no linter renames or removals.mise run //:lintreports 0 issues. The binary is built with go1.27.0, which satisfies thego 1.27directive.ratchet and ORAS
ratchet 0.12.0 and ORAS 1.3.4 (
.github/workflows/eif-build.yml) are still the newest releases, so neither pin changes.mise release 2026.9.12 -> 2026.10.2
The
version:input on everyjdx/mise-actionstep:.github/workflows/go.yml:22(test job).github/workflows/go.yml:35(lint job).github/workflows/ratchet.yml:222026.10.2 (2026-10-04) is the newest non-prerelease that is at least 7 days old; 2026.10.3 was published 2026-10-05 10:35 UTC. I reviewed the breaking changes listed in 2026.9.13, 2026.9.16 and 2026.10.0: removal of the
pkgx:backend, locked tools keeping their locked backend, TOML[tasks]replacing file tasks, lockfile revision 3 for new lockfiles, SLSA checks on locked entries, removal ofmise bootstrap --from-git, keyless cosign identity pinning for vfox plugins, the musl asset choice, and exit code 130 on Ctrl-C. None applies here: this repository uses nopkgx:tools, defines its tasks as files under.mise/tasks/, keeps its existing lockfile revision, and has no SLSA lock entries. A lockedmise installunder 2026.10.2 with emptyMISE_DATA_DIRandMISE_CACHE_DIRinstalls all three tools with valid checksums. mise now prints a deprecation warning forinstall_before(replaced byminimum_release_age, removal planned for 2027.10.0); that setting is left unchanged here.Amazon Linux 2023 base image
enclave-image/Dockerfilemoves fromsha256:181f98c48832fe926f8ca3b6ffeafcce128e96e77b93d08fbe9a9bc9403ce284(2023.12.20260817) toamazonlinux:2023@sha256:5b29412077a463b4a3a8fbc99a8cdf4b929f38a3ecc8dac10328d8f36b0099b8(2023.12.20260918, release notes). It is a multi-architecture OCI index containinglinux/amd64andlinux/arm64/v8, with images created 2026-09-28. Theamazonlinux:2023tag currently resolves tosha256:8ed3c0a996841537f75607e7d1de2114d8150391f75792e8da9268738547e73f, created 2026-10-05 18:28 UTC, which was under 7 days old at run time. The newest index older than that was identified from the public docker-library/repo-info history and verified withdocker buildx imagetools inspect.Package changes in the base:
openssl-libsandopenssl-fips-provider-latest3.5.7 -> 3.5.8,curl-minimal/libcurl-minimal8.17.0 -> 8.21.0,expat2.6.3 -> 2.8.3,python3-pip-wheel,system-releaseandamazon-linux-repo-cdn. Amazon Linux 2023 locksdnfto the image's release version, anddnf update -yin the Dockerfile reported nothing to do during the local arm64 build. This pin therefore determines the package versions in the enclave image.Risk assessment
Low overall. The Go change is a patch release with bug fixes only, and the full test suite passes with the race detector. The module bumps are minor or patch, and the cbor fix addresses a code path this repository does not exercise. golangci-lint and mise affect CI tooling only. The base image moves distro packages by patch or minor versions; the enclave server is a statically linked Go binary (
CGO_ENABLED=0) and does not link OpenSSL, curl or expat. The main open item is the held Go 1.27.2 security release, whose fixes do not reach code compiled here per govulncheck.Enclave measurements
This change reaches the enclave image (Go rebuild and base image), so PCR0 and PCR2 change, as they do for any enclave source change. After merge, the
update-pcrsjob in.github/workflows/eif-build.ymlappends the new set tovalidation/pcrs.json, which is append-only, so previously built enclaves keep validating. EIFs are built unsigned, so PCR8 is not a factor. pkg.go.dev lists no known importers ofhub.lumenfield.work/cloudx-io/openarbiter/validation.On merge, the existing Docker Build and Build EIF workflows build and publish the enclave image and EIF for the merge commit. This is artifact publication only.
Pre-merge checklist
go build ./...andgo test -race -count=1 ./...pass under go1.27.1mise run //:test,//:lint(0 issues),//:ratchet:lintpass;//:ratchet:pinleaves no diff;go mod tidyis idempotentdocker.ymlbuild command: statically linked ELF aarch64, stamped go1.27.1 (PR CI does not build it)docker buildx build --platform linux/arm64ofenclave-image/Dockerfilewith that binary succeeds; all aarch64dnfpackages resolve and the image reports Amazon Linux 2023.12.20260918mise installfrom empty data and cache directories under mise 2026.10.2 reports every tool validgovulncheck ./...reports no symbol-level findings4347584. Every Go pin site onmain(docker.ymlgo-version,.mise/mise.lock) is moved by this PR. Test-merged with ci: upgrade jdx/mise-action to v5 (major) and update actions/upload-artifact to v7.0.2 #53 ontomain: clean.Post-merge verification
setup-goreporting Go 1.27.1 — Docker Build run 38419906526 at54a3c1asucceeded (Successfully set up Go version 1.27.1) and pushedenclave-image:54a3c1a.update-pcrsappends one new PCR set tovalidation/pcrs.json, leaving existing sets intact — no automatic Build EIF measured this code: the concurrency group replaced the queued run, and the tip run skipped on[skip-build]. Nick dispatched Build EIF onmain(run 38421527242), which measuredenclave-image:1e6378e(same enclave source as54a3c1a), pushed the EIF, and appended one PCR set asdfeb84b(+7 lines, existing sets intact).