Skip to content

Remove nmap-ncat from the enclave image - #62

Merged
nickpell merged 1 commit into
mainfrom
nick/openarbiter-drop-nmap-ncat
Oct 26, 2026
Merged

nickpell merged 1 commit into
mainfrom
nick/openarbiter-drop-nmap-ncat

Conversation

@nickpell

@nickpell nickpell commented Oct 26, 2026 •

Copy link
Copy Markdown
Member

Summary

Notes for reviewers

Pre-merge checklist

  • PR CI docker-build job builds the enclave image from this branch (run 40373204431, green on 304a95a)
  • Go workflow green: lint and test (run 40373204431); Ratchet Lint green
  • Image built locally for linux/arm64 from this branch: command -v nc ncat finds nothing, rpm -q nmap-ncat reports not installed, ca-certificates and /etc/pki/tls/certs/ca-bundle.crt are present
  • No remaining nc/ncat/nmap/netcat use in this repo (git grep -i -w on origin/main matches only the removed package name)
  • Diff contains no unintended changes

Post-deploy/apply verification

  • The main pipeline on the merge commit is green: Go, then Docker Build, then Build EIF (b2b61d4: Go, Docker Build, Build EIF and Ratchet all success; PCR commit 3e2eb0b)
  • update-pcrs pushes the [skip-build] Update PCR measurements commit for the merge commit, recording the new PCRs in validation/pcrs.json (b2b61d4: Go, Docker Build, Build EIF and Ratchet all success; PCR commit 3e2eb0b)

Its only user, the TCP HEALTHCHECK, was removed in #55, which left the package removal for a separate change. The enclave server is a static binary that runs no external commands.

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢 Approval recommended

The removal has no remaining package consumers, preserves certificate installation, and uses existing automation for updated PCR measurements.

No open issues 🎉

What changed in this PR

Removes the unused nmap-ncat package from the enclave image, completing the cleanup deferred by #55 after removal of the TCP health check.

Changes:

  • Keeps ca-certificates installed while removing nmap-ncat.
  • Changes the image root filesystem; existing main-build automation will record the resulting PCR measurements.
File Description
enclave-image/​Dockerfile Removes nmap-ncat from package installation.

Review effort: Balanced

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢 Approval recommended

The removal has no remaining package consumers, preserves certificate installation, and uses the existing pipeline for expected PCR updates.

No open issues 🎉

Review effort: Balanced

@nickpell
nickpell merged commit b2b61d4 into main Oct 26, 2026
6 checks passed
@nickpell
nickpell deleted the nick/openarbiter-drop-nmap-ncat branch October 26, 2026 21:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants