Repository navigation
Remove nmap-ncat from the enclave image - #62
Merged
Merged
Conversation
Its only user, the TCP HEALTHCHECK, was removed in #55, which left the package removal for a separate change. The enclave server is a static binary that runs no external commands.
There was a problem hiding this comment.
🟢 Approval recommended
The removal has no remaining package consumers, preserves certificate installation, and uses existing automation for updated PCR measurements.
No open issues 🎉
What changed in this PR
Removes the unused nmap-ncat package from the enclave image, completing the cleanup deferred by #55 after removal of the TCP health check.
Changes:
- Keeps
ca-certificatesinstalled while removingnmap-ncat. - Changes the image root filesystem; existing main-build automation will record the resulting PCR measurements.
| File | Description |
|---|---|
enclave-image/Dockerfile |
Removes nmap-ncat from package installation. |
Review effort: Balanced
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
enclave-image/Dockerfile: installs onlyca-certificates, droppingnmap-ncat. Its only user was the TCPHEALTHCHECKthat Drop the TCP health check from the enclave image and fix the decryptCPMDollars doc #55 removed. The enclave server is a static binary that runs no external commands (noos/execin the module), and nothing in the repo callsnc,ncatornmap.update-pcrsjob records the new values invalidation/pcrs.jsonon the merge commit, as on every main build.Notes for reviewers
nmap-ncatinstalled on purpose: "removing a package changes the rootfs and is left for a separate change". That kept Drop the TCP health check from the enclave image and fix the decryptCPMDollars doc #55 free of rootfs changes; it was not a reason to keep the package. This PR is that separate change, and the rootfs and PCR change is expected.Pre-merge checklist
docker-buildjob builds the enclave image from this branch (run 40373204431, green on 304a95a)linux/arm64from this branch:command -v nc ncatfinds nothing,rpm -q nmap-ncatreports not installed,ca-certificatesand/etc/pki/tls/certs/ca-bundle.crtare presentnc/ncat/nmap/netcatuse in this repo (git grep -i -wonorigin/mainmatches only the removed package name)Post-deploy/apply verification
update-pcrspushes the[skip-build] Update PCR measurementscommit for the merge commit, recording the new PCRs invalidation/pcrs.json(b2b61d4: Go, Docker Build, Build EIF and Ratchet all success; PCR commit 3e2eb0b)