Repository navigation
enclave: drop nmap-ncat from the image - #112
Merged
Merged
Conversation
The TCP HEALTHCHECK that used nc was removed in #103; nothing else in the image runs nc, so the package is no longer needed.
7 tasks done
There was a problem hiding this comment.
🟢 Approval recommended
The change removes an unused package, with no remaining consumers identified and existing workflows covering image builds and PCR updates.
No open issues 🎉
What changed in this PR
Removes the unused nmap-ncat package from the enclave image, completing the cleanup after #103 removed its only consumer, the TCP health check.
Changes:
- Installs only
ca-certificatesin the enclave image. - Changes image contents; the existing post-merge workflow will record updated EIF PCR measurements.
| File | Description |
|---|---|
| enclave/Dockerfile | Removes nmap-ncat from the installed packages. |
Review effort: Balanced
nickpell
added a commit
to cloudx-io/openarbiter
that referenced
this pull request
Oct 26, 2026
## Summary - `enclave-image/Dockerfile`: installs only `ca-certificates`, dropping `nmap-ncat`. Its only user was the TCP `HEALTHCHECK` that #55 removed. The enclave server is a static binary that runs no external commands (no `os/exec` in the module), and nothing in the repo calls `nc`, `ncat` or `nmap`. - The image rootfs changes, so the EIF and its PCRs change. The `update-pcrs` job records the new values in `validation/pcrs.json` on the merge commit, as on every main build. - cloudx-io/openauction#112 makes the same change to the auction enclave image. The two PRs are independent. ## Notes for reviewers - #55 kept `nmap-ncat` installed on purpose: "removing a package changes the rootfs and is left for a separate change". That kept #55 free of rootfs changes; it was not a reason to keep the package. This PR is that separate change, and the rootfs and PCR change is expected. ## Pre-merge checklist - [x] PR CI `docker-build` job builds the enclave image from this branch (run 40373204431, green on 304a95a) - [x] Go workflow green: lint and test (run 40373204431); Ratchet Lint green - [x] Image built locally for `linux/arm64` from this branch: `command -v nc ncat` finds nothing, `rpm -q nmap-ncat` reports not installed, `ca-certificates` and `/etc/pki/tls/certs/ca-bundle.crt` are present - [x] No remaining `nc`/`ncat`/`nmap`/`netcat` use in this repo (`git grep -i -w` on `origin/main` matches only the removed package name) - [x] Diff contains no unintended changes ## Post-deploy/apply verification - [ ] The main pipeline on the merge commit is green: Go, then Docker Build, then Build EIF - [ ] `update-pcrs` pushes the `[skip-build] Update PCR measurements` commit for the merge commit, recording the new PCRs in `validation/pcrs.json`
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
nmap-ncatfrom the enclave image (enclave/Dockerfile), which now installs onlyca-certificates. The package's only user was the TCPHEALTHCHECK, which enclave: log rejected auctions as errors, tighten the zero-floor test, fix doc comments, drop the TCP healthcheck #103 removed while leaving the package installed. Nothing else in the image or its build and deploy tooling runsnc,ncatornmapinside the enclave image.update-pcrsrecords the new values after merge.Pre-merge checklist
docker-buildgreen on 8b10168; a local arm64 build of the image has nonc,ncatornmapand keepsca-certificates)enclave/Dockerfile)Post-deploy/apply verification
[skip-build] Update PCR measurementscommit for the merge commit lands onmain(c00eab2: Go 40400845673, Docker Build 40400939883, Build EIF 40401393821 all success; PCR commit 37c080e)