Skip to content

enclave: drop nmap-ncat from the image - #112

Merged
nickpell merged 1 commit into
mainfrom
nick/openauction-drop-nmap-ncat
Oct 26, 2026
Merged

nickpell merged 1 commit into
mainfrom
nick/openauction-drop-nmap-ncat

Conversation

@nickpell

@nickpell nickpell commented Oct 26, 2026 •

Copy link
Copy Markdown
Member

Summary

Pre-merge checklist

  • Build passes (PR CI docker-build green on 8b10168; a local arm64 build of the image has no nc, ncat or nmap and keeps ca-certificates)
  • Diff contains no unintended changes (one line in enclave/Dockerfile)

Post-deploy/apply verification

  • The main pipeline on the merge commit is green: Go, then Docker Build, then Build EIF, then the [skip-build] Update PCR measurements commit for the merge commit lands on main (c00eab2: Go 40400845673, Docker Build 40400939883, Build EIF 40401393821 all success; PCR commit 37c080e)

The TCP HEALTHCHECK that used nc was removed in #103; nothing else in
the image runs nc, so the package is no longer needed.

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢 Approval recommended

The change removes an unused package, with no remaining consumers identified and existing workflows covering image builds and PCR updates.

No open issues 🎉

What changed in this PR

Removes the unused nmap-ncat package from the enclave image, completing the cleanup after #103 removed its only consumer, the TCP health check.

Changes:

  • Installs only ca-certificates in the enclave image.
  • Changes image contents; the existing post-merge workflow will record updated EIF PCR measurements.
File Description
enclave/​Dockerfile Removes nmap-ncat from the installed packages.

Review effort: Balanced

@nickpell
nickpell merged commit c00eab2 into main Oct 26, 2026
5 checks passed
@nickpell
nickpell deleted the nick/openauction-drop-nmap-ncat branch October 26, 2026 21:01
nickpell added a commit to cloudx-io/openarbiter that referenced this pull request Oct 26, 2026
## Summary

- `enclave-image/Dockerfile`: installs only `ca-certificates`, dropping
`nmap-ncat`. Its only user was the TCP `HEALTHCHECK` that #55 removed.
The enclave server is a static binary that runs no external commands (no
`os/exec` in the module), and nothing in the repo calls `nc`, `ncat` or
`nmap`.
- The image rootfs changes, so the EIF and its PCRs change. The
`update-pcrs` job records the new values in `validation/pcrs.json` on
the merge commit, as on every main build.
- cloudx-io/openauction#112 makes the same change to the auction enclave
image. The two PRs are independent.

## Notes for reviewers

- #55 kept `nmap-ncat` installed on purpose: "removing a package changes
the rootfs and is left for a separate change". That kept #55 free of
rootfs changes; it was not a reason to keep the package. This PR is that
separate change, and the rootfs and PCR change is expected.

## Pre-merge checklist

- [x] PR CI `docker-build` job builds the enclave image from this branch
(run 40373204431, green on 304a95a)
- [x] Go workflow green: lint and test (run 40373204431); Ratchet Lint
green
- [x] Image built locally for `linux/arm64` from this branch: `command
-v nc ncat` finds nothing, `rpm -q nmap-ncat` reports not installed,
`ca-certificates` and `/etc/pki/tls/certs/ca-bundle.crt` are present
- [x] No remaining `nc`/`ncat`/`nmap`/`netcat` use in this repo (`git
grep -i -w` on `origin/main` matches only the removed package name)
- [x] Diff contains no unintended changes

## Post-deploy/apply verification

- [ ] The main pipeline on the merge commit is green: Go, then Docker
Build, then Build EIF
- [ ] `update-pcrs` pushes the `[skip-build] Update PCR measurements`
commit for the merge commit, recording the new PCRs in
`validation/pcrs.json`
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants