Repository navigation
ci: bump upload-artifact to v7.0.2 and upgrade mise-action to the v5 major via ratchet - #101
Merged
Merged
Conversation
Refresh the SHA pin for actions/upload-artifact within its existing v7 ratchet constraint (v7.0.1 -> v7.0.2). The release updates the bundled @actions/artifact library to 6.3.1, which improves retry handling for artifact service requests. action.yml is unchanged.
Run ratchet upgrade on go.yml and ratchet.yml to move jdx/mise-action from the v4 constraint (v4.3.0) to v5 (v5.1.1). The v5 breaking changes do not reach these workflows: - minimum_release_age now defaults to 24h, but every call site sets an explicit mise version, which takes precedence over the delay. - MISE_GITHUB_TOKEN is no longer exported to later steps by default. The later steps only run mise tasks against tools the action step already installed from mise.lock, and ratchet reads GITHUB_TOKEN or ACTIONS_TOKEN rather than MISE_GITHUB_TOKEN. v5 also verifies a cached mise binary before running it and keeps the token scoped to the action step.
nickpell
marked this pull request as ready for review
October 13, 2026 13:11
nickpell
requested
a balanced review from Copilot
and removed request for
nickpell
October 13, 2026 13:11
There was a problem hiding this comment.
🟢 Approval recommended
The scoped action updates remain SHA-pinned and are compatible with the workflows’ existing inputs and usage.
0 open findings
What changed in this PR
Updates SHA-pinned GitHub Actions while preserving ratchet constraints.
Changes:
- Upgrades
jdx/mise-actionfrom v4 to v5. - Updates
actions/upload-artifactfrom v7.0.1 to v7.0.2.
| File | Description |
|---|---|
.github/workflows/ratchet.yml |
Upgrades mise-action for ratchet checks. |
.github/workflows/go.yml |
Upgrades mise-action for test and lint jobs. |
.github/workflows/eif-build.yml |
Updates the artifact upload action pin. |
🧠 Review effort: Balanced
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
4 tasks done
nickpell
added a commit
that referenced
this pull request
Oct 13, 2026
… mise 2026.10.2, and Amazon Linux 2023 base image (#102) Monthly refresh of Go module dependencies, the Go toolchain, the tool pins that travel with it, the mise release CI installs, and the pinned Amazon Linux 2023 enclave base image. Every version below was published at least 7 days ago, except where a newer release is noted as held. ## Changes ### Go module dependencies (`go.mod`, `go.sum`) - `github.com/fxamacker/cbor/v2` v2.9.3 -> v2.9.4: fixes potential panics when decoding a CBOR map whose key decodes to an uncomparable Go value; affects only registered tag types or map keys that are named empty interfaces ([release notes](https://github.com/fxamacker/cbor/releases/tag/v2.9.4)). - `github.com/mdlayher/socket` v0.6.1 -> v0.7.0 (indirect, via `mdlayher/vsock`): context cancelation is now honored immediately for blocking operations whose context also carries a deadline; adds `SendmsgBuffers` and `Set/GetsockoptBytes`; requires Go 1.26+ ([changelog](https://github.com/mdlayher/socket/blob/main/CHANGELOG.md#v070)). - `golang.org/x/net` v0.58.0 -> v0.59.0, `golang.org/x/sync` v0.22.0 -> v0.24.0, `golang.org/x/sys` v0.47.0 -> v0.48.0 (all indirect): routine updates. `x/sync` adds a panic on negative semaphore capacity; `x/sys` adds constants and platform support. - No direct dependency has a newer major version available, so no major is held back. ### Go toolchain 1.27.0 -> 1.27.1 - Pin sites updated together: `.mise/config.toml`, the `go` entries in `.mise/mise.lock` (all five platforms, checksums from https://go.dev/dl/?mode=json), and `actions/setup-go` `go-version` in `.github/workflows/docker.yml`, which builds the enclave binary for the published image. The `go 1.27` directive in `go.mod` is unchanged. - Go 1.27.1 contains bug fixes to cgo, the compiler, the runtime, `go fix`, and the `database/sql`, `debug/elf`, `encoding/json`, `net/http`, `os` and `simd` packages ([release history](https://go.dev/doc/devel/release#go1.27.minor)). ### golangci-lint 2.13.2 -> 2.14.0 - `.mise/config.toml` and the five `.mise/mise.lock` platform entries (checksums from the release's `golangci-lint-2.14.0-checksums.txt`). Built with go1.27.0, so it supports this module's language version. - Linter version bumps only (including `exhaustive` 0.13.0 and `gosec` 2.29.0 re-enabling G407); no linter renames ([changelog](https://golangci-lint.run/docs/product/changelog/)). `golangci-lint run` reports 0 issues with no config changes. ### mise release pinned in CI: 2026.9.12 -> 2026.10.2 - `.github/workflows/go.yml:22` - `.github/workflows/go.yml:35` - `.github/workflows/ratchet.yml:22` I read the release notes from 2026.9.13 through 2026.10.2. The breaking changes (removal of the experimental `pkgx:` backend, locked tools keeping their locked backend, `lockfile_version = 3` for new lockfiles only, SLSA signer checks, keyless cosign identity for vfox plugins) do not affect the `core:go`, `aqua:golangci/golangci-lint` and `go:` tools this repository uses. A locked `mise install` under 2026.10.2, with empty data and cache directories, validated all three tools. The `uses:` SHA lines are unchanged. ### Amazon Linux 2023 base image (`enclave/Dockerfile`) - `amazonlinux:2023@sha256:181f98c4…` (2023.12.20260817) -> `amazonlinux:2023@sha256:5b29412077a463b4a3a8fbc99a8cdf4b929f38a3ecc8dac10328d8f36b0099b8` (2023.12.20260918). Resolved with `docker buildx imagetools inspect`; the index contains linux/amd64 and linux/arm64. The `2023` tag stays on the FROM line. - Package differences in the base image: `curl-minimal`/`libcurl-minimal` 8.17.0 -> 8.21.0, `expat` 2.6.3 -> 2.8.3, `openssl-libs`/`openssl-fips-provider-latest` 3.5.7 -> 3.5.8, `python3-pip-wheel` rebuild, plus release metadata. The Dockerfile still runs `dnf update -y` at build time. See the [2023.12.20260831](https://docs.aws.amazon.com/linux/al2023/release-notes/relnotes-2023.12.20260831.html) and [2023.12.20260918](https://docs.aws.amazon.com/linux/al2023/release-notes/relnotes-2023.12.20260918.html) release notes. ### Already current - ratchet 0.12.0 and ORAS 1.3.4 (`.github/workflows/eif-build.yml`) are the latest releases, so they are unchanged. ## Held by the 7-day release-age floor - Go 1.27.2 (released 2026-10-08): mise's configured release-age floor rejects it (`mise latest go` resolves to 1.27.1), so it is held rather than forced. It includes security fixes: GO-2026-6599, GO-2026-6600 (`html/template`), GO-2026-6603, GO-2026-6605, GO-2026-6609, GO-2026-6610, GO-2026-6611, GO-2026-6612, GO-2026-6613, GO-2026-6617 (`net/http`), GO-2026-6607 (`crypto/tls` ECH), GO-2026-6608 (`net/textproto`), GO-2026-6604 (`os`, Windows only). `govulncheck` reports none of these as reachable from this module's code, which does not run an HTTP or TLS server. Next month's update will pick it up. - `golang.org/x/net` v0.60.0/v0.61.0 (2026-10-08/09): v0.60.0 fixes HTTP/2 advisories GO-2026-6603, GO-2026-6610, GO-2026-6611, GO-2026-6612 and GO-2026-6617 in `x/net/http2`. The only `x/net` package in the build graph is `x/net/bpf` (via `mdlayher/socket`), so these do not apply. - `golang.org/x/sys` v0.49.0 (2026-10-06), `github.com/fxamacker/cbor/v2` v2.9.6 (2026-10-06; v2.9.5 is retracted), and `github.com/shopspring/decimal` v1.5.0 (2026-10-05, includes documented behavior changes): no security advisories; held for age. - mise 2026.10.3 and newer: fewer than 7 days old. - `amazonlinux:2023` 2023.12.20260930 (pushed 2026-10-05T19:30Z): fewer than 7 days old. Its container package changes are release metadata only. ## Risk assessment Low. All Go changes are patch or minor releases with no API changes affecting this code, and no source changes were needed. The enclave runtime change most worth noting is `mdlayher/socket`'s context-cancelation fix on the vsock path: blocking socket operations now return on cancelation instead of waiting for the deadline. That is the intended behavior, and the enclave tests pass. The golangci-lint bump is limited to linter versions and reports no new findings. The base image moves forward by one monthly AL2023 release with library updates (curl, expat, openssl) that `dnf update -y` would already apply at build time. For mise, `.mise/mise.lock` stays at its current revision, and the locked install verifies every tool. ## Verification - `go build ./...`, `go vet ./...`, `go test ./...` and `go test -race ./...` pass on Go 1.27.1. - `mise run //:test`, `//:lint` (0 issues), `//:tidy`, `//:ratchet:lint` and `//:ratchet:pin` (no diff) pass under mise 2026.10.2. - All ten `.mise/mise.lock` checksums were compared against the upstream checksum sources and verified by downloading each artifact. - `govulncheck ./...` reports no reachable vulnerabilities before or after the update. - The enclave binary cross-compiles for linux/arm64 and linux/amd64 with the `docker.yml` build command (statically linked; size change about +1 KB on each architecture). - `docker buildx build` of `enclave/Dockerfile` on the new base succeeds for linux/arm64 and linux/amd64 using those binaries, including the `dnf` layers. ## Enclave measurements The Go rebuild and the base image change alter the enclave image, so PCR0 and PCR2 of the next EIF will differ. PCR1 depends on the EIF builder kernel, which this PR does not change. After merge, the `update-pcrs` job in `.github/workflows/eif-build.yml` appends the new set to `validation/pcrs.json`. The file is append-only and `ValidatePCRs` accepts a match against any recorded set, so previously built enclaves keep validating. `validation/pcr.go` is the only reader of that file in this repository. PCR8 does not apply because EIFs here are built unsigned. ## Pre-merge checklist - [x] Go and Ratchet CI workflows pass on this PR. — `test`, `lint`, `Ratchet Lint` pass on `b980872`. Every Go pin site on `main` (`docker.yml` `go-version`, `.mise/mise.lock`) is moved by this PR. Test-merged with #101 onto `main`: clean. - [ ] Reviewer agrees with holding Go 1.27.2 under the mise release-age floor (its advisories are not reachable from this code). — still open: Nick's call. For comparison, packer-aws-ami#127 took Go 1.27.2 under the security exception because govulncheck found its advisories reachable there. ## Post-merge verification - [ ] The Docker Build workflow on `main` builds the arm64 enclave image with Go 1.27.1 and the new base digest. This is artifact publication. - [ ] The Build EIF workflow succeeds, and its `update-pcrs` job appends a new PCR0/PCR1/PCR2 entry to `validation/pcrs.json`. <div><a href="https://cursor.com/agents/bc-627b5633-4c3b-45fc-a636-81bd9b5f8435?cursor_ref=pr_footer&cursor_cta=open_in_web"><picture><source media="(prefers-color-scheme: dark)" srcset="https://cursor.com/assets/images/open-in-web-dark.png"><source media="(prefers-color-scheme: light)" srcset="https://cursor.com/assets/images/open-in-web-light.png"><img alt="Open in Web" width="114" height="28" src="https://cursor.com/assets/images/open-in-web-dark.png"></picture></a> <a href="https://cursor.com/automations/bbbdd0c6-965d-11f1-ba66-0e7d0216e441"><picture><source media="(prefers-color-scheme: dark)" srcset="https://cursor.com/assets/images/view-automation-dark.png"><source media="(prefers-color-scheme: light)" srcset="https://cursor.com/assets/images/view-automation-light.png"><img alt="View Automation" width="141" height="28" src="https://cursor.com/assets/images/view-automation-dark.png"></picture></a> </div> --------- Co-authored-by: Cursor Agent <cursoragent@cursor.com> Co-authored-by: Nick Pellegrino <nick@cloudx.io>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR refreshes the SHA-pinned GitHub Actions with ratchet in two commits:
ratchet update:actions/upload-artifactmoves to v7.0.2 inside its existing@v7constraint.ratchet upgrade, scoped togo.ymlandratchet.yml, movesjdx/mise-actionfrom@v4to@v5. This rewrites the# ratchet:constraint comment. The upgrade is intentional: the v5 release notes document two breaking changes, and the risk section below shows that neither reaches these workflows.The other nine pinned actions are already at their newest release, so no major is held back. All 19
uses:call sites remain SHA-pinned.Refs that moved
actions/upload-artifact.github/workflows/eif-build.yml@v7(unchanged)043fb46d1a93c77aae656e7c1c64a875d1fc6a0a→cf430e030ddbb5b0abf93d22962f4752f3646cd9jdx/mise-action.github/workflows/go.yml(2 call sites),.github/workflows/ratchet.yml@v4→@v5c2a87611a18de5b3828c5652fe268e992400cb5c→2d8d4cafcbd33be2ea37d2b6f5ad595363d1f1caUpstream changelog
actions/upload-artifact:Retry-Afterheaders, and updates@actions/artifactto 6.3.1. Not labelled breaking.action.ymlis byte-identical between v7.0.1 and v7.0.2.jdx/mise-action:minimum_release_agenow defaults to24hwhenversionis unset, and the release list comes from the publicmise.jdx.devrelease index instead of the GitHub Releases API.mise self-updatenow usesMISE_GITHUB_TOKEN.misebinary against signed release checksums before running it. Changing versions now does a full install instead ofmise self-update.versionsoutput plusplugins,cache_save_postandauto_updateinputs, all opt-in. A cached mise is kept whenversionis unset. Also includes cache-save fixes.MISE_GITHUB_TOKENis no longer exported to later steps by default. The newpersist_github_tokeninput (defaultfalse) restores the old behavior.Risk assessment
jdx/mise-actionv5: low risk, with full PR CI coverage. All three call sites are ingo.yml(test,lint) andratchet.yml(Ratchet Lint), and both workflows run onpull_request, so this PR's own checks exercise the new major directly.minimum_release_agedefault does not apply. Every call site passesversion: "2026.9.12", and the release notes state that an explicitversiontakes precedence and skips the delay.MISE_GITHUB_TOKENchange does not affect these workflows. The later steps only runmise run //:test,//:lint,//:tidy,//:ratchet:lintand//:ratchet:pin. Those tasks use tools that the action step already installed from.mise/mise.lock, and the action step still uses the token.ratchetreadsACTIONS_TOKENorGITHUB_TOKEN, notMISE_GITHUB_TOKEN. Pinning already-pinned refs needs no API access. No workflow in this repo referencesMISE_GITHUB_TOKEN. The change also narrows the token's exposure to later steps.auto_update,plugins,cache_save_post,persist_github_token) is optional, and its default matches v4 behavior for these call sites. The runtime staysnode24. The newpost:step returns immediately unlesscache_save_postis enabled.actions/upload-artifactv7.0.2: low risk, not covered by PR CI. It is used only by the "Upload artifacts" step ineif-build.yml, which runs after "Docker Build" onmain(or by manual dispatch) and not on pull requests. The step uses onlyname,pathandretention-days, and none of those inputs changed. The reachable behavior change is in the bundled artifact service client. Its base retry interval rises from 3s to 8s. HTTP 429 responses now honor a positive-integerRetry-Afterheader. Total retry wait is capped at 120s. With the default 5 attempts, worst-case exponential backoff grows from roughly 35s to roughly 94s, still under the cap. This only affects runs where the artifact service is already returning retryable errors, and it makes them more resilient. TheContent-Dispositionfilename parsing change in the same library applies only to downloads, which this workflow does not use.Pre-merge checklist
mise run //:ratchet:updateapplied only theactions/upload-artifactref; a second run after the upgrade produces no diffmise run //:ratchet:upgrade .github/workflows/go.yml .github/workflows/ratchet.ymlchanged only the threejdx/mise-actionrefs and kept the floating@v5constraint formmise run //:ratchet:lintpasses; all 19uses:call sites are pinned to a full SHA with a# ratchet:constraintmise run //:ratchet:pinis idempotent (no further diff)uses:lines and their# ratchet:commentstest,lint,Ratchet Lint— all three pass on7218f86; SHA↔tag checked:jdx/mise-action@2d8d4ca= v5.1.1,actions/upload-artifact@cf430e0= v7.0.2.Post-deploy/apply verification
mainuse the new pins (upload-artifact@cf430e0…,mise-action@2d8d4ca…) — onmainatab0141e:eif-build.yml:460upload-artifact@cf430e0 (v7), andgo.yml:20,go.yml:33,ratchet.yml:20mise-action@2d8d4ca (v5).GoandRatchetruns onmainafter merge pass with mise-action v5 — Go run 38416718605 and Ratchet run 38416718512 onab0141eboth succeeded. Every job (test,lint,Ratchet Lint) hasInstall miseand the new v5Post Install misestep green.maincompletes its "Upload artifacts" step with upload-artifact v7.0.2, since PR CI does not exercise that workflow — Build EIF run 38417378883 (workflow_run forab0141e) succeeded. Its "Upload artifacts" step ranactions/upload-artifact@cf430e0and logged "Finished uploading artifact content to blob storage!", and the PCR set was appended asad327cd.