Repository navigation
Monthly update: Go 1.27.1, module dependencies, golangci-lint 2.14.0, mise 2026.10.2, and Amazon Linux 2023 base image - #102
Merged
nickpell merged 6 commits intoOct 13, 2026
Conversation
- github.com/fxamacker/cbor/v2 v2.9.3 -> v2.9.4 - github.com/mdlayher/socket v0.6.1 -> v0.7.0 - golang.org/x/net v0.58.0 -> v0.59.0 - golang.org/x/sync v0.22.0 -> v0.24.0 - golang.org/x/sys v0.47.0 -> v0.48.0
Bump the Go version in .mise/config.toml, the go entries in .mise/mise.lock (checksums from go.dev/dl), and the setup-go version used by the Docker Build workflow. The go.mod directive stays at go 1.27.
Pin amazonlinux:2023 to the multi-architecture index digest sha256:5b29412077a463b4a3a8fbc99a8cdf4b929f38a3ecc8dac10328d8f36b0099b8 (linux/amd64 and linux/arm64).
There was a problem hiding this comment.
🟢 Approval recommended
Version pins are consistent across configuration, lockfiles, and CI, with no unresolved correctness issues found.
0 open findings
What changed in this PR
Refreshes Go dependencies, development tooling, CI pins, and the enclave base image.
Changes:
- Updates Go modules and Go to 1.27.1.
- Updates golangci-lint and mise CI pins.
- Refreshes the Amazon Linux 2023 image digest.
| File | Description |
|---|---|
go.mod |
Updates module versions. |
go.sum |
Updates dependency checksums. |
.mise/config.toml |
Updates Go and golangci-lint pins. |
.mise/mise.lock |
Locks updated tool artifacts and checksums. |
.github/workflows/go.yml |
Updates mise used by Go CI. |
.github/workflows/ratchet.yml |
Updates mise used by Ratchet CI. |
.github/workflows/docker.yml |
Builds the enclave with Go 1.27.1. |
enclave/Dockerfile |
Updates the Amazon Linux base digest. |
🧠 Review effort: Balanced
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
nickpell
deleted the
cursor/go-dependencies-and-build-environment-ca2f
branch
October 13, 2026 14:53
nickpell
added a commit
that referenced
this pull request
Oct 13, 2026
…, fix doc comments, drop the TCP healthcheck (#103) ## Summary - **Auction failure logging (`enclave/server.go`):** the server logged `INFO: Auction processed successfully with TEE attestation data` after every `ProcessAuction` call, including the two cases where `ProcessAuction` returns `Success: false` without logging anything (a negative `bid_floor`, an invalid deal list). The success line is now logged only when the response succeeded; otherwise the server logs `ERROR: Auction failed: <message>`. The response sent to the host is unchanged. - **`TestProcessAuction_BidFloorZero`:** the test claimed "all bids pass (no floor enforcement)" but checked only the attested bid hash count, which includes floor-rejected bids, so it could not fail if a zero floor rejected a bid. It now also asserts `response.FloorRejected` is empty. - **Doc comments (`core/types.go`):** `AuctionResult.RunnerUp` is nil when fewer than two bidders have an eligible bid, because ranking keeps only each bidder's highest bid (two eligible bids from one bidder still give no runner-up); the comment said "less than 2 valid bids". The `ExcludedBid` comment listed floor rejections, which are reported in `FloorRejected` instead; it now lists the exclusion reasons the enclave uses. - **Enclave image (`enclave/Dockerfile`):** removes `EXPOSE 5000` and the `HEALTHCHECK` that pinged `127.0.0.1:5000` with `nc`. The server listens only on vsock, so the probe could never pass, and the image is used only as `nitro-cli build-enclave` input, where Docker health checks never run. `nmap-ncat` stays installed. The image config changes, so the EIF PCRs may change (the server change alters the binary in any case); `update-pcrs` records the new values after merge. ## Notes for reviewers - The `ExcludedBid` comment dates from #4, which moved floor rejections out of `ExcludedBid` into a separate list in the same change; the comment kept the old wording. - Open #44, #46 and #102 touch `enclave/auction_test.go`, `core/types.go` and `enclave/Dockerfile` on other lines. A trial merge of each with this branch produces no conflicts beyond those each already has with `main`. ## Pre-merge checklist - [x] Build passes (`go build ./...`, `go vet ./...`; Docker Build green on this branch; a local build of the image shows `Healthcheck` and `ExposedPorts` null with `nc` still present) - [x] Lint passes (`golangci-lint run`: 0 issues) - [x] Tests pass (`go test -count=1 ./...`; with a zero floor made to reject a bid, the new `FloorRejected` assertion fails while the existing bid hash count check still passes) - [x] Diff contains no unintended changes ## Post-deploy/apply verification - [ ] The next EIF build on `main` after merge is green - [ ] `update-pcrs` commits the new PCR measurements for the merge commit
6 tasks done
nickpell
added a commit
that referenced
this pull request
Oct 26, 2026
## Summary - Docker Build installs Go with `actions/setup-go` from `go-version-file: go.mod` instead of a `go-version: "1.27.3"` literal, so no workflow names a Go version. The `docker-build` PR check in `go.yml` uses the same step, in place of mise, so the published image's install step runs on every PR. - `go.mod` gains `toolchain go1.27.3`, which setup-go reads ahead of the `go` line. The `go` directive stays `1.27`: it is the minimum for every module that imports this one, and the `toolchain` line of a dependency is ignored, so importers are not held to the patch release. - `.mise/config.toml`'s `go` pin is still the version tests and lint run on. A new `check-go-version` task, run in the `lint` job, fails when `go.mod`'s toolchain line or `.mise/mise.lock` disagrees with it. A Go bump is: edit the pin, `MISE_LOCKED=0 mise lock go`, `go mod edit -toolchain=go<version>`. - The Go version does not change: 1.27.3 before and after. - cloudx-io/openarbiter#64 makes the same change in openarbiter. ## Notes for reviewers - #39 moved `go.yml` to mise and left `docker.yml` on setup-go with pin-only changes; no reason to keep that split is recorded. Since then each Go bump has edited `docker.yml`'s `go-version` by hand next to the mise pin (#64, #102, #117). - Docker Build runs only from `workflow_run` on `main` or a manual dispatch, and `workflow_run` uses the definition on `main`, so this PR cannot run the changed `docker.yml`. The `docker-build` job runs the identical setup-go step followed by the same `go build`. ## Pre-merge checklist - [x] `mise run //:check-go-version` passes, and fails naming the file when `go.mod` says `toolchain go1.27.2` or the pin says 1.27.4 with the lock and `go.mod` left at 1.27.3 - [x] `mise run //:lint`, `//:test`, `//:tidy` (keeps the `toolchain` line) and `//:ratchet:lint` pass locally on Go 1.27.3; actionlint reports nothing - [x] PR CI green on c6a1a24 (test, lint, docker-build, Ratchet Lint); `docker-build`'s setup-go step logs `Setup go version spec 1.27.3` and `go version go1.27.3`, and `lint` runs `check-go-version` - [x] Diff contains no unintended changes: `docker.yml`, `go.yml`, `go.mod` and the new task ## Post-merge verification - [ ] On the merge commit the main pipeline is green: Go, then Docker Build, then Build EIF, then the `[skip-build] Update PCR measurements` commit - [ ] Docker Build's setup-go step logs `Setup go version spec 1.27.3` 🤖 Generated with [Claude Code](https://claude.com/claude-code) --------- Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Monthly refresh of Go module dependencies, the Go toolchain, the tool pins that travel with it, the mise release CI installs, and the pinned Amazon Linux 2023 enclave base image. Every version below was published at least 7 days ago, except where a newer release is noted as held.
Changes
Go module dependencies (
go.mod,go.sum)github.com/fxamacker/cbor/v2v2.9.3 -> v2.9.4: fixes potential panics when decoding a CBOR map whose key decodes to an uncomparable Go value; affects only registered tag types or map keys that are named empty interfaces (release notes).hub.lumenfield.work/mdlayher/socketv0.6.1 -> v0.7.0 (indirect, viamdlayher/vsock): context cancelation is now honored immediately for blocking operations whose context also carries a deadline; addsSendmsgBuffersandSet/GetsockoptBytes; requires Go 1.26+ (changelog).golang.org/x/netv0.58.0 -> v0.59.0,golang.org/x/syncv0.22.0 -> v0.24.0,golang.org/x/sysv0.47.0 -> v0.48.0 (all indirect): routine updates.x/syncadds a panic on negative semaphore capacity;x/sysadds constants and platform support.Go toolchain 1.27.0 -> 1.27.1
.mise/config.toml, thegoentries in.mise/mise.lock(all five platforms, checksums from https://go.dev/dl/?mode=json), andactions/setup-gogo-versionin.github/workflows/docker.yml, which builds the enclave binary for the published image. Thego 1.27directive ingo.modis unchanged.go fix, and thedatabase/sql,debug/elf,encoding/json,net/http,osandsimdpackages (release history).golangci-lint 2.13.2 -> 2.14.0
.mise/config.tomland the five.mise/mise.lockplatform entries (checksums from the release'sgolangci-lint-2.14.0-checksums.txt). Built with go1.27.0, so it supports this module's language version.exhaustive0.13.0 andgosec2.29.0 re-enabling G407); no linter renames (changelog).golangci-lint runreports 0 issues with no config changes.mise release pinned in CI: 2026.9.12 -> 2026.10.2
.github/workflows/go.yml:22.github/workflows/go.yml:35.github/workflows/ratchet.yml:22I read the release notes from 2026.9.13 through 2026.10.2. The breaking changes (removal of the experimental
pkgx:backend, locked tools keeping their locked backend,lockfile_version = 3for new lockfiles only, SLSA signer checks, keyless cosign identity for vfox plugins) do not affect thecore:go,aqua:golangci/golangci-lintandgo:tools this repository uses. A lockedmise installunder 2026.10.2, with empty data and cache directories, validated all three tools. Theuses:SHA lines are unchanged.Amazon Linux 2023 base image (
enclave/Dockerfile)amazonlinux:2023@sha256:181f98c4…(2023.12.20260817) ->amazonlinux:2023@sha256:5b29412077a463b4a3a8fbc99a8cdf4b929f38a3ecc8dac10328d8f36b0099b8(2023.12.20260918). Resolved withdocker buildx imagetools inspect; the index contains linux/amd64 and linux/arm64. The2023tag stays on the FROM line.curl-minimal/libcurl-minimal8.17.0 -> 8.21.0,expat2.6.3 -> 2.8.3,openssl-libs/openssl-fips-provider-latest3.5.7 -> 3.5.8,python3-pip-wheelrebuild, plus release metadata. The Dockerfile still runsdnf update -yat build time. See the 2023.12.20260831 and 2023.12.20260918 release notes.Already current
.github/workflows/eif-build.yml) are the latest releases, so they are unchanged.Held by the 7-day release-age floor
mise latest goresolves to 1.27.1), so it is held rather than forced. It includes security fixes: GO-2026-6599, GO-2026-6600 (html/template), GO-2026-6603, GO-2026-6605, GO-2026-6609, GO-2026-6610, GO-2026-6611, GO-2026-6612, GO-2026-6613, GO-2026-6617 (net/http), GO-2026-6607 (crypto/tlsECH), GO-2026-6608 (net/textproto), GO-2026-6604 (os, Windows only).govulncheckreports none of these as reachable from this module's code, which does not run an HTTP or TLS server. Next month's update will pick it up.golang.org/x/netv0.60.0/v0.61.0 (2026-10-08/09): v0.60.0 fixes HTTP/2 advisories GO-2026-6603, GO-2026-6610, GO-2026-6611, GO-2026-6612 and GO-2026-6617 inx/net/http2. The onlyx/netpackage in the build graph isx/net/bpf(viamdlayher/socket), so these do not apply.golang.org/x/sysv0.49.0 (2026-10-06),github.com/fxamacker/cbor/v2v2.9.6 (2026-10-06; v2.9.5 is retracted), andhub.lumenfield.work/shopspring/decimalv1.5.0 (2026-10-05, includes documented behavior changes): no security advisories; held for age.amazonlinux:20232023.12.20260930 (pushed 2026-10-05T19:30Z): fewer than 7 days old. Its container package changes are release metadata only.Risk assessment
Low. All Go changes are patch or minor releases with no API changes affecting this code, and no source changes were needed. The enclave runtime change most worth noting is
mdlayher/socket's context-cancelation fix on the vsock path: blocking socket operations now return on cancelation instead of waiting for the deadline. That is the intended behavior, and the enclave tests pass. The golangci-lint bump is limited to linter versions and reports no new findings. The base image moves forward by one monthly AL2023 release with library updates (curl, expat, openssl) thatdnf update -ywould already apply at build time. For mise,.mise/mise.lockstays at its current revision, and the locked install verifies every tool.Verification
go build ./...,go vet ./...,go test ./...andgo test -race ./...pass on Go 1.27.1.mise run //:test,//:lint(0 issues),//:tidy,//:ratchet:lintand//:ratchet:pin(no diff) pass under mise 2026.10.2..mise/mise.lockchecksums were compared against the upstream checksum sources and verified by downloading each artifact.govulncheck ./...reports no reachable vulnerabilities before or after the update.docker.ymlbuild command (statically linked; size change about +1 KB on each architecture).docker buildx buildofenclave/Dockerfileon the new base succeeds for linux/arm64 and linux/amd64 using those binaries, including thednflayers.Enclave measurements
The Go rebuild and the base image change alter the enclave image, so PCR0 and PCR2 of the next EIF will differ. PCR1 depends on the EIF builder kernel, which this PR does not change. After merge, the
update-pcrsjob in.github/workflows/eif-build.ymlappends the new set tovalidation/pcrs.json. The file is append-only andValidatePCRsaccepts a match against any recorded set, so previously built enclaves keep validating.validation/pcr.gois the only reader of that file in this repository. PCR8 does not apply because EIFs here are built unsigned.Pre-merge checklist
test,lint,Ratchet Lintpass onb980872. Every Go pin site onmain(docker.ymlgo-version,.mise/mise.lock) is moved by this PR. Test-merged with ci: bump upload-artifact to v7.0.2 and upgrade mise-action to the v5 major via ratchet #101 ontomain: clean.Post-merge verification
mainbuilds the arm64 enclave image with Go 1.27.1 and the new base digest. This is artifact publication. — Docker Build run 38417327680 on547b7basucceeded:Successfully set up Go version 1.27.1(go version go1.27.1),platforms: linux/arm64,FROM amazonlinux:2023@sha256:5b29412077a4….update-pcrsjob appends a new PCR0/PCR1/PCR2 entry tovalidation/pcrs.json. — Build EIF run 38417948934 (for547b7ba) succeeded; "Update PCR validation file" pushedcc66f4f, which adds 7 lines tovalidation/pcrs.jsonand removes none.