Repository navigation
Monthly update: Go 1.27.0, module dependencies, tool pins, and Amazon Linux 2023 base image - #64
Merged
Conversation
Bump github.com/fxamacker/cbor/v2 from v2.9.2 to v2.9.3 and github.com/stretchr/testify from v1.11.1 to v1.12.1. testify v1.12 absorbs its former go-spew and go-difflib dependencies and moves from gopkg.in/yaml.v3 to go.yaml.in/yaml/v3, so those three modules drop out of go.sum. testify is a graph-only module here: no package in this repository imports it, so it is bumped explicitly rather than by go get -u. github.com/mdlayher/socket is held at v0.6.1. v0.7.0 was published on 2026-09-06 and is below the minimum release age this update applies to newly resolved versions. The go directive moves from 1.26 to 1.26.0 as a side effect of go get -u; the following commit sets it to the new toolchain version.
Bump every pin that names a Go version, keeping them in sync: - go.mod: the go directive moves to 1.27, restoring the two-component precision go get -u had expanded to 1.26.0. - .mise/config.toml and .mise/mise.lock: go 1.26.5 -> 1.27.0, with per-platform archive URLs and sha256 checksums taken from https://go.dev/dl/?mode=json. All five archives were downloaded and checked against the recorded digests. - .github/workflows/docker.yml: the actions/setup-go go-version input, which compiles the enclave binary packaged into the released image. Leaving it behind would ship an artifact built with a different Go than CI tests against. Go 1.27.1 and 1.26.8 were both published on 2026-09-01 and are below the minimum release age this update applies; neither carries security fixes, so 1.27.0 (2026-08-19) is the newest qualifying release.
golangci-lint refuses to run when the Go release it was built with is older than the language version the module targets, so the move to Go 1.27 requires a linter that understands it: can't load config: the Go language version (go1.26) used to build golangci-lint is lower than the targeted Go version (1.27) 2.13.0 added go1.27 support; 2.13.2 is built with go1.27.0. Checksums come from the release's golangci-lint-2.13.2-checksums.txt and every archive was downloaded and checked against the recorded digest. .golangci.yml needs no migration. 2.13.0 deprecates exhaustruct in favour of exhaustruct_v5 and renames the govet-modernize waitgroup analyzer, but this configuration enables neither. golangci-lint run reports no issues against the updated tree.
ratchet is installed from source through the mise go backend, so the lock records only the version. 0.12.0 fixes an index-out-of-range failure, hardens YAML parsing, adds support for parallel step blocks in workflows, accepts non-semver tags, and skips container refs containing CI variables. Verified against this repository with 0.12.0 built by Go 1.27.0: ratchet lint passes on all four workflow files, and ratchet pin leaves no diff, which is what the Ratchet workflow checks.
VERSION and SHA256 move together. The checksum is the oras_1.3.4_linux_amd64.tar.gz line from the release's oras_1.3.4_checksums.txt. The step stays linux_amd64: ORAS runs on the GitHub runner to push the built EIF, not inside the enclave. This workflow uses oras version, login, push and tag. The breaking changes across 1.2.0 and 1.3.0 apply to attach, discover and cp, which are not used here. Verified with 1.3.4 locally: the same push invocation shape (--artifact-type, repeated --annotation, and two file:mediatype arguments) and oras tag both behave as before, and the non-interactive output stays plain when no TTY is attached.
Move the amazonlinux:2023 pin to the current multi-architecture index digest, resolved with docker buildx imagetools inspect. The registry, repository and 2023 tag are unchanged, so this stays on the same major. The index is an OCI image index carrying both linux/amd64 and linux/arm64, the two platforms this repository builds. The base moves from Amazon Linux 2023.12.20260727 to 2023.12.20260817: the same 106 packages with none added or removed, updating openssl-libs and openssl-fips-provider-latest from 3.5.5 to 3.5.7 along with crypto-policies, gawk, glib2, libxml2, python3 and rpm. Verified by building enclave/Dockerfile for linux/arm64 and linux/amd64 against the new digest with the locally cross-compiled binary, so the dnf update and install layers were exercised on both architectures.
There was a problem hiding this comment.
🔵 Needs a closer look
The major Go runtime change affects security-sensitive enclave serialization and artifact generation, warranting the requested human compatibility review.
Pull request overview
Refreshes the Go toolchain, dependencies, build tools, and enclave base image to address vulnerabilities and maintain current build infrastructure.
Changes:
- Upgrades Go to 1.27.0 and refreshes module dependencies.
- Updates golangci-lint, ratchet, and ORAS pins.
- Refreshes the Amazon Linux 2023 enclave image digest.
File summaries
| File | Description |
|---|---|
go.mod |
Updates Go and module versions. |
go.sum |
Refreshes dependency checksums. |
.mise/config.toml |
Updates local tool versions. |
.mise/mise.lock |
Pins updated tool archives and checksums. |
.github/workflows/docker.yml |
Builds release artifacts with Go 1.27.0. |
.github/workflows/eif-build.yml |
Upgrades the ORAS installation. |
enclave/Dockerfile |
Pins the refreshed Amazon Linux image. |
Review details
- Files reviewed: 5/7 changed files
- Comments generated: 0
- Review effort level: Balanced
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
6 tasks done
nickpell
added a commit
that referenced
this pull request
Oct 26, 2026
## Summary - Docker Build installs Go with `actions/setup-go` from `go-version-file: go.mod` instead of a `go-version: "1.27.3"` literal, so no workflow names a Go version. The `docker-build` PR check in `go.yml` uses the same step, in place of mise, so the published image's install step runs on every PR. - `go.mod` gains `toolchain go1.27.3`, which setup-go reads ahead of the `go` line. The `go` directive stays `1.27`: it is the minimum for every module that imports this one, and the `toolchain` line of a dependency is ignored, so importers are not held to the patch release. - `.mise/config.toml`'s `go` pin is still the version tests and lint run on. A new `check-go-version` task, run in the `lint` job, fails when `go.mod`'s toolchain line or `.mise/mise.lock` disagrees with it. A Go bump is: edit the pin, `MISE_LOCKED=0 mise lock go`, `go mod edit -toolchain=go<version>`. - The Go version does not change: 1.27.3 before and after. - cloudx-io/openarbiter#64 makes the same change in openarbiter. ## Notes for reviewers - #39 moved `go.yml` to mise and left `docker.yml` on setup-go with pin-only changes; no reason to keep that split is recorded. Since then each Go bump has edited `docker.yml`'s `go-version` by hand next to the mise pin (#64, #102, #117). - Docker Build runs only from `workflow_run` on `main` or a manual dispatch, and `workflow_run` uses the definition on `main`, so this PR cannot run the changed `docker.yml`. The `docker-build` job runs the identical setup-go step followed by the same `go build`. ## Pre-merge checklist - [x] `mise run //:check-go-version` passes, and fails naming the file when `go.mod` says `toolchain go1.27.2` or the pin says 1.27.4 with the lock and `go.mod` left at 1.27.3 - [x] `mise run //:lint`, `//:test`, `//:tidy` (keeps the `toolchain` line) and `//:ratchet:lint` pass locally on Go 1.27.3; actionlint reports nothing - [x] PR CI green on c6a1a24 (test, lint, docker-build, Ratchet Lint); `docker-build`'s setup-go step logs `Setup go version spec 1.27.3` and `go version go1.27.3`, and `lint` runs `check-go-version` - [x] Diff contains no unintended changes: `docker.yml`, `go.yml`, `go.mod` and the new task ## Post-merge verification - [ ] On the merge commit the main pipeline is green: Go, then Docker Build, then Build EIF, then the `[skip-build] Update PCR measurements` commit - [ ] Docker Build's setup-go step logs `Setup go version spec 1.27.3` 🤖 Generated with [Claude Code](https://claude.com/claude-code) --------- Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Monthly refresh of the Go module dependencies, the Go toolchain and the tool pins that move with it, and the pinned Amazon Linux 2023 enclave base image. Every verification named below was run locally against the updated tree.
The most consequential part of this update is the toolchain.
govulncheckagainst the pre-change tree reports a reachable standard-library vulnerability, GO-2026-5972 / CVE-2026-33818, a missing recursion limit inencoding/asn1that allows stack exhaustion on deeply nested input. It is reachable here, not merely present: the reported trace isvalidation.VerifyCOSESignaturecallingx509.ParseCertificate, which reachesasn1.Unmarshal, so it sits directly in the attestation certificate parsing path. It is fixed in go1.26.6 and in go1.27.0. The same scan lists seven further standard-library advisories fixed in go1.26.6 that this code does not call. After the updategovulncheckreports no vulnerabilities.Go module dependencies
github.com/fxamacker/cbor/v2from v2.9.2 to v2.9.3.github.com/stretchr/testifyfrom v1.11.1 to v1.12.1. testify v1.12 absorbs its formergo-spewandgo-difflibdependencies and moves fromgopkg.in/yaml.v3togo.yaml.in/yaml/v3, so those three modules drop out ofgo.sum. No package in this repository imports testify, sogo get -u -t ./...does not reach it and it was bumped explicitly.github.com/mdlayher/socketis held at v0.6.1. v0.7.0 was published on 2026-09-06, the day before this run, and is below the minimum release age applied to versions this job resolves.Go toolchain 1.26.5 to 1.27.0
Every pin that names a Go version moves together:
go.mod: thegodirective becomes1.27, preserving its existing two-component precision..mise/config.tomland.mise/mise.lock: thegotool version plus all five platform archive URLs and sha256 checksums, read fromhttps://go.dev/dl/?mode=json..github/workflows/docker.yml: theactions/setup-gogo-versioninput. This job compiles the enclave binary that is packaged into the released image, so leaving it behind would ship an artifact built with a different Go than CI tests against.golangci-lint 2.12.2 to 2.13.2
This is forced by the toolchain bump rather than chosen. golangci-lint refuses to start when the Go release it was built with is older than the language version the module targets, and 2.12.2 is built with go1.26.2, so against a
go 1.27module it fails withcan't load config: the Go language version (go1.26) used to build golangci-lint is lower than the targeted Go version (1.27). 2.13.0 added go1.27 support and 2.13.2 is built with go1.27.0..golangci.ymlneeds no migration. 2.13.0 deprecatesexhaustructin favour ofexhaustruct_v5and renames thegovet-modernizewaitgroupanalyzer towaitgroupgo, but this configuration enables neither.golangci-lint runreports no issues against the updated tree.ratchet 0.11.4 to 0.12.0
0.12.0 fixes an index-out-of-range failure, hardens YAML parsing, adds support for parallel step blocks in workflows, accepts non-semver tags, and skips container refs containing CI variables. ratchet is installed from source through the mise
gobackend, so the lock records only a version.ORAS 1.1.0 to 1.3.4
VERSIONandSHA256in the Install ORAS step of.github/workflows/eif-build.ymlmove together, with the checksum copied from theoras_1.3.4_linux_amd64.tar.gzline of that release'soras_1.3.4_checksums.txt. The step stayslinux_amd64because ORAS runs on the GitHub runner to push the built EIF, not inside the enclave.This is a long jump, so the breaking changes were checked against actual usage. The workflow uses
oras version,login,pushandtag. The breaking changes in 1.2.0 and 1.3.0 apply toattach,discoverandcp, none of which appear here.Amazon Linux 2023 base image
The
amazonlinux:2023pin inenclave/Dockerfilemoves to the current multi-architecture index digest,sha256:181f98c4...ce284, resolved withdocker buildx imagetools inspectrather than copied by hand. The registry, repository and2023tag are unchanged, so this stays on the same major. The index is an OCI image index and contains bothlinux/amd64andlinux/arm64, the two platforms this repository builds.The base moves from Amazon Linux 2023.12.20260727 to 2023.12.20260817, an update to the twelfth quarterly release. Comparing the two images directly shows the same 106 packages with none added or removed:
openssl-libsandopenssl-fips-provider-latestgo from 3.5.5 to 3.5.7, alongsidecrypto-policies,gawk,glib2,libxml2,python3andrpm. The OpenSSL step spans the 3.5.6 and 3.5.7 advisory batches, twenty-two CVEs of which one is rated High and five Moderate. Worth noting for scale: the enclave binary is built withCGO_ENABLED=0and is statically linked with no reference tolibsslorlibcrypto, so it does not use the image's OpenSSL, and the Dockerfile already runsdnf update -yat build time. The digest pin governs the reproducibility of the starting layer more than it governs package currency.Risk assessment
Go 1.27 is a language release rather than a patch, so its behavioural changes carry most of the risk here:
encoding/jsonis now backed by the new v2 implementation. Marshal and unmarshal behaviour is preserved but error message text may differ. This repository usesencoding/jsonin the enclave server, auction and proof paths, inenclaveapi, and in the validation commands. The full suite passes, including under-race.GOEXPERIMENT=nojsonv2is the upstream opt-out if a problem surfaces later.compress/flatechanged its encoder, and that reachescompress/gzip.enclaveapi.AttestationCOSE.CompressGzipgzips COSE attestation bytes for URL-safe transport, so the compressed bytes may differ from a Go 1.26 build. Nothing depends on that: the determinism test asserts only that two calls in the same process agree rather than comparing against a stored value, and validation decompresses before verifying the COSE signature, so a different DEFLATE encoding is transparent to the receiver.go 1.27modulesgo mod tidynow consolidates require blocks.go.modalready had exactly the two blocks it wants, so it is otherwise unchanged.The remaining bumps are low risk. The two module updates are patch and minor releases whose only visible effect is the
go.sumreshuffle described above, and the ratchet and ORAS bumps were exercised against this repository's own inputs rather than assessed from release notes alone.Enclave measurements
Rebuilding the enclave image moves PCR0 and PCR2, which is routine for any change reaching the enclave image; here both the Go rebuild and the base image refresh reach it. After merge the
update-pcrsjob in.github/workflows/eif-build.ymlappends the new set tovalidation/pcrs.json. That file is append-only andValidatePCRsaccepts a match against any recorded set, so previously built enclaves keep validating. No consumer ofvalidation/pcrs.jsonoutside this repository's ownvalidationpackage is visible from this repository.Upstream release age
Versions this job resolved were held to a minimum release age of seven days, judged from upstream publication timestamps. Two candidates were rejected. Go 1.27.1 and Go 1.26.8 were both published on 2026-09-01, six days before this run; the release notes describe both as bug-fix only with no security content, so the floor was not overridden and Go 1.27.0, published 2026-08-19, is the newest qualifying release.
github.com/mdlayher/socketv0.7.0 was published on 2026-09-06 and is held as described above. golangci-lint 2.13.2 (2026-08-27), ratchet 0.12.0 (2026-07-18), ORAS 1.3.4 (2026-08-27) and the Amazon Linux image (pushed 2026-08-20) all qualify..mise/config.tomlalready sets its own floor for mise-managed tools and is unchanged.Pre-merge checklist
go build ./...,go vet ./...,go test ./...andgo test -count=1 -race ./...all pass under Go 1.27.0. — CItest(mise run //:testunder the mise.lock Go 1.27.0) passed on 709fd56: https://github.com/cloudx-io/openauction/actions/runs/34106036212/job/101691142033;-raceandgo vetare the author's local run, not exercised by PR CI.golangci-lint runreports no issues with 2.13.2, and.golangci.ymlneeds no changes. — CIlint(mise run //:lint, golangci-lint 2.13.2 from mise.lock) passed on 709fd56: https://github.com/cloudx-io/openauction/actions/runs/34106036212/job/101691142334.go mod tidyleavesgo.modandgo.sumunchanged, which is what the//:tidycheck enforces. — samelintjob runsmise run //:tidy(git diff --exit-code go.mod go.sum); passed on 709fd56.ratchet lintpasses andratchet pinleaves no diff under 0.12.0, which is what the Ratchet workflow enforces. — CIRatchet Lintpassed on 709fd56: https://github.com/cloudx-io/openauction/actions/runs/34106036691/job/101691143311; ratchet v0.12.0 exists on proxy.golang.org (tag v0.12.0, 9ca11815, 2026-07-18).linux/arm64andlinux/amd64using the exact command from.github/workflows/docker.yml. PR CI runs only the Go and Ratchet workflows, so this is the only pre-merge coverage of the artifact that actually ships. — author's local run; not independently reproduced. First CI exercise is the post-merge Docker Build (workflow_runon Go).enclave/Dockerfilebuilds forlinux/arm64andlinux/amd64against the new base digest with those cross-compiled binaries, so thednf updateand install layers were exercised on both architectures rather than only resolving theFROM. — build is the author's local run; the digest was independently confirmed:sha256:181f98c4…ce284is the currentlibrary/amazonlinux:2023index on Docker Hub (pushed 2026-08-20T19:30Z), an OCI image index withlinux/amd64+linux/arm64/v8manifests, source revisionamazonlinux/container-images@bdaec0a0= "Add 2023.12.20260817.0 x86_64 image"; the outgoing694092ae…resolves to revision0c02d87a= 2023.12.20260727.0, matching the stated from/to..mise/mise.lockwas verified by downloading the archive and comparing digests, not just transcribed. — independently re-checked: all 5go1.27.0.*sha256 values matchhttps://go.dev/dl/?mode=jsonand all 5golangci-lint-2.13.2-*values match the release'sgolangci-lint-2.13.2-checksums.txt(v2.13.2 published 2026-08-27).pushandtaginvocation shapes this workflow uses behave the same on 1.3.4. —f27adb93…c454matches theoras_1.3.4_linux_amd64.tar.gzline of upstreamoras_1.3.4_checksums.txt(release v1.3.4, 2026-08-27, not prerelease); thepush/tagbehaviour claim is the author's local run and is first exercised by the post-merge Build EIF.govulncheckreports no known vulnerabilities against the updated tree. — author's local run; the vuln DB record for GO-2026-5972 (CVE-2026-33818,encoding/asn1) lists fixes at 1.25.13 / 1.26.6 / 1.27.0-rc.3, so 1.27.0 carries the fix.encoding/jsonv2 switch is acceptable for the enclave request, proof and validation paths. — accepted by nickpell at the merge gate (merge requested 2026-09-08, squash f6cbe73).Post-merge verification
Post-merge outcome (2026-09-08). Go, Docker Build (34249459364) and Build EIF (34249776263) all succeeded on f6cbe73.
Install ORASverifiedoras_1.3.4_linux_amd64.tar.gz: OKand reportedVersion: 1.3.4;oras pushpublishedenclave-eif:f6cbe73b…andoras tagappliedf6cbe73-arm64. The EIF built on the refreshed base with PCR0f5a297a8…938e7dd;update-pcrscommitted dd5bd21 (validation/pcrs.json+7/−0, earlier entries intact).update-pcrsjob appends a new PCR set tovalidation/pcrs.jsonin its[skip-build]commit and leaves the earlier entries intact.oras pushandoras tagsucceed on the runner, since that first post-merge EIF build is the first CI run to exercise the 1.3.4 pin.