This repository was archived by the owner on Jan 5, 2024. It is now read-only.
Repository navigation
GI#66, CF#243 - Background Layer Improvements - #399
Merged
garethyr merged 102 commits intoJul 24, 2022
Merged
Conversation
# Conflicts: # Entities/SLTerrain.cpp Resolved manually
…lable globally for SLBackground animation
…whole backbuffer so background layers are displayed correctly in splitscreen
… when the viewport is on the right edge of a non-wrapping scene
…compressed saving doesn't freeze game every time returning from MetaGame scene to overview
# Conflicts: # Entities/MOSprite.h # Lua/LuaBindingsEntities.cpp Resolved manually
# Conflicts: # Entities/MovableObject.h # Managers/SettingsMan.cpp # Managers/SettingsMan.h Resolved manually
MaximDude
added
bug
# Conflicts: # Entities/Material.cpp # Entities/SLTerrain.h # Entities/SceneLayer.h # Entities/TerrainObject.h # Lua/LuaBindingsManagers.cpp # Managers/MovableMan.cpp # Menus/SceneEditorGUI.cpp Resolved manually
garethyr
suggested changes
Mar 8, 2022
garethyr
left a comment
garethyr
left a comment
There was a problem hiding this comment.
Good job on the whole. Bunch of comments and questions though, we'll probably have to chat about some stuff cause there are things I definitely don't really understand haha
# Conflicts: # CHANGELOG.md Resolved manually
garethyr
approved these changes
Jul 24, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
SLBackgroundto specifically deal with scene background layers. See changelog.Materialbackground textures. See changelog.TerrainObjectsprite handling. See changelog.This will need pre4 testing branch merged into dev and dev merged into this after pre4 is out.