Conversation
|
The artifact produced by the workflow running for this PR produces the expected binary type: |
There was a problem hiding this comment.
Copilot review overview
🟢 Approval recommended
The focused workflow change correctly builds and uniquely names the ARM64 artifact.
Review effort: Balanced
Findings: None
What changed in this PR
Adds an ARM64 Linux binary for CodeQL’s proxy integration.
Changes:
- Adds
ubuntu-24.04-armto the build matrix. - Names its artifact
dependabot-proxy-linux-arm64.
| File | Description |
|---|---|
.github/workflows/ci.yml |
Builds and uploads the ARM64 Linux proxy artifact. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
jeffwidman
left a comment
There was a problem hiding this comment.
Works for me!
As far as regularly releases of the proxy, I suspect non one on the Dependabot team at GitHub would mind you cutting releases, but for our workflows probably not something that really matters to us.
But we should probably take that discussion internally so feel free to raise it as a topic on the Github internal slack #dependabot channel.
| - windows-latest | ||
| # There's no `ubuntu-latest-arm`; `24.04` matches the version used by `ubuntu-latest` | ||
| # at the time of writing. | ||
| - ubuntu-24.04-arm |
There was a problem hiding this comment.
ubunut-latest is shifting to 26.04 in late Oct-November timeframe.
@mbg can you own circling back at that point to bump this up then?
There was a problem hiding this comment.
I'd be also very okay with simply starting with this on ubuntu-26.04-arm as of right now from the jump.
That way we don't have to circle back and it wont be out of sync for more than a month...
What are you trying to accomplish?
CodeQL has recently started supporting
arm64-based Linux platforms. The Dependabot proxy is used by thegithub/codeql-action/start-proxyaction, but we don't currently generate suitable binaries here. As a result, Code Scanning Default Setup workflows that otherwise now supportarm64-based Linux runners choke on thegithub/codeql-action/start-proxystep. This PR addsubuntu-24.04-armto the build matrix for thebuild-codeqljob in theci.ymlworkflow to produce suitable binaries for that platform.Anything you want to highlight for special attention from reviewers?
This extends this setup that was previously added in a PR on the internal repository before it was open-sourced.
Now that this repository is open-source, it would be nice if we had proper releases of the proxy.
How will you know you've accomplished your goal?
Once the workflow successfully produces compatible binaries, I will test these separately with a modified
github/codeql-action/start-proxyin a test repository.Checklist