Skip to content

Add ubuntu-24.04-arm to build-codeql matrix #266

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jeffwidman merged 1 commit into from
Sep 29, 2026
Merged

Add ubuntu-24.04-arm to build-codeql matrix #266

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 11 additions & 4 deletions .github/workflows/ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -62,7 +62,7 @@ jobs:
- run: go vet ./...

# The `github/codeql-action/start-proxy` action uses native binaries for
# Linux, macOS, and Windows.
# Linux (x86 and arm64), macOS, and Windows.
build-codeql:
name: Build (${{ matrix.os }})
runs-on: ${{ matrix.os }}
Expand All @@ -74,6 +74,9 @@ jobs:
- ubuntu-latest
- macos-latest
- windows-latest
# There's no `ubuntu-latest-arm`; `24.04` matches the version used by `ubuntu-latest`
# at the time of writing.
- ubuntu-24.04-arm

@jeffwidman jeffwidman Sep 25, 2026

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ubunut-latest is shifting to 26.04 in late Oct-November timeframe.

@mbg can you own circling back at that point to bump this up then?

@jeffwidman jeffwidman Sep 25, 2026

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd be also very okay with simply starting with this on ubuntu-26.04-arm as of right now from the jump.

That way we don't have to circle back and it wont be out of sync for more than a month...

@mbg mbg Sep 28, 2026

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll leave it on 24.04 for now and set myself a reminder to review it in late Oct-November. My reasoning is that, even though -latest may switch then, there is probably no harm in still running this on 24.04 beyond that as long as it is supported. I.e. I am not currently aware of a reason why it would have to match latest.

@jeffwidman jeffwidman Sep 29, 2026

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sounds fine.

I would prefer for simplicity of debugging that we generally align to latest but these days with LLMs that kind of debugging pain is handled by the bots 😄

I look forward to seeing the bump PR in a few months. Make it a Christmas present or something for me. 😺


permissions:
contents: read
Expand Down Expand Up @@ -103,13 +106,17 @@ jobs:
- name: Set output name
id: platform
shell: bash
env:
MATRIX_OS: ${{ matrix.os }}
run: |
if [[ "${{ matrix.os }}" == "ubuntu-latest" ]]; then
if [[ "$MATRIX_OS" == "ubuntu-latest" ]]; then
echo "name=linux64" >> $GITHUB_OUTPUT;
elif [[ "${{ matrix.os }}" == "macos-latest" ]]; then
elif [[ "$MATRIX_OS" == "macos-latest" ]]; then
echo "name=osx64" >> $GITHUB_OUTPUT;
elif [[ "${{ matrix.os }}" == "windows-latest" ]]; then
elif [[ "$MATRIX_OS" == "windows-latest" ]]; then
echo "name=win64" >> $GITHUB_OUTPUT;
elif [[ "$MATRIX_OS" == "ubuntu-24.04-arm" ]]; then
echo "name=linux-arm64" >> $GITHUB_OUTPUT;
fi

- name: Compress binary artifact
Expand Down
Loading