refactor: migrate Boost.Python syntax to nanobind - #89
Conversation
chore: updated pre-commit hook dependencies
…nd BondCalculator
…nd libdiffpy_version
…ty and PDFBaseline
|
@sbillinge Please see if this is what we want. |
|
@SYMSCAE This PR is still failing. I suspect it is because we haven't updated the dependencies for this package ( |
Migration work in those repos is on |
|
@SYMSCAE @stevenhua0320 we need to merge this to move the 3D PDF calculator forward. Please can we work on getting the dependency issue resolved so we can move forward? This is a bit urgent. |
|
@SYMSCAE Let's first work on |
Hi Steven, I believe we don’t need to touch pyobjcryst. The only change in upstream library is libdiffpy, which is requiring a new conda release. After that we should be good to pass rest of the tests. |
|
Hi @SYMSCAE @stevenhua0320 @sbillinge, I have opened diffpy/libdiffpy#50, which ports Once #50 is merged and #89 provides a stable nanobind base, I’ll add the corresponding Please feel free to let me know if I can help with any related issues or reviews in the meantime. I’d be happy to assist. |
|
@joeseaer it could help us if you could lead the nanobind migration as we are still 1 month away from being back in session and this is not the focus of @SYMSCAE and @stevengeorge128, our c++ folks, at the moment. Basically, we want to figure out how to do the testing on libdiffpy @joeseaer would you be able to take that on and report back all the steps and the results? |
This PR is the initial port that migrates the original Boost.Python bindings to nanobind as mentioned in diffpy/pyobjcryst#88, noticed future improvements will be mentioned in TODOs but will be addressed in future PRs.