ENH: add ThreeDPDFCalculator support - #50
Conversation
sbillinge
left a comment
There was a problem hiding this comment.
I am not c++ expert so I have little to say I am afraid, but from a project point of view, this looks great. Much better integrated. Thanks for that @joeseaer.
It would be great if @stevengeorge128 or @SYMSCAE have time to look at it and make any comments about the code implementation, but otherwise I am happy to merge it when we are ready. We still need to do the nanobind ports before we merge this I think.
There is another discussion to be had with @cadenmyers13 and that is whether we make this a separate pack or include it in the cmipdf pack. It reuses much of the PDF code, so putting it into that pack would probably be the best.
|
@sbillinge Code itself looks good to me. I will move diffpy.srreal migration forward so it can sit there better. |
Hi @sbillinge,
This PR supersedes #49 and ports the 3D PDF calculator work onto the
migration-nanobranch.ThreeDPDFCalculatorimplementation.PDF3DCalculatoridentifiers, files, tests, and serialization registrations.PDFCalculatorhelpers for scattering factors, partial PDF scaling, and RDF normalization.REAL=doublecompatibility fix.No legacy
PDF3DCalculatornames remain in the source code, tests, or filenames.Testing:
I would really appreciate it if you could spare some time to review this PR.
If you have any feedback or adjustments you'd like to make, feel free to let me know and I'll update it promptly.
Thank you so much for your time and guidance!