Repository navigation
[REG2.067a] Issue 14198 - Link failure with Variant - #4464
Merged
Merged
Conversation
Member
|
The "workaround" stays in Phobos. The original code did memory allocation to implement |
Contributor
Author
|
The root issue is in |
Member
|
Thanks for finding & fixing the compiler bug. |
WalterBright
added a commit
that referenced
this pull request
Mar 10, 2015
[REG2.067a] Issue 14198 - Link failure with Variant
Member
|
@9rnsr you think we should get this into 2.067 or will the Phobos workaround suffice? |
Contributor
Author
|
@MartinNowak This fix should go into 2.067. There was not only a link-failure issue, but also was incorrect attribute inference problem. Following code does not compile with 2.067-beta2. import std.conv;
void main() pure @safe { auto s = to!string(true); } |
Member
|
This pull request seems to have fixed a compiler crash (and Phobos-introduced regression): |
9rnsr
added a commit
to 9rnsr/dmd
that referenced
this pull request
May 31, 2015
…redicate Just adding a test case so the SEGV problem was already fixed in the PR dlang#4464.
9rnsr
added a commit
to 9rnsr/dmd
that referenced
this pull request
Aug 27, 2015
9rnsr
added a commit
to 9rnsr/dmd
that referenced
this pull request
Aug 28, 2015
…ms broken The broken behavior has been revealed since the commit/PR: f22d9db dlang#4464 By the fix, some attribute inference order bug for template functions had been fixed - when foo() calls bar!(), and bar!() calls baz!(), the bar!() attribute should be inferred after the attrs of baz!() determined. And then, compiler infers the purity of nested two lambdas in the 14962 test case, and the case has been rejected by the 14781 behavior.
9rnsr
added a commit
to 9rnsr/dmd
that referenced
this pull request
Aug 28, 2015
…ms broken It has been revealed since the commit/PR: f22d9db dlang#4464 By the fix, some attribute inference order bug for template functions had been fixed - when foo() calls bar!(), and bar!() calls baz!(), the bar!() attribute should be inferred after the attrs of baz!() determined. And then, compiler infers the purity of nested two lambdas in the 14962 test case, and the case has been rejected by the 14781 behavior.
9rnsr
added a commit
to 9rnsr/dmd
that referenced
this pull request
Aug 28, 2015
…ms broken It has been revealed since the commit/PR: f22d9db dlang#4464 By the fix, some attribute inference order bug for template functions had been fixed - when foo() calls bar!(), and bar!() calls baz!(), the bar!() attribute should be inferred after the attrs of baz!() determined. And then, compiler infers the purity of nested two lambdas in the 14962 test case, and the case has been rejected by the 14781 behavior.
9rnsr
added a commit
to 9rnsr/dmd
that referenced
this pull request
Aug 28, 2015
…ms broken It has been revealed since the commit/PR: f22d9db dlang#4464 By the fix, some attribute inference order bug for template functions had been fixed - when foo() calls bar!(), and bar!() calls baz!(), the bar!() attribute should be inferred after the attrs of baz!() determined. And then, compiler infers the purity of nested two lambdas in the 14962 test case, and the case has been rejected by the 14781 behavior.
9rnsr
added a commit
to 9rnsr/dmd
that referenced
this pull request
Aug 29, 2015
…ms broken It has been revealed since the commit/PR: f22d9db dlang#4464 By the fix, some attribute inference order bug for template functions had been fixed - when foo() calls bar!(), and bar!() calls baz!(), the bar!() attribute should be inferred after the attrs of baz!() determined. And then, compiler infers the purity of nested two lambdas in the 14962 test case, and the case has been rejected by the 14781 behavior.
ldc-bot
pushed a commit
to ldc-developers/dmd-testsuite
that referenced
this pull request
Sep 24, 2015
…ms broken It has been revealed since the commit/PR: f22d9dbb42b6a32d5b4c7c9f3db45e07c9f8aaf6 dlang/dmd#4464 By the fix, some attribute inference order bug for template functions had been fixed - when foo() calls bar!(), and bar!() calls baz!(), the bar!() attribute should be inferred after the attrs of baz!() determined. And then, compiler infers the purity of nested two lambdas in the 14962 test case, and the case has been rejected by the 14781 behavior.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://issues.dlang.org/show_bug.cgi?id=14198
After this fix, we can remove the workaround in Phobos.