Repository navigation
[REG2.067/2.068] Issue 14781 & 14962 - fix problematic purity inference introduced in #3626 - #4970
Merged
Merged
Conversation
9rnsr
force-pushed
the
fix14781
branch
2 times, most recently
from
August 28, 2015 22:50
f8c3d3c to
6663e9e
Compare
…able to modify context
…ms broken It has been revealed since the commit/PR: f22d9db dlang#4464 By the fix, some attribute inference order bug for template functions had been fixed - when foo() calls bar!(), and bar!() calls baz!(), the bar!() attribute should be inferred after the attrs of baz!() determined. And then, compiler infers the purity of nested two lambdas in the 14962 test case, and the case has been rejected by the 14781 behavior.
MartinNowak
added a commit
that referenced
this pull request
Aug 30, 2015
[REG2.067/2.068] Issue 14781 & 14962 - fix problematic purity inference introduced in #3626
Contributor
Author
|
thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue 14781 - [REG2.067] impure delegate to pure function context should be able to modify context
Issue 14962 - [REG2.068] compiler inference of attributes for nested map seems broken
Issue 14962 is has been revealed since the PR #4464.
By the fix, some attribute inference order bug for template functions had been fixed - when
foo()callsbar!(), andbar!()callsbaz!(), thebar!()attribute should be inferred after the attrs ofbaz!()determined.And then, compiler infers the purity of nested two lambdas in the 14962 test case, and the case has been rejected by the 14781 behavior.
So, fixing issue 14781 also fixes 14962 at the same time.